* [PATCH] PCI: aspeed: Drop PROBE_PREFER_ASYNCHRONOUS to fix enumeration race
@ 2026-11-09 11:57 Jacky Chou
0 siblings, 0 replies; only message in thread
From: Jacky Chou @ 2026-11-09 11:57 UTC (permalink / raw)
To: Lorenzo Pieralisi, Krzysztof Wilczyński,
Manivannan Sadhasivam, Rob Herring, Bjorn Helgaas, Joel Stanley,
Andrew Jeffery, Ryan Chen, Billy Tsai
Cc: linux-aspeed, linux-pci, linux-arm-kernel, linux-kernel, Jacky Chou
The ASPEED PCIe RC driver opts in to asynchronous probing via
PROBE_PREFER_ASYNCHRONOUS. This allows the driver core to probe it
on a kthread in parallel with other drivers instead of waiting for
it to finish during the synchronous probe pass.
On boards where a PCIe endpoint driver is bound early (e.g. built
into the kernel or probed from an initcall that runs before late_
initcall), this races against the RC driver: the EP driver can start
probing before the RC driver has finished enumerating the bus, so the
EP device is not yet present and the EP driver fails to bind.
Remove PROBE_PREFER_ASYNCHRONOUS so the RC driver probes
synchronously again, guaranteeing that bus enumeration completes
before any downstream EP driver's probe() runs.
Fixes: 9aa0cb68fcc1 ("PCI: aspeed: Add ASPEED PCIe RC driver")
Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
drivers/pci/controller/pcie-aspeed.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-aspeed.c b/drivers/pci/controller/pcie-aspeed.c
index ecb7562f84c0..def5591010ca 100644
--- a/drivers/pci/controller/pcie-aspeed.c
+++ b/drivers/pci/controller/pcie-aspeed.c
@@ -1104,7 +1104,6 @@ static struct platform_driver aspeed_pcie_driver = {
.name = "aspeed-pcie",
.of_match_table = aspeed_pcie_of_match,
.suppress_bind_attrs = true,
- .probe_type = PROBE_PREFER_ASYNCHRONOUS,
},
.probe = aspeed_pcie_probe,
};
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261109-aspeed-pcie-sync-probe-fa1d96eb3ce9
Best regards,
--
Jacky Chou <jacky_chou@aspeedtech.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-09 11:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-09 11:57 [PATCH] PCI: aspeed: Drop PROBE_PREFER_ASYNCHRONOUS to fix enumeration race Jacky Chou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®