* [PATCH v2] extcon: max77843: convert to module_platform_driver()
@ 2026-11-09 17:47 Brian Masney
0 siblings, 0 replies; only message in thread
From: Brian Masney @ 2026-11-09 17:47 UTC (permalink / raw)
To: Chanwoo Choi, Krzysztof Kozlowski, MyungJoo Ham
Cc: linux-kernel, Krzysztof Kozlowski, Brian Masney
This driver is currently registered at the subsys_initcall level,
however this driver shouldn't be needed for early boot, and can be
converted to use the standard module_init().
This driver already has the standard MODULE_DEVICE_TABLE(), is
configured in the Kconfig to be a tristate, and the driver doesn't
have suppress_bind_attrs set, so let's go ahead and reduce boilerplate
code in this driver and convert it over to use the macro
module_platform_driver().
Note that currently there is no __exit function defined and this change
will add an __exit function that unregisters the platform driver.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Brian Masney <bmasney@redhat.com>
---
Changes in v2:
- Change from module_platform_driver() to subsys_platform_driver() (Krzk)
- Link to v1: https://patch.msgid.link/20261106-extcon-subsys-v1-1-6a781b323d6f@redhat.com
---
drivers/extcon/extcon-max77843.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 2ae9f7f1a67f..7fa42e3cf848 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -960,11 +960,7 @@ static struct platform_driver max77843_muic_driver = {
.id_table = max77843_muic_id,
};
-static int __init max77843_muic_init(void)
-{
- return platform_driver_register(&max77843_muic_driver);
-}
-subsys_initcall(max77843_muic_init);
+module_platform_driver(max77843_muic_driver);
MODULE_DESCRIPTION("Maxim MAX77843 Extcon driver");
MODULE_AUTHOR("Jaewon Kim <jaewon02.kim@samsung.com>");
---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
change-id: 20261106-extcon-subsys-24280aaba499
Best regards,
--
Brian Masney <bmasney@redhat.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-09 17:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-09 17:47 [PATCH v2] extcon: max77843: convert to module_platform_driver() Brian Masney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®