mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/3] media: ov9734, ipu-bridge: Enable the camera on the Intel NUC M15
@ 2026-11-09 18:17 Tin Posavec via B4 Relay
  2026-11-09 18:17 ` [PATCH v2 1/3] media: i2c: ov9734: Return -EPROBE_DEFER if no endpoint is found Tin Posavec via B4 Relay
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Tin Posavec via B4 Relay @ 2026-11-09 18:17 UTC (permalink / raw)
  To: Sakari Ailus, Bingbu Cao, Mauro Carvalho Chehab, Dan Scally,
	Hans de Goede
  Cc: linux-media, linux-kernel, Afonso Figuinha, Tin Posavec

Hi,

The camera on the Intel NUC M15 laptop (LAPRC710, Alder Lake-P, IPU6)
does not work with mainline. It is an OmniVision OV9734 (OVTI9734) whose
avdd supply and clock come from an INT3472 discrete device; its ACPI
device has neither _PS0 nor _PR0.

Patch 1 makes ov9734 defer its probe until ipu-bridge has created the
endpoint, patch 2 adds power on/off sequencing with runtime PM, and
patch 3 adds the sensor to ipu-bridge. The camera needs all three.
Patch 1 relies on commit 8015a49d8b33 ("media: v4l2-fwnode: Return
-EPROBE_DEFER on parsing NULL endpoints"), which is in v7.1, so a
backport to an older kernel needs that commit as well (v1 did not
depend on it).

v1 was tested on the NUC M15 with Ubuntu's 7.0.0-38 kernel (7.0.14) and
the series backported. The sensor streamed 1296x734 SGRBG10 at 30 fps
(libcamera, simple pipeline, software ISP); it was powered off when
idle, and s2idle worked with the camera idle. Not tested: S3 and kernels
with lock debugging enabled. v4l2-compliance: 45/46, the SUBSCRIBE_EVENT
failure is pre-existing (no V4L2_SUBDEV_FL_HAS_EVENTS).

Afonso Figuinha also tested v1 on a Surface Laptop 1 (IPU3) with
6.19.8-surface-3, with the ipu-bridge entry of patch 3 added by hand:
probe, streaming 1280x704 NV12 at 30 fps (libcamera, IPU3 pipeline),
runtime suspend, module reload and v4l2-compliance (45/46). He did not
test probe deferral at boot or system suspend.

I no longer have the NUC M15, so v2 is only build-tested, not tested
on hardware. The main functional change is in patch 2, which now waits
for 8192 external clock cycles (about 427 us) instead of 20 ms after
power-on, so testing on hardware would be very welcome.

I used an AI coding assistant (Claude Code) to track down the cause,
compare with how other sensor drivers handle this, and draft the
patches. I have gone through every change myself and I am responsible
for the result.

---
Changes in v2:
- Patch 1: Drop the endpoint check and return the error code of
  v4l2_fwnode_endpoint_alloc_parse() instead (Sakari).
- Patch 2: Drop two comments, wait for 8192 external clock cycles after
  power-on instead of 20 ms, and request only the reset GPIO (Sakari).
- Patch 3: Drop the NUC M15 test result from the commit message, as it
  was for the whole v1 series; testing is described above.
- Patches 1 and 3: Add Afonso's Tested-by from v1. It is not added to
  patch 2, as its power-on sequence and GPIO handling changed.
- Drop the Assisted-by tags, see commit 1e035297ffda ("docs: remove
  Assisted-by references").
- Rebase on media-committers next (v7.4-rc1).
- Link to v1: https://patch.msgid.link/20261017-ov9734-ipu6-v1-0-86eab22ae258@gmail.com

---
Tin Posavec (3):
      media: i2c: ov9734: Return -EPROBE_DEFER if no endpoint is found
      media: i2c: ov9734: Add power on/off sequencing support
      media: ipu-bridge: Add OV9734 sensor config

 drivers/media/i2c/ov9734.c           | 124 ++++++++++++++++++++++++++++++-----
 drivers/media/pci/intel/ipu-bridge.c |   2 +
 2 files changed, 111 insertions(+), 15 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261017-ov9734-ipu6-4dc9d1792c28

Best regards,
--  
Tin Posavec <tin.posavec04@gmail.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-09 18:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-09 18:17 [PATCH v2 0/3] media: ov9734, ipu-bridge: Enable the camera on the Intel NUC M15 Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 1/3] media: i2c: ov9734: Return -EPROBE_DEFER if no endpoint is found Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 2/3] media: i2c: ov9734: Add power on/off sequencing support Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 3/3] media: ipu-bridge: Add OV9734 sensor config Tin Posavec via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®