* [PATCH v2 1/3] media: i2c: ov9734: Return -EPROBE_DEFER if no endpoint is found
2026-11-09 18:17 [PATCH v2 0/3] media: ov9734, ipu-bridge: Enable the camera on the Intel NUC M15 Tin Posavec via B4 Relay
@ 2026-11-09 18:17 ` Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 2/3] media: i2c: ov9734: Add power on/off sequencing support Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 3/3] media: ipu-bridge: Add OV9734 sensor config Tin Posavec via B4 Relay
2 siblings, 0 replies; 4+ messages in thread
From: Tin Posavec via B4 Relay @ 2026-11-09 18:17 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao, Mauro Carvalho Chehab, Dan Scally,
Hans de Goede
Cc: linux-media, linux-kernel, Afonso Figuinha, Tin Posavec
From: Tin Posavec <tin.posavec04@gmail.com>
With ipu-bridge, the fwnode graph endpoint of the sensor is only created
when ipu-bridge is initialized, which may happen after the sensor driver
has first probed. ov9734_check_hwcfg() then returns -ENXIO, so the probe
fails and is not retried, and the sensor stays unbound.
Drop the check for a missing endpoint and return the error code of
v4l2_fwnode_endpoint_alloc_parse() instead, which is -EPROBE_DEFER for
a NULL endpoint since commit 8015a49d8b33 ("media: v4l2-fwnode: Return
-EPROBE_DEFER on parsing NULL endpoints"). Report the error with
dev_err_probe(), so that the reason for a deferral is recorded and
parsing errors are logged.
Also drop the generic error message from probe, which would otherwise
be logged on every deferred probe attempt.
Signed-off-by: Tin Posavec <tin.posavec04@gmail.com>
Tested-by: Afonso Figuinha <afonso.figuinha@gmail.com> # Surface Laptop 1 (IPU3)
---
drivers/media/i2c/ov9734.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/media/i2c/ov9734.c b/drivers/media/i2c/ov9734.c
index 8f39609ad..49711fa17 100644
--- a/drivers/media/i2c/ov9734.c
+++ b/drivers/media/i2c/ov9734.c
@@ -838,13 +838,10 @@ static int ov9734_check_hwcfg(struct device *dev)
return -ENXIO;
ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
- if (!ep)
- return -ENXIO;
-
ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
fwnode_handle_put(ep);
if (ret)
- return ret;
+ return dev_err_probe(dev, ret, "failed to parse endpoint\n");
if (!bus_cfg.nr_of_link_frequencies) {
dev_err(dev, "no link frequencies defined");
@@ -893,11 +890,8 @@ static int ov9734_probe(struct i2c_client *client)
int ret;
ret = ov9734_check_hwcfg(&client->dev);
- if (ret) {
- dev_err(&client->dev, "failed to check HW configuration: %d",
- ret);
+ if (ret)
return ret;
- }
ov9734 = devm_kzalloc(&client->dev, sizeof(*ov9734), GFP_KERNEL);
if (!ov9734)
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 2/3] media: i2c: ov9734: Add power on/off sequencing support
2026-11-09 18:17 [PATCH v2 0/3] media: ov9734, ipu-bridge: Enable the camera on the Intel NUC M15 Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 1/3] media: i2c: ov9734: Return -EPROBE_DEFER if no endpoint is found Tin Posavec via B4 Relay
@ 2026-11-09 18:17 ` Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 3/3] media: ipu-bridge: Add OV9734 sensor config Tin Posavec via B4 Relay
2 siblings, 0 replies; 4+ messages in thread
From: Tin Posavec via B4 Relay @ 2026-11-09 18:17 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao, Mauro Carvalho Chehab, Dan Scally,
Hans de Goede
Cc: linux-media, linux-kernel, Afonso Figuinha, Tin Posavec
From: Tin Posavec <tin.posavec04@gmail.com>
So far the driver has relied on ACPI to power the sensor on and off. On
the Intel NUC M15 (LAPRC710), however, the sensor's ACPI device has
neither _PS0 nor _PR0. Its avdd supply and clock are provided by an
INT3472 discrete device instead, and as the driver does not enable
them, reading the chip ID in probe fails with -EREMOTEIO.
Get the dovdd, avdd and dvdd supplies and the optional reset GPIO, and
power the sensor on and off in the runtime PM callbacks. Also power it
on in probe before identifying it, and off on probe errors and in
remove() if it is still powered on. The 2 ms reset assertion time is
taken from ov01a10. After releasing reset, or after enabling the clock
if there is no reset GPIO, wait for 8192 external clock cycles (about
427 us at 19.2 MHz) before accessing the sensor.
Move pm_runtime_idle() after the sub-device registration, so that the
sensor is not powered off twice if the registration fails, and drop the
comment saying that the I2C core has already powered the device on.
Signed-off-by: Tin Posavec <tin.posavec04@gmail.com>
---
drivers/media/i2c/ov9734.c | 114 ++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 107 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/ov9734.c b/drivers/media/i2c/ov9734.c
index 49711fa17..c359a4746 100644
--- a/drivers/media/i2c/ov9734.c
+++ b/drivers/media/i2c/ov9734.c
@@ -4,9 +4,13 @@
#include <linux/acpi.h>
#include <linux/clk.h>
#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
+#include <linux/math.h>
#include <linux/module.h>
#include <linux/pm_runtime.h>
+#include <linux/regulator/consumer.h>
+#include <linux/time.h>
#include <linux/unaligned.h>
#include <media/v4l2-ctrls.h>
@@ -16,6 +20,7 @@
#define OV9734_LINK_FREQ_180MHZ 180000000ULL
#define OV9734_SCLK 36000000LL
#define OV9734_MCLK 19200000
+#define OV9734_POWER_ON_DELAY_CYCLES 8192
/* ov9734 only support 1-lane mipi output */
#define OV9734_DATA_LANES 1
#define OV9734_RGB_DEPTH 10
@@ -322,9 +327,17 @@ static const struct ov9734_mode supported_modes[] = {
},
};
+static const char * const ov9734_supply_names[] = {
+ "dovdd", /* Digital I/O power */
+ "avdd", /* Analog power */
+ "dvdd", /* Digital core power */
+};
+
struct ov9734 {
struct device *dev;
struct clk *clk;
+ struct gpio_desc *reset;
+ struct regulator_bulk_data supplies[ARRAY_SIZE(ov9734_supply_names)];
struct v4l2_subdev sd;
struct media_pad pad;
@@ -870,6 +883,76 @@ static int ov9734_check_hwcfg(struct device *dev)
return ret;
}
+static int ov9734_get_pm_resources(struct ov9734 *ov9734)
+{
+ int ret;
+
+ ov9734->reset = devm_gpiod_get_optional(ov9734->dev, "reset",
+ GPIOD_OUT_HIGH);
+ if (IS_ERR(ov9734->reset))
+ return dev_err_probe(ov9734->dev, PTR_ERR(ov9734->reset),
+ "failed to get reset gpio\n");
+
+ for (unsigned int i = 0; i < ARRAY_SIZE(ov9734_supply_names); i++)
+ ov9734->supplies[i].supply = ov9734_supply_names[i];
+
+ ret = devm_regulator_bulk_get(ov9734->dev,
+ ARRAY_SIZE(ov9734_supply_names),
+ ov9734->supplies);
+ if (ret)
+ return dev_err_probe(ov9734->dev, ret,
+ "failed to get regulators\n");
+
+ return 0;
+}
+
+static int ov9734_power_on(struct device *dev)
+{
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
+ struct ov9734 *ov9734 = to_ov9734(sd);
+ int ret;
+
+ ret = regulator_bulk_enable(ARRAY_SIZE(ov9734_supply_names),
+ ov9734->supplies);
+ if (ret) {
+ dev_err(dev, "failed to enable regulators: %d\n", ret);
+ return ret;
+ }
+
+ ret = clk_prepare_enable(ov9734->clk);
+ if (ret) {
+ dev_err(dev, "failed to enable clock: %d\n", ret);
+ regulator_bulk_disable(ARRAY_SIZE(ov9734_supply_names),
+ ov9734->supplies);
+ return ret;
+ }
+
+ if (ov9734->reset) {
+ fsleep(2 * USEC_PER_MSEC);
+ gpiod_set_value_cansleep(ov9734->reset, 0);
+ }
+
+ fsleep(DIV_ROUND_UP(OV9734_POWER_ON_DELAY_CYCLES * USEC_PER_MSEC,
+ OV9734_MCLK / MSEC_PER_SEC));
+
+ return 0;
+}
+
+static int ov9734_power_off(struct device *dev)
+{
+ struct v4l2_subdev *sd = dev_get_drvdata(dev);
+ struct ov9734 *ov9734 = to_ov9734(sd);
+
+ gpiod_set_value_cansleep(ov9734->reset, 1);
+
+ clk_disable_unprepare(ov9734->clk);
+
+ regulator_bulk_disable(ARRAY_SIZE(ov9734_supply_names),
+ ov9734->supplies);
+
+ return 0;
+}
+
static void ov9734_remove(struct i2c_client *client)
{
struct v4l2_subdev *sd = i2c_get_clientdata(client);
@@ -879,7 +962,10 @@ static void ov9734_remove(struct i2c_client *client)
media_entity_cleanup(&sd->entity);
v4l2_ctrl_handler_free(sd->ctrl_handler);
pm_runtime_disable(ov9734->dev);
- pm_runtime_set_suspended(ov9734->dev);
+ if (!pm_runtime_status_suspended(ov9734->dev)) {
+ ov9734_power_off(ov9734->dev);
+ pm_runtime_set_suspended(ov9734->dev);
+ }
mutex_destroy(&ov9734->mutex);
}
@@ -910,11 +996,20 @@ static int ov9734_probe(struct i2c_client *client)
"external clock %lu is not supported",
freq);
+ ret = ov9734_get_pm_resources(ov9734);
+ if (ret)
+ return ret;
+
v4l2_i2c_subdev_init(&ov9734->sd, client, &ov9734_subdev_ops);
+
+ ret = ov9734_power_on(ov9734->dev);
+ if (ret)
+ return ret;
+
ret = ov9734_identify_module(ov9734);
if (ret) {
dev_err(ov9734->dev, "failed to find sensor: %d", ret);
- return ret;
+ goto probe_error_power_off;
}
mutex_init(&ov9734->mutex);
@@ -936,13 +1031,8 @@ static int ov9734_probe(struct i2c_client *client)
goto probe_error_v4l2_ctrl_handler_free;
}
- /*
- * Device is already turned on by i2c-core with ACPI domain PM.
- * Enable runtime PM and turn off the device.
- */
pm_runtime_set_active(ov9734->dev);
pm_runtime_enable(ov9734->dev);
- pm_runtime_idle(ov9734->dev);
ret = v4l2_async_register_subdev_sensor(&ov9734->sd);
if (ret < 0) {
@@ -951,6 +1041,8 @@ static int ov9734_probe(struct i2c_client *client)
goto probe_error_media_entity_cleanup_pm;
}
+ pm_runtime_idle(ov9734->dev);
+
return 0;
probe_error_media_entity_cleanup_pm:
@@ -962,9 +1054,16 @@ static int ov9734_probe(struct i2c_client *client)
v4l2_ctrl_handler_free(ov9734->sd.ctrl_handler);
mutex_destroy(&ov9734->mutex);
+probe_error_power_off:
+ ov9734_power_off(ov9734->dev);
+
return ret;
}
+static const struct dev_pm_ops ov9734_pm_ops = {
+ RUNTIME_PM_OPS(ov9734_power_off, ov9734_power_on, NULL)
+};
+
static const struct acpi_device_id ov9734_acpi_ids[] = {
{ "OVTI9734", },
{}
@@ -975,6 +1074,7 @@ MODULE_DEVICE_TABLE(acpi, ov9734_acpi_ids);
static struct i2c_driver ov9734_i2c_driver = {
.driver = {
.name = "ov9734",
+ .pm = pm_ptr(&ov9734_pm_ops),
.acpi_match_table = ov9734_acpi_ids,
},
.probe = ov9734_probe,
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 3/3] media: ipu-bridge: Add OV9734 sensor config
2026-11-09 18:17 [PATCH v2 0/3] media: ov9734, ipu-bridge: Enable the camera on the Intel NUC M15 Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 1/3] media: i2c: ov9734: Return -EPROBE_DEFER if no endpoint is found Tin Posavec via B4 Relay
2026-11-09 18:17 ` [PATCH v2 2/3] media: i2c: ov9734: Add power on/off sequencing support Tin Posavec via B4 Relay
@ 2026-11-09 18:17 ` Tin Posavec via B4 Relay
2 siblings, 0 replies; 4+ messages in thread
From: Tin Posavec via B4 Relay @ 2026-11-09 18:17 UTC (permalink / raw)
To: Sakari Ailus, Bingbu Cao, Mauro Carvalho Chehab, Dan Scally,
Hans de Goede
Cc: linux-media, linux-kernel, Afonso Figuinha, Tin Posavec
From: Tin Posavec <tin.posavec04@gmail.com>
Add the Omnivision OV9734 (ACPI HID OVTI9734) to the
ipu_supported_sensors[] table, with a single link frequency of 180 MHz,
the only one supported by the ov9734 driver.
The sensor is the RGB camera of the Intel NUC M15 laptop (LAPRC710).
Without this entry ipu-bridge does not create a fwnode graph endpoint
for the sensor, and the camera is not enumerated.
Signed-off-by: Tin Posavec <tin.posavec04@gmail.com>
Tested-by: Afonso Figuinha <afonso.figuinha@gmail.com> # Surface Laptop 1 (IPU3)
---
drivers/media/pci/intel/ipu-bridge.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
index 3739c4a2a..4982b77de 100644
--- a/drivers/media/pci/intel/ipu-bridge.c
+++ b/drivers/media/pci/intel/ipu-bridge.c
@@ -120,6 +120,8 @@ static const struct ipu_sensor_config ipu_supported_sensors[] = {
IPU_SENSOR_CONFIG("OVTI5693", 1, 419200000),
/* Omnivision OV8856 */
IPU_SENSOR_CONFIG("OVTI8856", 3, 180000000, 360000000, 720000000),
+ /* Omnivision OV9734 */
+ IPU_SENSOR_CONFIG("OVTI9734", 1, 180000000),
/* Sony IMX471 */
IPU_SENSOR_CONFIG("SONY471A", 1, 200000000),
/* Sony IMX471 (found on Lenovo X1 Carbon G14) */
--
2.53.0
^ permalink raw reply [flat|nested] 4+ messages in thread