* [PATCH v1 1/1] ASoC: mediatek: mt8189: Use AVOUT for DP and HDMI jacks
2026-11-09 3:24 [PATCH v1 0/1] ASoC: mediatek: mt8189: Use AVOUT for DP and HDMI jacks Cyril Chao
@ 2026-11-09 3:24 ` Cyril Chao
0 siblings, 0 replies; 2+ messages in thread
From: Cyril Chao @ 2026-11-09 3:24 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, AngeloGioacchino Del Regno, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt
Cc: linux-sound, linux-kernel, linux-arm-kernel, linux-mediatek,
llvm, Cyril Chao, Project_Global_Chrome_Upstream_Group,
Cyril Chao
The HDMI codec reports DP and HDMI connection status as SND_JACK_AVOUT,
which combines SND_JACK_LINEOUT and SND_JACK_VIDEOOUT. The machine driver
creates these jacks with SND_JACK_LINEOUT, omitting the video-output
capability and its SW_VIDEOOUT_INSERT events when
CONFIG_SND_JACK_INPUT_DEV is enabled.
Use SND_JACK_AVOUT for both jack creation and pin masks to match the
codec's audio/video output reporting.
Fixes: d218ea171430 ("ASoC: mediatek: mt8189: add machine driver with nau8825")
Signed-off-by: Cyril Chao <Cyril.Chao@mediatek.com>
---
sound/soc/mediatek/mt8189/mt8189-nau8825.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/mediatek/mt8189/mt8189-nau8825.c b/sound/soc/mediatek/mt8189/mt8189-nau8825.c
index 5d652d0cf01e..b551477cef51 100644
--- a/sound/soc/mediatek/mt8189/mt8189-nau8825.c
+++ b/sound/soc/mediatek/mt8189/mt8189-nau8825.c
@@ -74,14 +74,14 @@ enum mt8189_jacks {
static struct snd_soc_jack_pin mt8189_dp_jack_pins[] = {
{
.pin = "DP",
- .mask = SND_JACK_LINEOUT,
+ .mask = SND_JACK_AVOUT,
},
};
static struct snd_soc_jack_pin mt8189_hdmi_jack_pins[] = {
{
.pin = "HDMI",
- .mask = SND_JACK_LINEOUT,
+ .mask = SND_JACK_AVOUT,
},
};
@@ -369,7 +369,7 @@ static int mt8189_dptx_codec_init(struct snd_soc_pcm_runtime *rtd)
struct snd_soc_component *component = snd_soc_rtd_to_codec(rtd, 0)->component;
int ret;
- ret = snd_soc_card_jack_new_pins(rtd->card, "DP Jack", SND_JACK_LINEOUT,
+ ret = snd_soc_card_jack_new_pins(rtd->card, "DP Jack", SND_JACK_AVOUT,
jack, mt8189_dp_jack_pins,
ARRAY_SIZE(mt8189_dp_jack_pins));
if (ret) {
@@ -394,7 +394,7 @@ static int mt8189_hdmi_codec_init(struct snd_soc_pcm_runtime *rtd)
struct snd_soc_component *component = snd_soc_rtd_to_codec(rtd, 0)->component;
int ret;
- ret = snd_soc_card_jack_new_pins(rtd->card, "HDMI Jack", SND_JACK_LINEOUT,
+ ret = snd_soc_card_jack_new_pins(rtd->card, "HDMI Jack", SND_JACK_AVOUT,
jack, mt8189_hdmi_jack_pins,
ARRAY_SIZE(mt8189_hdmi_jack_pins));
if (ret) {
base-commit: c937f492dd40a8398d955cf0f4f9e11d7268bcb5
--
2.45.2
^ permalink raw reply [flat|nested] 2+ messages in thread