[PATCH] staging: media: atomisp: Fix block comment formatting

[PATCH] staging: media: atomisp: Fix block comment formatting

[Lame Morupisi]

Align the multiline comment describing the MIPI frame memory
layout with the kernel coding style.

Move the opening comment delimiter to its own line and align
the subsequent lines consistently. This is a formatting-only
change and does not affect driver functionality.

Signed-off-by: Lame Morupisi <lamemorupisi12@gmail.com>
---
 .../staging/media/atomisp/pci/sh_css_mipi.c   | 31 ++++++++++---------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
index 971b685cd..57179298d 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
@@ -130,21 +130,22 @@ ia_css_mipi_frame_calculate_size(const unsigned int width,
 		even_line_bytes = odd_line_bytes;
 	}
 
-	/*  a frame represented in memory:  ()- optional; data - payload words.
-	*  addr		0	1	2	3	4	5	6	7:
-	*  first	SOF	(SOL)	PACK_H	data	data	data	data	data
-	*		data	data	data	data	data	data	data	data
-	*		...
-	*		data	data	0	0	0	0	0	0
-	*  second	(EOL)	(SOL)	PACK_H	data	data	data	data	data
-	*		data	data	data	data	data	data	data	data
-	*		...
-	*		data	data	0	0	0	0	0	0
-	*  ...
-	*  last		(EOL)	EOF	0	0	0	0	0	0
-	*
-	*  Embedded lines are regular lines stored before the first and after
-	*  payload lines.
+	/*
+	 * a frame represented in memory: () - optional; data - payload words.
+	 * addr         0       1       2       3       4       5       6       7:
+	 * first        SOF     (SOL)   PACK_H  data    data    data    data    data
+	 *              data    data    data    data    data    data    data    data
+	 *              ...
+	 *              data    data    0       0       0       0       0       0
+	 * second       (EOL)   (SOL)   PACK_H  data    data    data    data    data
+	 *              data    data    data    data    data    data    data    data
+	 *              ...
+	 *              data    data    0       0       0       0       0       0
+	 * ...
+	 * last         (EOL)   EOF     0       0       0       0       0       0
+	 *
+	 * Embedded lines are regular lines stored before the first and after
+	 * payload lines.
 	*/
 
 	words_per_odd_line = (odd_line_bytes + 3) >> 2;
-- 
2.56.0

[PATCH v2] staging: media: atomisp: Clarify MIPI frame layout comment

[Lame Morupisi]

Clarify the description of the MIPI frame memory layout by
explaining the meaning of optional fields and payload words.

Leave the frame layout diagram unchanged to preserve its
existing representation.

Signed-off-by: Lame Morupisi <lamemorupisi12@gmail.com>
---
 drivers/staging/media/atomisp/pci/sh_css_mipi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
index 971b685cd..09c2b1286 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
@@ -130,7 +130,8 @@ ia_css_mipi_frame_calculate_size(const unsigned int width,
 		even_line_bytes = odd_line_bytes;
 	}
 
-	/*  a frame represented in memory:  ()- optional; data - payload words.
+	/* Frame representation in memory: () denotes optional fields;
+	 * data denotes payload words.
 	*  addr		0	1	2	3	4	5	6	7:
 	*  first	SOF	(SOL)	PACK_H	data	data	data	data	data
 	*		data	data	data	data	data	data	data	data
-- 
2.56.0

Re: [PATCH v2] staging: media: atomisp: Clarify MIPI frame layout comment

[Dan Carpenter]

On Mon, Nov 09, 2026 at 06:12:23AM +0000, Lame Morupisi wrote:
> Clarify the description of the MIPI frame memory layout by
> explaining the meaning of optional fields and payload words.
> 
> Leave the frame layout diagram unchanged to preserve its
> existing representation.
> 
> Signed-off-by: Lame Morupisi <lamemorupisi12@gmail.com>
> ---

Why are you sending a v2?

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

The lines are not aligned now.

regards,
dan carpenter

Re: [PATCH v2] staging: media: atomisp: Clarify MIPI frame layout comment

[Andy Shevchenko]

On Mon, Nov 9, 2026 at 8:12 AM Lame Morupisi <lamemorupisi12@gmail.com> wrote:
>
> Clarify the description of the MIPI frame memory layout by
> explaining the meaning of optional fields and payload words.
>
> Leave the frame layout diagram unchanged to preserve its
> existing representation.

...

> -       /*  a frame represented in memory:  ()- optional; data - payload words.
> +       /* Frame representation in memory: () denotes optional fields;
> +        * data denotes payload words.

This uses the wrong multi-line comment style.

...

And as Dan said, you missed changelog to explain. (But in any case
neither v1 nor v2 is good to go.)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] staging: media: atomisp: Fix block comment formatting

[Andy Shevchenko]

On Sun, Nov 8, 2026 at 2:29 PM Lame Morupisi <lamemorupisi12@gmail.com> wrote:
>
> Align the multiline comment describing the MIPI frame memory
> layout with the kernel coding style.
>
> Move the opening comment delimiter to its own line and align
> the subsequent lines consistently. This is a formatting-only
> change and does not affect driver functionality.

It's most likely one of the very first patches to LKML by you. See my
comments below.

...

> +       /*
> +        * a frame represented in memory: () - optional; data - payload words.

While at it, make it consistent with the requirement for multi-line
comments, id est start the sentence with a capital letter.

> +        * addr         0       1       2       3       4       5       6       7:
> +        * first        SOF     (SOL)   PACK_H  data    data    data    data    data
> +        *              data    data    data    data    data    data    data    data
> +        *              ...
> +        *              data    data    0       0       0       0       0       0
> +        * second       (EOL)   (SOL)   PACK_H  data    data    data    data    data
> +        *              data    data    data    data    data    data    data    data
> +        *              ...
> +        *              data    data    0       0       0       0       0       0
> +        * ...
> +        * last         (EOL)   EOF     0       0       0       0       0       0
> +        *
> +        * Embedded lines are regular lines stored before the first and after
> +        * payload lines.
>         */


-- 
With Best Regards,
Andy Shevchenko