* [PATCH] nvmet: reject invalid write-protect feature values
@ 2026-11-09 13:55 Sreeraj S Kurup
2026-11-09 14:24 ` [PATCH v2] " Sreeraj S Kurup
0 siblings, 1 reply; 2+ messages in thread
From: Sreeraj S Kurup @ 2026-11-09 13:55 UTC (permalink / raw)
To: hch, sagi, kch, linux-nvme, linux-kernel
Cc: kbusch, hare, hare, Sreeraj S Kurup
The Set Features handler for namespace write protection currently
accepts unsupported values. The default case in the write-protect
switch leaves the status unchanged, causing the command to return
success even though no valid setting was applied.
Return NVME_SC_INVALID_FIELD | NVME_STATUS_DNR for unsupported
values. This also prevents issuing a namespace-change notification
for an invalid request.
Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
---
drivers/nvme/target/admin-cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index f12d83098644..ee8be237485e 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -1223,6 +1223,7 @@ static u16 nvmet_set_feat_write_protect(struct nvmet_req *req)
status = 0;
break;
default:
+ status = NVME_SC_INVALID_FIELD | NVME_STATUS_DNR;
break;
}
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH v2] nvmet: reject invalid write-protect feature values
2026-11-09 13:55 [PATCH] nvmet: reject invalid write-protect feature values Sreeraj S Kurup
@ 2026-11-09 14:24 ` Sreeraj S Kurup
0 siblings, 0 replies; 2+ messages in thread
From: Sreeraj S Kurup @ 2026-11-09 14:24 UTC (permalink / raw)
To: sreekuttan2156239
Cc: hare, hare, hch, kbusch, kch, linux-kernel, linux-nvme, sagi
The Set Features handler for namespace write protection currently
accepts unsupported values. The default case in the write-protect
switch leaves the status unchanged, causing the command to return
success even though no valid setting was applied.
Return NVME_SC_INVALID_FIELD | NVME_STATUS_DNR for unsupported
values. This also prevents issuing a namespace-change notification
for an invalid request.
Fixes: 3a1f7c79ae6d ("nvmet: make nvmet_find_namespace() req based")
Signed-off-by: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
---
v2:
- Add Fixes trailer
drivers/nvme/target/admin-cmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index f12d83098644..ee8be237485e 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -1223,6 +1223,7 @@ static u16 nvmet_set_feat_write_protect(struct nvmet_req *req)
status = 0;
break;
default:
+ status = NVME_SC_INVALID_FIELD | NVME_STATUS_DNR;
break;
}
--
2.55.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-09 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-09 13:55 [PATCH] nvmet: reject invalid write-protect feature values Sreeraj S Kurup
2026-11-09 14:24 ` [PATCH v2] " Sreeraj S Kurup
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®