From: "Paul E. McKenney" <paulmck@kernel.org>
To: rcu@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
rostedt@goodmis.org, Kunwu Chan <kunwu.chan@gmail.com>,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH 3/8] Documentation/litmus-tests: Add SRCU fastpath anchor-before-scan test
Date: Mon, 9 Nov 2026 14:19:34 -0800 [thread overview]
Message-ID: <20261109221939.2070171-3-paulmck@kernel.org> (raw)
In-Reply-To: <db8c185c-5523-48e5-abee-020503b4875f@paulmck-laptop>
From: Kunwu Chan <kunwu.chan@gmail.com>
synchronize_srcu_atomic() may end its grace period immediately when
its scan of the per-CPU lock counters finds no readers. Correctness
requires the grace-period anchor written by srcu_gp_start() to precede
the smp_mb() ordering the lock scan. This ordering ensures that any
reader whose lock increment is missed by the scan cannot have
incremented its lock counter before the grace-period anchor, and
therefore cannot be a pre-existing reader of this grace period.
This litmus test models the key ordering between the grace-period
anchor and the lock counter scan, where "seq" models the
grace-period anchor in ->srcu_gp_seq and "ctr" models the per-CPU
->srcu_ctrs[].srcu_locks counter. P0 writes the anchor before the
smp_mb() and the lock scan. P1 models the reader-side counter
increment. P2 models an observer that sees the reader's increment
before seeing the anchor.
The outcome is forbidden by LKMM, and herd7 reports "Never". See
SRCU-fastpath-scan-before-anchor.litmus for the reversed ordering,
which permits this outcome.
Tested with herd7 7.58 using linux-kernel.cfg.
Signed-off-by: Kunwu Chan <kunwu.chan@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
---
.../SRCU-fastpath-anchor-before-scan.litmus | 55 +++++++++++++++++++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/litmus-tests/srcu/SRCU-fastpath-anchor-before-scan.litmus
diff --git a/Documentation/litmus-tests/srcu/SRCU-fastpath-anchor-before-scan.litmus b/Documentation/litmus-tests/srcu/SRCU-fastpath-anchor-before-scan.litmus
new file mode 100644
index 0000000000000..8028f2ade733d
--- /dev/null
+++ b/Documentation/litmus-tests/srcu/SRCU-fastpath-anchor-before-scan.litmus
@@ -0,0 +1,55 @@
+C SRCU-fastpath-anchor-before-scan
+
+(*
+ * Result: Never
+ *
+ * The synchronize_srcu_atomic() fastpath may end its grace period
+ * immediately when its scan of the per-CPU lock counters finds no
+ * readers. Correctness requires the grace-period anchor written by
+ * srcu_gp_start() to precede the smp_mb() ordering the lock scan.
+ * This ordering ensures that any reader whose lock increment is missed
+ * by the scan cannot have incremented its lock counter before the
+ * grace-period anchor, and therefore cannot be a pre-existing reader
+ * of this grace period.
+ *
+ * This litmus test models the key ordering between the grace-period
+ * anchor and the lock counter scan, where "seq" models the
+ * grace-period anchor in ->srcu_gp_seq and "ctr" models the per-CPU
+ * ->srcu_ctrs[].srcu_locks counter. P0 writes the anchor before the
+ * smp_mb() and the lock scan. P1 models the reader-side counter
+ * increment. P2 models an observer that sees the reader's increment
+ * before seeing the anchor.
+ *
+ * The outcome is forbidden by LKMM, and herd7 reports "Never". See
+ * SRCU-fastpath-scan-before-anchor.litmus for the reversed ordering,
+ * which permits this outcome.
+ *)
+
+{}
+
+P0(int *seq, int *ctr)
+{
+ int r2;
+
+ WRITE_ONCE(*seq, 1);
+ smp_mb();
+ r2 = READ_ONCE(*ctr);
+}
+
+P1(int *ctr)
+{
+ WRITE_ONCE(*ctr, 1);
+}
+
+P2(int *seq, int *ctr)
+{
+ int r3;
+ int r4;
+
+ r3 = READ_ONCE(*ctr);
+ smp_mb();
+ r4 = READ_ONCE(*seq);
+}
+
+filter (0:r2 = 0)
+exists (2:r3 = 1 /\ 2:r4 = 0)
--
2.40.1
next prev parent reply other threads:[~2026-11-09 22:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 22:19 [PATCH 0/8] Miscellaneous RCU updates for v7.5 Paul E. McKenney
2026-11-09 22:19 ` [PATCH 1/8] rcutorture: Enable RCU_BOOST where supported Paul E. McKenney
2026-11-09 22:19 ` [PATCH 2/8] rcutorture: Disable RCU priority boost testing on non-TREE03 scenarios Paul E. McKenney
2026-11-09 22:19 ` Paul E. McKenney [this message]
2026-11-09 22:19 ` [PATCH 4/8] Documentation/litmus-tests: Add SRCU fastpath scan-before-anchor test Paul E. McKenney
2026-11-09 22:19 ` [PATCH 5/8] rcuscale: Add srcua scale type Paul E. McKenney
2026-11-09 22:19 ` [PATCH 6/8] rcuscale: Consolidate per-writer arrays into struct writer_state Paul E. McKenney
2026-11-09 22:19 ` [PATCH 7/8] rcu: Print CPU that preempted stalled reader wants to run on Paul E. McKenney
2026-11-09 22:19 ` [PATCH 8/8] doc: Document additional RCU task-stall dump information Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109221939.2070171-3-paulmck@kernel.org \
--to=paulmck@kernel.org \
--cc=kernel-team@meta.com \
--cc=kunwu.chan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®