mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomasz Unger <tomasz.unger@yahoo.pl>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Hans Verkuil <hverkuil+cisco@kernel.org>,
	linux-media@vger.kernel.org,  linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	 Tomasz Unger <tomasz.unger@yahoo.pl>
Subject: [PATCH] staging: media: av7110: remove commented-out code in av7110_hw.c
Date: Tue, 10 Nov 2026 00:16:20 +0100	[thread overview]
Message-ID: <20261110-av7110-hw-commented-dead-code-v1-1-3ef26d2673df@yahoo.pl> (raw)
In-Reply-To: <20261110-av7110-hw-commented-dead-code-v1-1-3ef26d2673df.ref@yahoo.pl>

Remove commented-out code from av7110_hw.c: two saa7146_setgpio()
calls and an ARM_ClearIrq() call in av7110_bootarm(), and three
dprintk() debug calls in __av7110_send_fw_cmd(), av7110_send_fw_cmd()
and av7110_fw_cmd().

All of these lines have been commented out since the beginning of git
history (Linux 2.6.12-rc2). They serve no purpose and only clutter the
source.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
 drivers/staging/media/av7110/av7110_hw.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/staging/media/av7110/av7110_hw.c b/drivers/staging/media/av7110/av7110_hw.c
index b0bd7666d48b..13ed214e6ef9 100644
--- a/drivers/staging/media/av7110/av7110_hw.c
+++ b/drivers/staging/media/av7110/av7110_hw.c
@@ -209,8 +209,6 @@ int av7110_bootarm(struct av7110 *av7110)
 	/* boot */
 	dprintk(1, "load boot code\n");
 	saa7146_setgpio(dev, ARM_IRQ_LINE, SAA7146_GPIO_IRQLO);
-	//saa7146_setgpio(dev, DEBI_DONE_LINE, SAA7146_GPIO_INPUT);
-	//saa7146_setgpio(dev, 3, SAA7146_GPIO_INPUT);
 
 	ret = request_firmware(&fw, fw_name, &dev->pci->dev);
 	if (ret) {
@@ -248,7 +246,6 @@ int av7110_bootarm(struct av7110 *av7110)
 	saa7146_setgpio(dev, RESET_LINE, SAA7146_GPIO_OUTHI);
 	msleep(30);	/* the firmware needs some time to initialize */
 
-	//ARM_ClearIrq(av7110);
 	ARM_ResetMailBox(av7110);
 	SAA7146_ISR_CLEAR(av7110->dev, MASK_19 | MASK_03);
 	SAA7146_IER_ENABLE(av7110->dev, MASK_03);
@@ -303,8 +300,6 @@ static int __av7110_send_fw_cmd(struct av7110 *av7110, u16 *buf, int length)
 	u32 stat;
 	int err;
 
-//	dprintk(4, "%p\n", av7110);
-
 	if (!av7110->arm_ready) {
 		dprintk(1, "arm not ready.\n");
 		return -ENXIO;
@@ -430,8 +425,6 @@ static int av7110_send_fw_cmd(struct av7110 *av7110, u16 *buf, int length)
 {
 	int ret;
 
-//	dprintk(4, "%p\n", av7110);
-
 	if (!av7110->arm_ready) {
 		dprintk(1, "arm not ready.\n");
 		return -1;
@@ -452,8 +445,6 @@ int av7110_fw_cmd(struct av7110 *av7110, int type, int com, int num, ...)
 	u16 buf[MAX_XFER_SIZE];
 	int i, ret;
 
-//	dprintk(4, "%p\n", av7110);
-
 	if (2 + num > ARRAY_SIZE(buf)) {
 		pr_warn("%s(): len=%d is too big!\n", __func__, num);
 		return -EINVAL;

---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261110-av7110-hw-commented-dead-code-c989b1086071

Best regards,
--  
Tomasz Unger <tomasz.unger@yahoo.pl>


           reply	other threads:[~2026-11-09 23:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20261110-av7110-hw-commented-dead-code-v1-1-3ef26d2673df.ref@yahoo.pl>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110-av7110-hw-commented-dead-code-v1-1-3ef26d2673df@yahoo.pl \
    --to=tomasz.unger@yahoo.pl \
    --cc=gregkh@linuxfoundation.org \
    --cc=hverkuil+cisco@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®