* [PATCH] staging: media: av7110: remove commented-out code in av7110_hw.c
[not found] <20261110-av7110-hw-commented-dead-code-v1-1-3ef26d2673df.ref@yahoo.pl>
@ 2026-11-09 23:16 ` Tomasz Unger
0 siblings, 0 replies; only message in thread
From: Tomasz Unger @ 2026-11-09 23:16 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Hans Verkuil, linux-media, linux-staging, linux-kernel, Tomasz Unger
Remove commented-out code from av7110_hw.c: two saa7146_setgpio()
calls and an ARM_ClearIrq() call in av7110_bootarm(), and three
dprintk() debug calls in __av7110_send_fw_cmd(), av7110_send_fw_cmd()
and av7110_fw_cmd().
All of these lines have been commented out since the beginning of git
history (Linux 2.6.12-rc2). They serve no purpose and only clutter the
source.
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
| 9 ---------
1 file changed, 9 deletions(-)
--git a/drivers/staging/media/av7110/av7110_hw.c b/drivers/staging/media/av7110/av7110_hw.c
index b0bd7666d48b..13ed214e6ef9 100644
--- a/drivers/staging/media/av7110/av7110_hw.c
+++ b/drivers/staging/media/av7110/av7110_hw.c
@@ -209,8 +209,6 @@ int av7110_bootarm(struct av7110 *av7110)
/* boot */
dprintk(1, "load boot code\n");
saa7146_setgpio(dev, ARM_IRQ_LINE, SAA7146_GPIO_IRQLO);
- //saa7146_setgpio(dev, DEBI_DONE_LINE, SAA7146_GPIO_INPUT);
- //saa7146_setgpio(dev, 3, SAA7146_GPIO_INPUT);
ret = request_firmware(&fw, fw_name, &dev->pci->dev);
if (ret) {
@@ -248,7 +246,6 @@ int av7110_bootarm(struct av7110 *av7110)
saa7146_setgpio(dev, RESET_LINE, SAA7146_GPIO_OUTHI);
msleep(30); /* the firmware needs some time to initialize */
- //ARM_ClearIrq(av7110);
ARM_ResetMailBox(av7110);
SAA7146_ISR_CLEAR(av7110->dev, MASK_19 | MASK_03);
SAA7146_IER_ENABLE(av7110->dev, MASK_03);
@@ -303,8 +300,6 @@ static int __av7110_send_fw_cmd(struct av7110 *av7110, u16 *buf, int length)
u32 stat;
int err;
-// dprintk(4, "%p\n", av7110);
-
if (!av7110->arm_ready) {
dprintk(1, "arm not ready.\n");
return -ENXIO;
@@ -430,8 +425,6 @@ static int av7110_send_fw_cmd(struct av7110 *av7110, u16 *buf, int length)
{
int ret;
-// dprintk(4, "%p\n", av7110);
-
if (!av7110->arm_ready) {
dprintk(1, "arm not ready.\n");
return -1;
@@ -452,8 +445,6 @@ int av7110_fw_cmd(struct av7110 *av7110, int type, int com, int num, ...)
u16 buf[MAX_XFER_SIZE];
int i, ret;
-// dprintk(4, "%p\n", av7110);
-
if (2 + num > ARRAY_SIZE(buf)) {
pr_warn("%s(): len=%d is too big!\n", __func__, num);
return -EINVAL;
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261110-av7110-hw-commented-dead-code-c989b1086071
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-09 23:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20261110-av7110-hw-commented-dead-code-v1-1-3ef26d2673df.ref@yahoo.pl>
2026-11-09 23:16 ` [PATCH] staging: media: av7110: remove commented-out code in av7110_hw.c Tomasz Unger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®