Re: [PATCH 2/5] dt-bindings: arm: stm32: Add clock-controller sub-node to STM32MP2 SYSCFG

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

On Tue, Nov 10, 2026 at 11:42:17AM +0100, Gabriel Fernandez wrote:
> The LTDC pixel clock multiplexer of the STM32MP23x and STM32MP25x
> SYSCFG is described by a clock-controller sub-node of the SYSCFG node.
> 
> Add this sub-node to the SYSCFG binding. It is required on STM32MP23x
> and STM32MP25x and not allowed on the other SoCs.
> 
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>

Why does this need a child node at all, can't the clock controller
properties go straight into this syscon node?

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> index a559f8b03b84..38c844e8f19d 100644
> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
> @@ -45,6 +45,10 @@ properties:
>    "#size-cells":
>      const: 1
>  
> +  clock-controller:
> +    type: object
> +    $ref: /schemas/clock/st,stm32mp25-syscfg-clk.yaml#
> +
>  patternProperties:
>    "^phy@2[48]00$":
>      type: object
> @@ -80,6 +84,7 @@ allOf:
>          - "#address-cells"
>          - "#clock-cells"
>          - "#size-cells"
> +        - clock-controller
>          - phy@2400
>          - phy@2800
>      else:
> @@ -87,6 +92,7 @@ allOf:
>          '#address-cells': false
>          '#clock-cells': false
>          '#size-cells': false
> +        clock-controller: false
>          phy@2400: false
>          phy@2800: false
>  
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]