mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
	 Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	 Russell King <linux@armlinux.org.uk>,
	Michal Simek <michal.simek@amd.com>,
	 Eric Dumazet <edumazet@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 3/5] dt-bindings: net: dp83867: make exclusivity explicit
Date: Tue, 10 Nov 2026 11:29:26 +0100	[thread overview]
Message-ID: <20261110-ecstatic-affable-mackerel-db9cb7@quoll> (raw)
In-Reply-To: <20261106-v7-2-topic-dp83867-v3-3-45e1d3adf1bf@pengutronix.de>

On Fri, Nov 06, 2026 at 08:47:27AM +0100, Steffen Trumtrar wrote:
> The io_impedance_ctrl nvmem cell and the properties
> ti,{min,max}-output-impedance are mutually exclusive, as noted in the
> ti,max-output-impedance description.

But it also said it is allowed and one will be chosen over other, if
both present.

> 
> As this is only stated in the description and not made explicit in the
> schema, the binding checker will not catch if this condition is ignored.
> 
> Make it explicit in the schema that only one of them can be used. With
> that, drop the note, which also described a precedence for device trees
> that the schema now rejects.
> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/net/ti,dp83867.yaml | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> index 2cd8311ece5e..833540743bdf 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> @@ -7,9 +7,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: TI DP83867 ethernet PHY
>  
> -allOf:
> -  - $ref: ethernet-phy.yaml#

You just added it, so instead place it at the end in previous patch.

Best regards,
Krzysztof


  reply	other threads:[~2026-11-10 10:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  7:47 [PATCH net-next v3 0/5] net: dp83867: add new output-impedance DT binding Steffen Trumtrar
2026-11-06  7:47 ` [PATCH net-next v3 1/5] arm64: dts: xilinx: drop unused #phy-cells from the DP83867 nodes Steffen Trumtrar
2026-11-06  9:09   ` Michal Simek
2026-11-06  7:47 ` [PATCH net-next v3 2/5] dt-bindings: net: dp83867: add compatible and reference ethernet-phy.yaml Steffen Trumtrar
2026-11-10 10:23   ` Krzysztof Kozlowski
2026-11-06  7:47 ` [PATCH net-next v3 3/5] dt-bindings: net: dp83867: make exclusivity explicit Steffen Trumtrar
2026-11-10 10:29   ` Krzysztof Kozlowski [this message]
2026-11-10 13:08   ` Andrew Lunn
2026-11-06  7:47 ` [PATCH net-next v3 4/5] dt-bindings: net: dp83867: Add ti,output-impedance-ohms Steffen Trumtrar
2026-11-10 10:30   ` Krzysztof Kozlowski
2026-11-06  7:47 ` [PATCH net-next v3 5/5] net: phy: dp83867: support setting output-impedance Steffen Trumtrar
2026-11-10 13:12   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110-ecstatic-affable-mackerel-db9cb7@quoll \
    --to=krzk@kernel.org \
    --cc=afd@ti.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michal.simek@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®