From: Andrew Lunn <andrew@lunn.ch>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Michal Simek <michal.simek@amd.com>,
Eric Dumazet <edumazet@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 5/5] net: phy: dp83867: support setting output-impedance
Date: Tue, 10 Nov 2026 14:12:22 +0100 [thread overview]
Message-ID: <ab3b042d-dded-4349-b9c0-7b2678274275@lunn.ch> (raw)
In-Reply-To: <20261106-v7-2-topic-dp83867-v3-5-45e1d3adf1bf@pengutronix.de>
On Fri, Nov 06, 2026 at 08:47:29AM +0100, Steffen Trumtrar wrote:
> Currently the dp83867 supports setting the io impedance to minimum,
> maximum, default or a value from a nvmem cell. In situations where there
> is no backend for a nvmem cell, the value can not be set to anything but
> minimum, maximum or default.
>
> Add support for the ti,output-impedance-ohms binding, allowing to
> specify the impedance in ohms via the devicetree. The PHY has 32
> settings between 35 and 70 ohms. The datasheet does not specify the
> impedance of each setting, so the value is mapped linearly to the
> nearest one.
>
> With this mapping, 50 ohms results in 0x12. For non-OF devices, the
> driver sets 0x0f (IO_IMPEDANCE_MIN / 2) as the 50 ohm default "per
> datasheet", which would be 53 ohms with the linear mapping. As the
> datasheet only gives the range, neither value can be checked against it.
>
> The binding does not allow combining the new property with the nvmem
> cell or the boolean properties. The driver still reads the nvmem cell
> first, then ti,max-output-impedance, ti,min-output-impedance and
> ti,output-impedance-ohms.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2026-11-10 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 7:47 [PATCH net-next v3 0/5] net: dp83867: add new output-impedance DT binding Steffen Trumtrar
2026-11-06 7:47 ` [PATCH net-next v3 1/5] arm64: dts: xilinx: drop unused #phy-cells from the DP83867 nodes Steffen Trumtrar
2026-11-06 9:09 ` Michal Simek
2026-11-06 7:47 ` [PATCH net-next v3 2/5] dt-bindings: net: dp83867: add compatible and reference ethernet-phy.yaml Steffen Trumtrar
2026-11-10 10:23 ` Krzysztof Kozlowski
2026-11-06 7:47 ` [PATCH net-next v3 3/5] dt-bindings: net: dp83867: make exclusivity explicit Steffen Trumtrar
2026-11-10 10:29 ` Krzysztof Kozlowski
2026-11-10 13:08 ` Andrew Lunn
2026-11-06 7:47 ` [PATCH net-next v3 4/5] dt-bindings: net: dp83867: Add ti,output-impedance-ohms Steffen Trumtrar
2026-11-10 10:30 ` Krzysztof Kozlowski
2026-11-06 7:47 ` [PATCH net-next v3 5/5] net: phy: dp83867: support setting output-impedance Steffen Trumtrar
2026-11-10 13:12 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab3b042d-dded-4349-b9c0-7b2678274275@lunn.ch \
--to=andrew@lunn.ch \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®