* [PATCH v2] gpio: shared: fix a race in shared desc release path
@ 2026-11-10 10:10 Bartosz Golaszewski
2026-11-10 21:42 ` Linus Walleij
2026-11-12 8:32 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-10 10:10 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, stable, Bartosz Golaszewski
gpiod_shared_put() races with concurrent calls to
devm_gpiod_shared_get() like so:
CPU 0 (unbind / probe failure) CPU 1 (concurrent proxy probe)
============================== ==============================
gpiod_shared_put()
kref_put(&entry->ref, ...)
refcount_dec_and_test() // -> 0
devm_gpiod_shared_get()
mutex_lock(&entry->lock);
if (entry->shared_desc) {
kref_get(&entry->ref); // on 0!
shared_desc = entry->shared_desc;
}
mutex_unlock(&entry->lock);
gpio_shared_release()
mutex_lock(&entry->lock);
kfree(shared_desc);
entry->shared_desc = NULL;
mutex_unlock(&entry->lock);
// uses freed shared_desc
Because gpiod_shared_put() decrements entry->ref without holding
entry->lock and gpio_shared_release() only acquires entry->lock after the
reference count has already reached zero, a concurrent call to
devm_gpiod_shared_get() can acquire entry->lock in the intermediate window
and observe a non-NULL entry->shared_desc. This can result in a
use-after-free and a double-free when the second consumer releases its
reference.
Use kref_put_mutex() to ensure the entry lock is taken without a window
in which a concurrent user can see a non-NULL entry->shared_desc while
it's being released.
Cc: stable@vger.kernel.org
Closes: https://sashiko.dev/#/bug/linux-30e071e4-4e4a-4b63-bd83-df1147055d35
Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
Changes in v2:
- manually release the mutex acquired by kref_put_mutex() (sashiko)
- Link to v1: https://patch.msgid.link/20261106-gpio-shared-refcnt-race-v1-1-79c9167505ab@oss.qualcomm.com
---
drivers/gpio/gpiolib-shared.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c
index 8c9ac9d9330490b17fb3936b8758beb97a308a15..edb04a5bb987e12faf96e5b70198a9fabf60ad0a 100644
--- a/drivers/gpio/gpiolib-shared.c
+++ b/drivers/gpio/gpiolib-shared.c
@@ -635,20 +635,20 @@ static void gpio_shared_release(struct kref *kref)
container_of(kref, struct gpio_shared_entry, ref);
struct gpio_shared_desc *shared_desc;
- guard(mutex)(&entry->lock);
-
shared_desc = entry->shared_desc;
gpio_device_put(shared_desc->desc->gdev);
mutex_destroy(&shared_desc->mutex);
kfree(shared_desc);
entry->shared_desc = NULL;
+
+ mutex_unlock(&entry->lock);
}
static void gpiod_shared_put(void *data)
{
struct gpio_shared_entry *entry = data;
- kref_put(&entry->ref, gpio_shared_release);
+ kref_put_mutex(&entry->ref, gpio_shared_release, &entry->lock);
}
static struct gpio_shared_desc *
---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
change-id: 20261106-gpio-shared-refcnt-race-2b1eddecadbd
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] gpio: shared: fix a race in shared desc release path
2026-11-10 10:10 [PATCH v2] gpio: shared: fix a race in shared desc release path Bartosz Golaszewski
@ 2026-11-10 21:42 ` Linus Walleij
2026-11-12 8:32 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2026-11-10 21:42 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, stable
On Tue, Nov 10, 2026 at 11:10 AM Bartosz Golaszewski
<bartosz.golaszewski@oss.qualcomm.com> wrote:
> gpiod_shared_put() races with concurrent calls to
> devm_gpiod_shared_get() like so:
>
> CPU 0 (unbind / probe failure) CPU 1 (concurrent proxy probe)
> ============================== ==============================
> gpiod_shared_put()
> kref_put(&entry->ref, ...)
> refcount_dec_and_test() // -> 0
> devm_gpiod_shared_get()
> mutex_lock(&entry->lock);
> if (entry->shared_desc) {
> kref_get(&entry->ref); // on 0!
> shared_desc = entry->shared_desc;
> }
> mutex_unlock(&entry->lock);
> gpio_shared_release()
> mutex_lock(&entry->lock);
> kfree(shared_desc);
> entry->shared_desc = NULL;
> mutex_unlock(&entry->lock);
> // uses freed shared_desc
>
> Because gpiod_shared_put() decrements entry->ref without holding
> entry->lock and gpio_shared_release() only acquires entry->lock after the
> reference count has already reached zero, a concurrent call to
> devm_gpiod_shared_get() can acquire entry->lock in the intermediate window
> and observe a non-NULL entry->shared_desc. This can result in a
> use-after-free and a double-free when the second consumer releases its
> reference.
>
> Use kref_put_mutex() to ensure the entry lock is taken without a window
> in which a concurrent user can see a non-NULL entry->shared_desc while
> it's being released.
>
> Cc: stable@vger.kernel.org
> Closes: https://sashiko.dev/#/bug/linux-30e071e4-4e4a-4b63-bd83-df1147055d35
> Fixes: a060b8c511ab ("gpiolib: implement low-level, shared GPIO support")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Good find!
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] gpio: shared: fix a race in shared desc release path
2026-11-10 10:10 [PATCH v2] gpio: shared: fix a race in shared desc release path Bartosz Golaszewski
2026-11-10 21:42 ` Linus Walleij
@ 2026-11-12 8:32 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-11-12 8:32 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, stable
On Tue, 10 Nov 2026 11:10:40 +0100, Bartosz Golaszewski wrote:
> gpiod_shared_put() races with concurrent calls to
> devm_gpiod_shared_get() like so:
>
> CPU 0 (unbind / probe failure) CPU 1 (concurrent proxy probe)
> ============================== ==============================
> gpiod_shared_put()
> kref_put(&entry->ref, ...)
> refcount_dec_and_test() // -> 0
> devm_gpiod_shared_get()
> mutex_lock(&entry->lock);
> if (entry->shared_desc) {
> kref_get(&entry->ref); // on 0!
> shared_desc = entry->shared_desc;
> }
> mutex_unlock(&entry->lock);
> gpio_shared_release()
> mutex_lock(&entry->lock);
> kfree(shared_desc);
> entry->shared_desc = NULL;
> mutex_unlock(&entry->lock);
> // uses freed shared_desc
>
> [...]
Applied, thanks!
[1/1] gpio: shared: fix a race in shared desc release path
https://git.kernel.org/brgl/c/53043b9e83cc7f4e30e70161b67ae93c4c9fdb87
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-12 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-10 10:10 [PATCH v2] gpio: shared: fix a race in shared desc release path Bartosz Golaszewski
2026-11-10 21:42 ` Linus Walleij
2026-11-12 8:32 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®