Re: [PATCH 4/8] media: i2c: Add Samsung S5K3M3 image sensor driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On Mon, Nov 09, 2026 at 10:38:22PM +0000, Gaurav Suman wrote:
> +	s->regmap = devm_cci_regmap_init_i2c(client, 16);
> +	if (IS_ERR(s->regmap))
> +		return PTR_ERR(s->regmap);
> +	s->mclk = devm_clk_get(dev, NULL);
> +	if (IS_ERR(s->mclk))
> +		return dev_err_probe(dev, PTR_ERR(s->mclk), "no clock\n");
> +	ret = clk_set_rate(s->mclk, S5K3M3_MCLK);
> +	if (ret)
> +		return ret;
> +	s->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> +	if (IS_ERR(s->reset))
> +		return dev_err_probe(dev, PTR_ERR(s->reset), "no reset gpio\n");
> +	for (i = 0; i < ARRAY_SIZE(s5k3m3_supplies); i++)
> +		s->supplies[i].supply = s5k3m3_supplies[i];
> +	ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(s->supplies), s->supplies);
> +	if (ret)
> +		return ret;
> +
> +	ret = s5k3m3_check_hw(s);
> +	if (ret) {
> +		if (ret != -EPROBE_DEFER)
> +			s5k3m3_power_off(dev);
> +		return ret;
> +	}
> +
> +	ret = s5k3m3_init_ctrls(s);
> +	if (ret)
> +		goto err_power;
> +	s->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> +	s->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;
> +	s->pad.flags = MEDIA_PAD_FL_SOURCE;
> +	ret = media_entity_pads_init(&s->sd.entity, 1, &s->pad);
> +	if (ret)
> +		goto err_ctrls;
> +	s->sd.state_lock = s->ctrls.lock;
> +	ret = v4l2_subdev_init_finalize(&s->sd);
> +	if (ret)
> +		goto err_entity;
> +
> +	pm_runtime_set_active(dev);
> +	pm_runtime_enable(dev);
> +	ret = v4l2_async_register_subdev_sensor(&s->sd);
> +	if (ret)
> +		goto err_pm;
> +	pm_runtime_idle(dev);
> +	return 0;

This is hardly readable code. I don't get how Claude could even generate
that... but if did, then you use poor tools thus your work can be
ignored.

Just open any existing recent driver and compare. Sending code which is
completely different than our coding style - visible with naked eye -
proves that you just sent us slop.

Best regards,
Krzysztof