mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Brian Masney <masneyb@kernel.org>
Cc: Long Zhao <longzhao@ambarella.com>, Arnd Bergmann <arnd@arndb.de>,
	 Alexandre Belloni <alexandre.belloni@bootlin.com>,
	soc@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	 Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	 Jerome Brunet <jbrunet@baylibre.com>,
	linux-clk@vger.kernel.org,
	 Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	 Will Deacon <will@kernel.org>,
	devicetree@vger.kernel.org, Long Zhao <zl020895@163.com>,
	 linux-kernel@vger.kernel.org, Linus Walleij <linusw@kernel.org>
Subject: Re: [PATCH v11 0/5] arm64: add Ambarella CV75 SoC support
Date: Tue, 10 Nov 2026 09:02:35 +0100	[thread overview]
Message-ID: <20261110-interesting-hilarious-shark-2dbfc0@quoll> (raw)
In-Reply-To: <179427375370.1061670.4050288038934218487.b4-review@b4>

On Mon, Nov 09, 2026 at 08:22:33PM -0500, Brian Masney wrote:
> Hi Long / Krzysztof / Conor / Rob,
> 
> > Add the Ambarella CV75 SoC and EVK support: the board binding, the
> > RCT clock binding and driver, ARCH_AMBARELLA, the devicetree and
> > MAINTAINERS.
> > 
> > The clock ID header is added before the devicetree that includes it,
> > so patch 2 (the clock binding) has to be applied before patch 4 (the
> > devicetree).
> > 
> > The ambarella vendor prefix and the CV75 secure scratchpad syscon
> > binding are already in linux-next. This series does not repeat
> > either of them.
> > 
> > GPIO, UART and pinctrl bindings and drivers are separate series.
> > This devicetree references those compatibles.
> > 
> > Tested on the CV75 EVK. The board boots. That boot used a local tree
> > that also includes the GPIO, UART and pinctrl patches.
> > 
> > To: Arnd Bergmann <arnd@arndb.de>
> > To: Krzysztof Kozlowski <krzk@kernel.org>
> > To: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > To: soc@lists.linux.dev
> > To: linux-arm-kernel@lists.infradead.org
> > To: Michael Turquette <mturquette@baylibre.com>
> > To: Stephen Boyd <sboyd@kernel.org>
> > Cc: Jerome Brunet <jbrunet@baylibre.com>
> > Cc: linux-clk@vger.kernel.org
> > Cc: Brian Masney <masneyb@kernel.org>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Cc: Long Zhao <longzhao@ambarella.com>
> > Cc: Long Zhao <zl020895@163.com>
> > Cc: linux-kernel@vger.kernel.org
> > 
> > Signed-off-by: Long Zhao <longzhao@ambarella.com>
> > ---
> > Changes in v11:
> > - clk: use builtin_platform_driver(). The Kconfig symbol is bool. (Brian)
> > - clk: drop CLK_IS_CRITICAL from the core PLL. It has no enable op. (Brian)
> > - clk: drop the misleading (u64) cast in the div_u64() call. (Brian)
> > - clk: add .suppress_bind_attrs = true to block sysfs unbind. (Brian)
> > - clk: drop MODULE_AUTHOR. (Brian)
> > - Link to v10:
> >   https://patch.msgid.link/20261019-cv75-soc-v10-0-d386065e2dd5@ambarella.com
> > 
> > ---
> > Long Zhao (5):
> >       dt-bindings: arm: add Ambarella CV75 platforms
> >       dt-bindings: clock: add Ambarella CV75 RCT
> >       clk: ambarella: add CV75 RCT clock controller
> >       arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT
> >       MAINTAINERS: add ARM/AMBARELLA SoC support
> 
> The clk changes look good to me.
> 
> Before I start to merge things, and since I'm a new maintainer here, I
> just want to make sure that I am doing this correctly, and have the
> expected merge strategy for everyone involved.
> 
> - I create a new shared immutable branch based on v7.4-rc1 and I can put
>   the first two dt-bindings patches in that. I merge this into clk-pile
>   (feeds clk-next) with --no-ff. The DTS folks will merge this immutable
>   branch as well.
> 
> - I can then merge patches 3 and 5 into clk-pile.

You will have code depending on non-exisitng ARCH_AMBARELLA symbol, but
if that's fine for you then sure.

> 
> - The DTS folks will take patch 4.

The entire platform is for SoC tree. This sounds ok for me, but I am not
sure if Arnd was merging pulls with dependencies. If not, then worse
case the arm64 bits will wait a cycle. Anyway, I guess you can take
clock bits.

Best regards,
Krzysztof


  reply	other threads:[~2026-11-10  8:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 11:06 Long Zhao via B4 Relay
2026-11-05 11:06 ` [PATCH v11 1/5] dt-bindings: arm: add Ambarella CV75 platforms Long Zhao via B4 Relay
2026-11-05 11:06 ` [PATCH v11 2/5] dt-bindings: clock: add Ambarella CV75 RCT Long Zhao via B4 Relay
2026-11-05 11:06 ` [PATCH v11 3/5] clk: ambarella: add CV75 RCT clock controller Long Zhao via B4 Relay
2026-11-05 11:06 ` [PATCH v11 4/5] arm64: ambarella: add ARCH_AMBARELLA and CV75 EVK DT Long Zhao via B4 Relay
2026-11-05 11:06 ` [PATCH v11 5/5] MAINTAINERS: add ARM/AMBARELLA SoC support Long Zhao via B4 Relay
2026-11-10  1:22 ` [PATCH v11 0/5] arm64: add Ambarella CV75 " Brian Masney
2026-11-10  8:02   ` Krzysztof Kozlowski [this message]
2026-11-10  8:23     ` Arnd Bergmann
2026-11-10  8:27       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110-interesting-hilarious-shark-2dbfc0@quoll \
    --to=krzk@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longzhao@ambarella.com \
    --cc=masneyb@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=soc@lists.linux.dev \
    --cc=will@kernel.org \
    --cc=zl020895@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®