[PATCH v3] staging: octeon: remove unnecessary parentheses

[PATCH v3] staging: octeon: remove unnecessary parentheses

[Oscar Alejandro Sánchez Lucero via B4 Relay]

From: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>

Fix checkpatch.pl warnings by removing redundant parentheses around
conditional checks.

Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
---
Hi Greg,

This patch fixes checkpatch.pl warnings in ethernet.c by removing
unnecessary parentheses.

The v2 text was AI-generated because I don't speak English well
and I tryng to learn b4 workflow.
I try being concise in this v3. Sorry for the noise.
---
Changes in v3:
- Rewrote the cover letter and commit message manually.
- Removed the AI-generated text.
---
 drivers/staging/octeon/ethernet.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 42ec4b8324a8..f374fdf8f7a9 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -262,9 +262,9 @@ static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu)
 
 	dev->mtu = new_mtu;
 
-	if ((interface < 2) &&
-	    (cvmx_helper_interface_get_mode(interface) !=
-		CVMX_HELPER_INTERFACE_MODE_SPI)) {
+	if (interface < 2 &&
+	    cvmx_helper_interface_get_mode(interface) !=
+		CVMX_HELPER_INTERFACE_MODE_SPI) {
 		int index = INDEX(priv->port);
 		/* Add ethernet header and FCS, and VLAN if configured. */
 		int max_packet = new_mtu + mtu_overhead;
@@ -308,9 +308,9 @@ static void cvm_oct_common_set_multicast_list(struct net_device *dev)
 	struct octeon_ethernet *priv = netdev_priv(dev);
 	int interface = INTERFACE(priv->port);
 
-	if ((interface < 2) &&
-	    (cvmx_helper_interface_get_mode(interface) !=
-		CVMX_HELPER_INTERFACE_MODE_SPI)) {
+	if (interface < 2 &&
+	    cvmx_helper_interface_get_mode(interface) !=
+		CVMX_HELPER_INTERFACE_MODE_SPI) {
 		union cvmx_gmxx_rxx_adr_ctl control;
 		int index = INDEX(priv->port);
 
@@ -360,9 +360,9 @@ static int cvm_oct_set_mac_filter(struct net_device *dev)
 	union cvmx_gmxx_prtx_cfg gmx_cfg;
 	int interface = INTERFACE(priv->port);
 
-	if ((interface < 2) &&
-	    (cvmx_helper_interface_get_mode(interface) !=
-		CVMX_HELPER_INTERFACE_MODE_SPI)) {
+	if (interface < 2 &&
+	    cvmx_helper_interface_get_mode(interface) !=
+		CVMX_HELPER_INTERFACE_MODE_SPI) {
 		int i;
 		const u8 *ptr = dev->dev_addr;
 		u64 mac = 0;

---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
change-id: 20261108-octeon-parentheses-cleanup-v1-c1f3335a411e

Best regards,
-- 
Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>

Re: [PATCH v3] staging: octeon: remove unnecessary parentheses

[Dan Carpenter]

On Tue, Nov 10, 2026 at 03:37:24AM -0600, Oscar Alejandro Sánchez Lucero via B4 Relay wrote:
> From: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
> 
> Fix checkpatch.pl warnings by removing redundant parentheses around
> conditional checks.
> 
> Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
> ---

Search for this on lore.

https://lore.kernel.org/all/?q=cvm_oct_common_change_mtu

I don't even know how you are seeing these warnings because I
changed checkpatch to not warn about it.

dcarpenter@stanley:~/progs/kernel/devel$ ./scripts/checkpatch.pl -f --strict drivers/staging/octeon/ethernet.c
total: 0 errors, 0 warnings, 0 checks, 1037 lines checked

drivers/staging/octeon/ethernet.c has no obvious style problems and is ready for submission.

regards,
dan carpenter

Re: [PATCH v3] staging: octeon: remove unnecessary parentheses

[Alejandro Lucero]

Hi Dan,

You are right. I ran it again with --strict and
got 0 checks.

I was analyzing the file based on the previous automated revisions
I sent, which tried to clean up things that checkpatch don't
complain about.

Thanks for the clarification, and sorry for sending unnecessary
noise T-T

Regards,
Alejandro Lucero

El mar, 10 nov 2026 a la(s) 6:19 a.m., Dan Carpenter (dan@cryspen.com) escribió:
>
> On Tue, Nov 10, 2026 at 03:37:24AM -0600, Oscar Alejandro Sánchez Lucero via B4 Relay wrote:
> > From: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
> >
> > Fix checkpatch.pl warnings by removing redundant parentheses around
> > conditional checks.
> >
> > Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
> > ---
>
> Search for this on lore.
>
> https://lore.kernel.org/all/?q=cvm_oct_common_change_mtu
>
> I don't even know how you are seeing these warnings because I
> changed checkpatch to not warn about it.
>
> dcarpenter@stanley:~/progs/kernel/devel$ ./scripts/checkpatch.pl -f --strict drivers/staging/octeon/ethernet.c
> total: 0 errors, 0 warnings, 0 checks, 1037 lines checked
>
> drivers/staging/octeon/ethernet.c has no obvious style problems and is ready for submission.
>
> regards,
> dan carpenter
>
>
>