From: Damon Ding <damon.ding@rock-chips.com>
To: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Dave Jones <s.dave.jones@gmail.com>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: [PATCH v5 1/3] dt-bindings: phy: Add rockchip,rk3568-edp-phy
Date: Tue, 10 Nov 2026 15:45:31 +0800 [thread overview]
Message-ID: <20261110074533.4052196-2-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20261110074533.4052196-1-damon.ding@rock-chips.com>
Document the eDP transmitter PHY with Naneng IP block found on the
RK3568 SoC. The PHY has its own register window inside the eDP PHY GRF,
so its node is modeled as a child of the eDP PHY GRF syscon with a reg
property describing that window.
Also add the "rockchip,rk3568-edp-phy-grf" compatible with its own
binding schema, so the shared Rockchip GRF schema is not extended with
per-device conditionals.
Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
---
Changes in v4:
- Add the reg entry for the PHY node and the ranges/#address-cells/
#size-cells for the parent syscon node.
Changes in v5:
- Move the APB clock (PCLK_EDPPHY_GRF) from the parent syscon node to
the PHY node, matching the updated driver.
- Split the "rockchip,rk3568-edp-phy-grf" syscon node to its own
binding schema, instead of extending the shared Rockchip GRF schema.
- Rename the reference clock to "ref".
- Drop the example from the PHY binding schema, as complete MFD
examples belong in the GRF binding schema.
---
.../bindings/phy/rockchip,rk3568-edp-phy.yaml | 46 +++++++++++
.../rockchip/rockchip,rk3568-edp-phy-grf.yaml | 80 +++++++++++++++++++
2 files changed, 126 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml
create mode 100644 Documentation/devicetree/bindings/soc/rockchip/rockchip,rk3568-edp-phy-grf.yaml
diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml
new file mode 100644
index 000000000000..06dd1d19dca2
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/rockchip,rk3568-edp-phy.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/rockchip,rk3568-edp-phy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip eDP Transmitter PHY with Naneng IP block
+
+maintainers:
+ - Damon Ding <damon.ding@rock-chips.com>
+ - Heiko Stuebner <heiko@sntech.de>
+
+description:
+ On the RK3568 SoC the eDP PHY is controlled through the eDP PHY GRF
+ registers, therefore the PHY node is expected to be a child of the
+ eDP PHY GRF syscon node.
+
+properties:
+ compatible:
+ const: rockchip,rk3568-edp-phy
+
+ reg:
+ maxItems: 1
+ description: PHY registers within the eDP PHY GRF.
+
+ clocks:
+ items:
+ - description: Reference clock from the PMU CRU
+ - description: APB clock gating the PHY register window
+
+ clock-names:
+ items:
+ - const: ref
+ - const: apb
+
+ "#phy-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - "#phy-cells"
+
+additionalProperties: false
diff --git a/Documentation/devicetree/bindings/soc/rockchip/rockchip,rk3568-edp-phy-grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/rockchip,rk3568-edp-phy-grf.yaml
new file mode 100644
index 000000000000..852420798f06
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/rockchip/rockchip,rk3568-edp-phy-grf.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/rockchip/rockchip,rk3568-edp-phy-grf.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip eDP PHY GRF on the RK3568 SoC
+
+maintainers:
+ - Damon Ding <damon.ding@rock-chips.com>
+ - Heiko Stuebner <heiko@sntech.de>
+
+description:
+ The eDP PHY GRF is a dedicated register file on the RK3568 SoC,
+ holding the registers used by the eDP Transmitter PHY with Naneng IP
+ block. The PHY itself is modeled as a child node, with its reg
+ property describing the PHY register window inside the GRF.
+
+properties:
+ compatible:
+ items:
+ - const: rockchip,rk3568-edp-phy-grf
+ - const: syscon
+ - const: simple-mfd
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges: true
+
+patternProperties:
+ "^phy@[0-9a-f]+$":
+ type: object
+ $ref: /schemas/phy/rockchip,rk3568-edp-phy.yaml#
+ unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/rk3568-cru.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ edp_phy_grf: syscon@fdcb0000 {
+ compatible = "rockchip,rk3568-edp-phy-grf", "syscon", "simple-mfd";
+ reg = <0x0 0xfdcb0000 0x0 0x8000>;
+ clocks = <&cru PCLK_EDPPHY_GRF>;
+ ranges = <0x0 0x0 0xfdcb0000 0x100>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ edp_phy: phy@0 {
+ compatible = "rockchip,rk3568-edp-phy";
+ reg = <0x0 0x100>;
+ clocks = <&pmucru XIN_OSC0_EDPPHY_G>, <&cru PCLK_EDPPHY_GRF>;
+ clock-names = "ref", "apb";
+ #phy-cells = <0>;
+ };
+ };
+ };
--
2.34.1
next prev parent reply other threads:[~2026-11-10 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 7:45 [PATCH v5 0/3] Add eDP support for RK3568 Damon Ding
2026-11-10 7:45 ` Damon Ding [this message]
2026-11-10 7:45 ` [PATCH v5 2/3] phy: rockchip: Add support for Naneng eDP phy Damon Ding
2026-11-10 7:45 ` [PATCH v5 3/3] arm64: dts: rockchip: rk356x: Add eDP controller and phy nodes Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110074533.4052196-2-damon.ding@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=s.dave.jones@gmail.com \
--cc=sebastian.reichel@collabora.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®