mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Shunbo Shi <shishunbo@cmss.chinamobile.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 11/22] usb: host: fix a few spelling mistakes in comments
Date: Tue, 10 Nov 2026 09:45:53 +0100	[thread overview]
Message-ID: <20261110094553.05e693e4.michal.pecio@gmail.com> (raw)
In-Reply-To: <20261110075825.24946-12-shishunbo@cmss.chinamobile.com>

On Tue, 10 Nov 2026 07:58:14 +0000, Shunbo Shi wrote:
> No functional changes.
> 
> Signed-off-by: Shunbo Shi <shishunbo@cmss.chinamobile.com>

Hi,

Not 100% sure, but hasn't Greg KH indicated no interest in such patches
for drivers outside of staging?

I don't like them either, IMO the noise added to git-blame is usually
more annoying in practice than original errors.

> - * long delay for the handshake of STS_HALT is neeed in xhci_suspend()
> + * long delay for the handshake of STS_HALT is need in xhci_suspend()

> -/* Mult - Max number of burtst within an interval, in EP companion desc. */
> +/* Mult - Max number of burst within an interval, in EP companion desc. */

So words that don't exist have been replaced with words that exist.
But the text is still wrong.

These are just two random examples near the end, I haven't read even
a fraction of the whole thing.

Another issue I have seen in those patches are fixes to comments that
aren't even true anymore, but the author has no idea of course.

Regards,
Michal

  reply	other threads:[~2026-11-10  8:46 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  6:40 [PATCH 00/22] usb: fix " Shunbo Shi
2026-11-10  6:40 ` [PATCH 01/22] usb: atm: fix a few " Shunbo Shi
2026-11-10  6:40 ` [PATCH 02/22] usb: cdns3: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 03/22] usb: chipidea: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 04/22] usb: class: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 05/22] usb: common: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 06/22] usb: core: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 07/22] usb: dwc2: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 08/22] usb: dwc3: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 09/22] usb: fotg210: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 10/22] usb: gadget: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 11/22] usb: host: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 12/22] usb: image: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 13/22] usb: isp1760: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 14/22] usb: misc: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 15/22] usb: musb: " Shunbo Shi
2026-11-10  6:40 ` [PATCH 16/22] usb: phy: " Shunbo Shi
2026-11-10  6:41 ` [PATCH 17/22] usb: renesas_usbhs: " Shunbo Shi
2026-11-10  6:41 ` [PATCH 18/22] usb: roles: " Shunbo Shi
2026-11-10  6:41 ` [PATCH 19/22] usb: serial: " Shunbo Shi
2026-11-10  6:41 ` [PATCH 20/22] usb: storage: " Shunbo Shi
2026-11-10  6:41 ` [PATCH 21/22] usb: typec: " Shunbo Shi
2026-11-10  6:41 ` [PATCH 22/22] usb: usbip: " Shunbo Shi
2026-11-10  7:58 ` [PATCH v2 00/22] usb: fix " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 01/22] usb: atm: fix a few " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 02/22] usb: cdns3: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 03/22] usb: chipidea: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 04/22] usb: class: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 05/22] usb: common: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 06/22] usb: core: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 07/22] usb: dwc2: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 08/22] usb: dwc3: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 09/22] usb: fotg210: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 10/22] usb: gadget: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 11/22] usb: host: " Shunbo Shi
2026-11-10  8:45     ` Michal Pecio [this message]
2026-11-10  7:58   ` [PATCH v2 12/22] usb: image: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 13/22] usb: isp1760: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 14/22] usb: misc: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 15/22] usb: musb: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 16/22] usb: phy: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 17/22] usb: renesas_usbhs: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 18/22] usb: roles: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 19/22] usb: serial: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 20/22] usb: storage: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 21/22] usb: typec: " Shunbo Shi
2026-11-10  7:58   ` [PATCH v2 22/22] usb: usbip: " Shunbo Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110094553.05e693e4.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shishunbo@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®