(no subject)

[Nick]

From: Nick <nick21042013@gmail.com>

Date: Tue, 10 Nov 2026 19:57:26 +0630

Subject: [PATCH] staging: iio: adt7316: fix camelCase violations



Rename Vref and AIN to lowercase characters.

This fixes the style violations and brings

the driver into line with the kernel style

guidelines.



Signed-off-by: Nick <nick21042013@gmail.com>

---

 drivers/staging/iio/addac/adt7316.c | 12 ++++++------

 1 file changed, 6 insertions(+), 6 deletions(-)



diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c

index 20f6052cc..a71502cf0 100644

--- a/drivers/staging/iio/addac/adt7316.c

+++ b/drivers/staging/iio/addac/adt7316.c

@@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,

 		adt7316_store_da_high_resolution,

 		0);

 

-static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,

+static ssize_t adt7316_show_ain_internal_vref(struct device *dev,

 					      struct device_attribute *attr,

 					      char *buf)

 {

@@ -677,7 +677,7 @@ static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,

 		!!(chip->config3 & ADT7516_AIN_IN_VREF));

 }

 

-static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,

+static ssize_t adt7316_store_ain_internal_vref(struct device *dev,

 					       struct device_attribute *attr,

 					       const char *buf,

 					       size_t len)

@@ -704,9 +704,9 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,

 	return len;

 }

 

-static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,

-		adt7316_show_AIN_internal_Vref,

-		adt7316_store_AIN_internal_Vref,

+static IIO_DEVICE_ATTR(ain_internal_vref, 0644,

+		adt7316_show_ain_internal_vref,

+		adt7316_store_ain_internal_vref,

 		0);

 

 static ssize_t adt7316_show_enable_prop_DACA(struct device *dev,

@@ -1684,7 +1684,7 @@ static struct attribute *adt7516_attributes[] = {

 	&iio_dev_attr_enable_smbus_timeout.dev_attr.attr,

 	&iio_dev_attr_powerdown.dev_attr.attr,

 	&iio_dev_attr_fast_ad_clock.dev_attr.attr,

-	&iio_dev_attr_AIN_internal_Vref.dev_attr.attr,

+	&iio_dev_attr_ain_internal_vref.dev_attr.attr,

 	&iio_dev_attr_da_high_resolution.dev_attr.attr,

 	&iio_dev_attr_enable_proportion_DACA.dev_attr.attr,

 	&iio_dev_attr_enable_proportion_DACB.dev_attr.attr,

-- 

2.52.0.windows.1

Re:

[Joshua Crofts]

Hi Nick,

Several issues with this patch unfortunately :(

On Tue, 10 Nov 2026 20:33:54 +0630
Nick <nick21042013@gmail.com> wrote:

> From: Nick <nick21042013@gmail.com>
> 
> Date: Tue, 10 Nov 2026 19:57:26 +0630
> 
> Subject: [PATCH] staging: iio: adt7316: fix camelCase violations

This shouldn't be in the body of the commit. Additionally, you're missing a
subject.
> 
> 
> Rename Vref and AIN to lowercase characters.
> 

What's going on with the spacing? This unfortunately fails to apply, as
the patch is malformed. I see that you sent it with git send-email, but
was the patch created correctly with git format-patch?

> This fixes the style violations and brings
> 
> the driver into line with the kernel style
> 
> guidelines.
> 

Additionally, the camelCase is intentional, as this is standard
notation for things like voltages.

> 
> Signed-off-by: Nick <nick21042013@gmail.com>

Also, we need a full name in the Signed-off-by tag.

-- 
Kind regards,
Joshua Crofts