From: Priyank Rathod <rathodpriyank@google.com>
To: Lukas Wunner <lukas@wunner.de>, Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Ricky Wu <ricky_wu@realtek.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Fix NULL pointer dereference in pciehp_configure_device()
Date: Tue, 10 Nov 2026 17:52:02 +0000 [thread overview]
Message-ID: <20261110175203.1307769-1-rathodpriyank@google.com> (raw)
In-Reply-To: <81a1fed9c86e3954b1807f7425f98d210503a28f.camel@linux.ibm.com>
On Tue, Nov 10, 2026 at 04:43:52PM +0100, Niklas Schnelle wrote:
> On Tue, 2026-11-10 at 11:04 +0100, Lukas Wunner wrote:
> > Are you actually observing a crash in practice because of a missing NULL
> > pointer check?
>
> FWIW we (s390) do not use pciehp we use our own s390_pci_hpc for
> hotplug. I'd be interested if this comes out of a real issue or just an
> LLM worry too though.
Hi Lukas, Niklas,
No crash was observed in practice -- this came from static inspection,
and even reproducing it in QEMU requires patching QEMU's pcie-root-port
to bypass its Function 0 hotplug checks in addition to
hypervisor_isolated_pci_functions() returning true.
Since this isn't reachable on unmodified hypervisors and Terry's pending
patch removes ctrl->dsn and those lines altogether, please consider this
patch withdrawn. Thanks for the pointer and clarification!
Best regards,
Priyank
prev parent reply other threads:[~2026-11-10 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 22:03 Priyank Rathod
[not found] ` <sashiko-outbox-168676@kernel.org>
2026-11-09 21:53 ` Priyank Rathod
2026-11-10 10:04 ` Lukas Wunner
2026-11-10 15:43 ` Niklas Schnelle
2026-11-10 17:52 ` Priyank Rathod [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110175203.1307769-1-rathodpriyank@google.com \
--to=rathodpriyank@google.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=ricky_wu@realtek.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®