mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergey Lebedev <lsa.uz@pm.me>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Peter Marshall <pm@petermarshall.ca>,
	George Neacsu <geocausa@gmail.com>, Hao Yao <hao.yao@intel.com>,
	Fernando Rimoli <fernandorimoli11@gmail.com>,
	"D. Manresa" <dmanresa@gmail.com>, Jizhou Tong <fqwqf@fqwqf.xyz>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver
Date: Tue, 10 Nov 2026 19:46:29 +0000	[thread overview]
Message-ID: <20261110194620.46374-1-lsa.uz@pm.me> (raw)
In-Reply-To: <3750472c-5a49-48f6-a8bf-0bae45e4c01b@foss.st.com>

Hi Benjamin,

On Tue, Nov 10, 2026 at 10:46:57AM +0100, Benjamin Mugnier wrote:
> From a user perspective they are mostly interchangeable. vd55g1 uses
> AE_TARGET_PERCENTAGE while vd56g3 uses AE_COMPENSATION for instance.
>
> The downstream driver uses AE_TARGET_PERCENTAGE and that's why you have
> it here. It would make more sense to use AE_COMPENSATION semantic wise,
> but this is not a deal breaker.

I tried AE_COMPENSATION on the VD55G0 here, with the firmware patch the
driver loads. Positive values work as UM2829 says, but a negative one
drives the AE to its maximum.

A white sheet in front of the camera, the illuminator on, each value in
a stream of its own:
- AE_TARGET_PERCENTAGE 7, 14, 27: exposure 27, 49, 89 lines;
- target 7 with +1 EV (0x0100) and +2 EV (0x0200): 48 and 91 lines;
- target 14 with -1 EV (0xff00): 1796 lines, analogue gain 24, digital
  gain 2048.

On the Dgrey test pattern every negative value did the same: -0.5, -1
and -2 EV in two's complement, and -1 and -2 EV as sign and magnitude
(0x8100, 0x8200). AE_TARGET_PERCENTAGE works both ways, so v4 keeps it.

Is this known for the VD55G0 firmware?

Sergey


  reply	other threads:[~2026-11-10 19:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  9:34 [PATCH v3 0/4] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-11-09  9:34 ` [PATCH v3 1/4] dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0 Sergey Lebedev
2026-11-09 10:28   ` Benjamin Mugnier
2026-11-09 10:36     ` Sergey Lebedev
2026-11-10 11:34     ` Krzysztof Kozlowski
2026-11-10 11:33   ` Krzysztof Kozlowski
2026-11-09  9:34 ` [PATCH v3 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-11-09 11:36   ` Sakari Ailus
2026-11-09 12:46     ` Sergey Lebedev
2026-11-09 12:59       ` Sakari Ailus
2026-11-09 13:27         ` Sergey Lebedev
2026-11-10  9:46           ` Benjamin Mugnier
2026-11-10 19:46             ` Sergey Lebedev [this message]
2026-11-09  9:34 ` [PATCH v3 3/4] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-11-09  9:34 ` [PATCH v3 4/4] media: ipu-bridge: Add the Surface Pro 9 and 11 infrared illuminator Sergey Lebedev
2026-11-09 11:39   ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110194620.46374-1-lsa.uz@pm.me \
    --to=lsa.uz@pm.me \
    --cc=benjamin.mugnier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmanresa@gmail.com \
    --cc=fernandorimoli11@gmail.com \
    --cc=fqwqf@fqwqf.xyz \
    --cc=geocausa@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hao.yao@intel.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pm@petermarshall.ca \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®