From: Greg KH <gregkh@linuxfoundation.org>
To: mdshahid03@gmail.com
Cc: starblue@users.sourceforge.net,
legousb-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: legousbtower: use stream_open for stream semantics
Date: Tue, 10 Nov 2026 13:21:02 -0500 [thread overview]
Message-ID: <2026111054-reversing-gurgling-94fd@gregkh> (raw)
In-Reply-To: <179433189678.152716.11457478975708955224.b4-reply@b4>
On Tue, Nov 10, 2026 at 11:01:36PM +0530, mdshahid03@gmail.com wrote:
> Hi,
>
> Could you please review patch and give your feedback,when time permits.
>
> Thanks
> Shahid.
>
> On 2026-10-28 23:58 +0530, mdshahid03@gmail.com wrote:
> > From: Mohammad Shahid <mdshahid03@gmail.com>
> >
> > The LEGO USB Tower driver uses nonseekable_open() in tower_open()
> > However, its read and write have stream semantics.
> >
> > Use stream_open instead to mark the file as a stream and disable
> > unnecessary file position handling.
> >
> > The issue is reported by stream_open.cocci script as potential
> > deadlock between read and write operation.
> >
> > Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
> > ---
> > drivers/usb/misc/legousbtower.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
How was this tested?
prev parent reply other threads:[~2026-11-10 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 18:28 mdshahid03
2026-11-10 17:31 ` mdshahid03
2026-11-10 18:21 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026111054-reversing-gurgling-94fd@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=legousb-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdshahid03@gmail.com \
--cc=starblue@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®