Re: [PATCH v2 6/8] dt-bindings: timer: Add MIPS P8700 ACLINT MTIMER

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3130 bytes --]

On Tue, Nov 03, 2026 at 09:49:22PM +0000, Conor Dooley wrote:
> On Tue, Nov 03, 2026 at 04:11:30PM +0100, Aleksa Paunovic via B4 Relay wrote:
> > From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> > 
> > Document the MIPS P8700 ACLINT MTIMER.
> > Extend support for both mtimecmp and mtime registers
> > within the ACLINT MTIMER, identified via reg-names.
> > 
> > Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> 
> Same comments here too.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable

On second thoughts, we probably need to be careful about the reg
ordering here. This binding has always required that mtimecmp be "first"
because it was the only let me rescind my ack for now and think about
what the correct thing to do is...

Cheers,
Conor.

> 
> > ---
> >  .../bindings/timer/thead,c900-aclint-mtimer.yaml   | 35 ++++++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> > index cf7c82e980f674afcf59fc726742dc4f49c1a820..40acb651c27b7eaa8a20caa8bbc225b350088810 100644
> > --- a/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> > +++ b/Documentation/devicetree/bindings/timer/thead,c900-aclint-mtimer.yaml
> > @@ -21,14 +21,19 @@ properties:
> >            - enum:
> >                - anlogic,dr1v90-aclint-mtimer
> >            - const: nuclei,ux900-aclint-mtimer
> > +      - const: gf,mips-p8700-aclint-mtimer
> >  
> >    reg:
> > +    minItems: 1
> >      items:
> >        - description: MTIMECMP Registers
> > +      - description: MTIME Registers
> >  
> >    reg-names:
> > +    minItems: 1
> >      items:
> >        - const: mtimecmp
> > +      - const: mtime
> >  
> >    interrupts-extended:
> >      minItems: 1
> > @@ -42,6 +47,25 @@ required:
> >    - reg-names
> >    - interrupts-extended
> >  
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: gf,mips-p8700-aclint-mtimer
> > +    then:
> > +      properties:
> > +        reg:
> > +          minItems: 2
> > +        reg-names:
> > +          minItems: 2
> > +    else:
> > +      properties:
> > +        reg:
> > +          maxItems: 1
> > +        reg-names:
> > +          maxItems: 1
> > +
> >  examples:
> >    - |
> >      timer@ac000000 {
> > @@ -53,4 +77,15 @@ examples:
> >        reg = <0xac000000 0x00010000>;
> >        reg-names = "mtimecmp";
> >      };
> > +
> > +  - |
> > +    timer@16154000 {
> > +        compatible = "gf,mips-p8700-aclint-mtimer";
> > +        reg = <0x16154000 0x7ff8>, <0x16108050 0x8>;
> > +        reg-names = "mtimecmp", "mtime";
> > +        interrupts-extended = <&cpu1intc 7>,
> > +                              <&cpu2intc 7>,
> > +                              <&cpu3intc 7>,
> > +                              <&cpu4intc 7>;
> > +    };
> >  ...
> > 
> > -- 
> > 2.43.0
> > 
> > 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]