mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chukun Pan <amadeus@jmu.edu.cn>
To: andrew@lunn.ch
Cc: Frank.Sae@motor-comm.com, amadeus@jmu.edu.cn,
	davem@davemloft.net, edumazet@kernel.org, hkallweit1@gmail.com,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH 1/2] net: phy: motorcomm: add led_brightness_set for YT8521
Date: Wed, 11 Nov 2026 14:50:10 +0800	[thread overview]
Message-ID: <20261111065010.2040437-1-amadeus@jmu.edu.cn> (raw)
In-Reply-To: <598009be-95f3-4091-b3bc-98815c65216e@lunn.ch>

Hi,

> Has this been tested on real hardware?

I tested yt8531 on some SBCs and will add this to the commit message.

> Have you had it blinking the heartbeat? Shift-lock etc.

Only supports forced LED on/off. Forced blink is disabled by default.
Do I need to implement heartbeat?

> I _think_ this is the wrong place to insert these.
>
> The sorting of registers is a bit messed up in this driver, but i
> think you need to insert before:
>
> #define YTPHY_PAD_DRIVE_STRENGTH_REG		0xA010

Indeed, I will correct this.

Thanks,
Chukun

  reply	other threads:[~2026-11-11  6:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 10:00 Chukun Pan
2026-11-10 10:00 ` [PATCH 2/2] net: phy: motorcomm: add missing trigger link " Chukun Pan
2026-11-10 16:54   ` Andrew Lunn
2026-11-14 10:24   ` netdev-bot+sashiko
2026-11-10 16:53 ` [PATCH 1/2] net: phy: motorcomm: add led_brightness_set " Andrew Lunn
2026-11-11  6:50   ` Chukun Pan [this message]
2026-11-11 13:20     ` Andrew Lunn
2026-11-12 11:40       ` Chukun Pan
2026-11-14 10:24 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111065010.2040437-1-amadeus@jmu.edu.cn \
    --to=amadeus@jmu.edu.cn \
    --cc=Frank.Sae@motor-comm.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®