From: Andrew Lunn <andrew@lunn.ch>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Frank.Sae@motor-comm.com, davem@davemloft.net,
edumazet@kernel.org, hkallweit1@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH 1/2] net: phy: motorcomm: add led_brightness_set for YT8521
Date: Wed, 11 Nov 2026 14:20:48 +0100 [thread overview]
Message-ID: <45f91901-bb11-45a7-a09c-db9ed4ef0117@lunn.ch> (raw)
In-Reply-To: <20261111065010.2040437-1-amadeus@jmu.edu.cn>
> Only supports forced LED on/off. Forced blink is disabled by default.
> Do I need to implement heartbeat?
drivers/leds/trigger/ledtrig-heartbeat.c
You can enable it just like any other trigger.
I find it useful to know when my bugs have caused a deadlock, etc.
Andrew
prev parent reply other threads:[~2026-11-11 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 10:00 Chukun Pan
2026-11-10 10:00 ` [PATCH 2/2] net: phy: motorcomm: add missing trigger link " Chukun Pan
2026-11-10 16:54 ` Andrew Lunn
2026-11-10 16:53 ` [PATCH 1/2] net: phy: motorcomm: add led_brightness_set " Andrew Lunn
2026-11-11 6:50 ` Chukun Pan
2026-11-11 13:20 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45f91901-bb11-45a7-a09c-db9ed4ef0117@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Sae@motor-comm.com \
--cc=amadeus@jmu.edu.cn \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®