From: Hongliang Yang <hongliang.yang@cixtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hongliang Yang <hongliang.yang@cixtech.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Gary Yang <Gary.Yang@cixtech.com>,
Fugang Duan <fugang.duan@cixtech.com>,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: [PATCH v6 1/3] dt-bindings: phy: Add CIX Sky1 USB3 PHY
Date: Wed, 11 Nov 2026 16:27:17 +0800 [thread overview]
Message-ID: <20261111082718.3425848-1-hongliang.yang@cixtech.com> (raw)
In-Reply-To: <66d48a6d-00c8-42fc-889d-d0901c8d85a6@kernel.org>
> This clearly shows two phys - each node with cell=0, means each having
> one phy. Two nodes, so two phys.
Right, v5 made two phy objects. That was the bug: they were the same
PHY.
The block has two lanes, one per Type-A port: USB4 uses one lane, USB5
the other. Both lanes are programmed through the same register block,
with the same clocks, the same resets and the same init sequence. In v5
the driver created one phy object per child node and gave both the same
drvdata, so the second object programmed exactly the same registers as
the first; the only difference between them was the of_node they were
registered with.
v6 removes that duplicate. One phy object remains; both lanes are still
programmed by the same init sequence, and both Type-A controllers still
get a working PHY. Nothing was dropped.
Best regards,
Hongliang Yang
next prev parent reply other threads:[~2026-11-11 8:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 1:17 [PATCH v6 0/3] phy: Add CIX Sky1 USB3 PHY support Hongliang Yang (杨宏亮)
2026-11-05 1:17 ` [PATCH v6 1/3] dt-bindings: phy: Add CIX Sky1 USB3 PHY Hongliang Yang (杨宏亮)
2026-11-05 11:52 ` Krzysztof Kozlowski
2026-11-11 3:09 ` Hongliang Yang
2026-11-11 7:52 ` Krzysztof Kozlowski
2026-11-11 8:27 ` Hongliang Yang [this message]
2026-11-05 1:18 ` [PATCH v6 2/3] phy: cix: Add CIX Sky1 USB3 PHY driver Hongliang Yang (杨宏亮)
2026-11-05 1:18 ` [PATCH v6 3/3] arm64: dts: cix: Add USB3 PHY nodes for Sky1 Hongliang Yang (杨宏亮)
2026-11-05 11:51 ` [PATCH v6 0/3] phy: Add CIX Sky1 USB3 PHY support Krzysztof Kozlowski
2026-11-11 3:09 ` Hongliang Yang
2026-11-11 7:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111082718.3425848-1-hongliang.yang@cixtech.com \
--to=hongliang.yang@cixtech.com \
--cc=Gary.Yang@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®