Re: [RFC PATCH] ARM: OMAP2+: fix omap_device with noirq_suspend

[Andreas Kemnade <andreas@kemnade.info>]

On Tue, 10 Nov 2026 16:22:39 -0800
Kevin Hilman <khilman@baylibre.com> wrote:

> Andreas Kemnade <andreas@kemnade.info> writes:
> 
> > Fixes cases where device runtime gets resumed in _suspend but then
> > pm_runtime_force_suspend is used.  So the device is disabled, but runtime
> > active in _noirq_suspend leading to duplicate runtime_suspend calls. So
> > rather check for the device state directly to indicate if changes are
> > needed.
> > This relies on pm_runtime_force_resume being used in a balanced way.
> >
> > Fixes: 7da7fd7e66ac9 ("i2c: omap: wakeup the controller during suspend() callback")
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > This really needs intensive scrutiny but might be a less invasive patch
> > solution better suited for stable and paves the way to get out of the
> > omap_device theatre without too much hurry.  
> 
> This looks & feels correct to me.
> 
> I also tested this (along with my WIP patch for that NEON count
> mismatch) and I have a very stable suspend/resume on OMAP3.
> 
> I tested on omap3-beagle (retention) and omap3-beagle-xm (off-mode) and
> both are now reliable across multiple suspend/resume sequences with
> these two patches.
> 
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
> Tested-by: Kevin Hilman <khilman@baylibre.com>
> 
Then feel free to ignore the RFC and apply this one.

Regards,
Andreas