mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Bridges <icb@fastmail.org>
To: jan.koester@tuxist.de
Cc: linkinjeon@kernel.org, senozhatsky@chromium.org, tom@talpey.com,
	chenxiaosong@chenxiaosong.com, brauner@kernel.org,
	linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, Ian Bridges <icb@fastmail.org>
Subject: Re: [RFC PATCH 5/6] ksmbd: show classic users as S-1-22-1-<uid> on every server
Date: Wed, 11 Nov 2026 10:10:29 -0600	[thread overview]
Message-ID: <20261111161029.4128473-1-icb@fastmail.org> (raw)
In-Reply-To: <f30f64394434b17ac1347afb@groupi3>

Hi Jan,

On Tue, Nov 10, 2026 at 09:02:52AM +0000, Jan Koester wrote:
> +	else if (uid_is_legacy(uid))
> +		id_to_sid(from_kuid_munged(&init_user_ns, uid), SIDUNIX_USER, ssid);

smb_check_perm_dacl() seems to still build the caller's own SID in the
old form. For a user other than root, would an ACE that a client writes
for S-1-22-1-<uid> then match the user only through the token? If
ksmbd_user_set_token() builds no token, as when its allocation fails in
4/6, would a deny ACE on the user in the new form stop applying? With a
deny for S-1-22-1-<uid> followed by an allow for Everyone, the user
would then get the access the deny should refuse.

Thanks,
Ian

  reply	other threads:[~2026-11-11 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  9:02 Jan Koester
2026-11-11 16:10 ` Ian Bridges [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-10-28  6:19 [RFC PATCH 0/6] ksmbd: Windows SIDs for user and group ids Jan Koester
2026-10-28  6:20 ` [RFC PATCH 5/6] ksmbd: show classic users as S-1-22-1-<uid> on every server Jan Koester

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111161029.4128473-1-icb@fastmail.org \
    --to=icb@fastmail.org \
    --cc=brauner@kernel.org \
    --cc=chenxiaosong@chenxiaosong.com \
    --cc=jan.koester@tuxist.de \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=senozhatsky@chromium.org \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®