mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
@ 2026-11-10 15:02 Lukasz Majewski
  2026-11-10 15:15 ` Guenter Roeck
  0 siblings, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2026-11-10 15:02 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: Frank Li, Shawn Guo, Guenter Roeck, devicetree, linux-kernel,
	Lukasz Majewski

Add "national,lm77" as compatible for the National (now TI) LM77
digital I2C temperature sensor.

Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index a8b2b9deade4..9413ee0626f5 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -387,6 +387,8 @@ properties:
           - national,lm85c
             # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature Sensor and Thermal Window Comparator
           - national,lm92
+            # Temperature sensor
+          - national,lm77
             # Nuvoton Temperature Sensor
           - nuvoton,w83773g
             # NXP ISP1301 USB transceiver
-- 
2.39.5


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
  2026-11-10 15:02 [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor Lukasz Majewski
@ 2026-11-10 15:15 ` Guenter Roeck
  2026-11-10 18:31   ` Conor Dooley
  2026-11-11  8:23   ` Łukasz Majewski
  0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2026-11-10 15:15 UTC (permalink / raw)
  To: Lukasz Majewski, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: Frank Li, Shawn Guo, devicetree, linux-kernel

On 11/10/26 07:02, Lukasz Majewski wrote:
> Add "national,lm77" as compatible for the National (now TI) LM77
> digital I2C temperature sensor.
> 
> Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> ---
>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index a8b2b9deade4..9413ee0626f5 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -387,6 +387,8 @@ properties:
>             - national,lm85c
>               # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature Sensor and Thermal Window Comparator
>             - national,lm92
> +            # Temperature sensor
> +          - national,lm77

I'd suggest to retain alphabetic order.

Having said that, is there any evidence that this chip is used
on a system supporting devicetree ?

Thanks,
Guenter

>               # Nuvoton Temperature Sensor
>             - nuvoton,w83773g
>               # NXP ISP1301 USB transceiver


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
  2026-11-10 15:15 ` Guenter Roeck
@ 2026-11-10 18:31   ` Conor Dooley
  2026-11-11  8:23   ` Łukasz Majewski
  1 sibling, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2026-11-10 18:31 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Lukasz Majewski, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Frank Li, Shawn Guo, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]

On Tue, Nov 10, 2026 at 07:15:30AM -0800, Guenter Roeck wrote:
> On 11/10/26 07:02, Lukasz Majewski wrote:
> > Add "national,lm77" as compatible for the National (now TI) LM77
> > digital I2C temperature sensor.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> > ---
> >   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index a8b2b9deade4..9413ee0626f5 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -387,6 +387,8 @@ properties:
> >             - national,lm85c
> >               # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature Sensor and Thermal Window Comparator
> >             - national,lm92
> > +            # Temperature sensor
> > +          - national,lm77
> 
> I'd suggest to retain alphabetic order.

pw-bot: changes-requested

> Having said that, is there any evidence that this chip is used
> on a system supporting devicetree ?

Seemingly yes, the author just submitted a "series" adding a board that
uses it. I say series, because it was two independent patches:
https://lore.kernel.org/all/20261110150546.1535950-1-lukma@nabladev.com/
https://lore.kernel.org/all/20261110150024.1530988-1-lukma@nabladev.com/

> 
> Thanks,
> Guenter
> 
> >               # Nuvoton Temperature Sensor
> >             - nuvoton,w83773g
> >               # NXP ISP1301 USB transceiver
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
  2026-11-10 15:15 ` Guenter Roeck
  2026-11-10 18:31   ` Conor Dooley
@ 2026-11-11  8:23   ` Łukasz Majewski
  2026-11-11 17:53     ` Rob Herring
  1 sibling, 1 reply; 5+ messages in thread
From: Łukasz Majewski @ 2026-11-11  8:23 UTC (permalink / raw)
  To: Guenter Roeck
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Shawn Guo, devicetree, linux-kernel

Hi Guenter,

> On 11/10/26 07:02, Lukasz Majewski wrote:
> > Add "national,lm77" as compatible for the National (now TI) LM77
> > digital I2C temperature sensor.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> > ---
> >   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > a8b2b9deade4..9413ee0626f5 100644 ---
> > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -387,6
> > +387,8 @@ properties:
> >             - national,lm85c
> >               # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature
> > Sensor and Thermal Window Comparator
> >             - national,lm92
> > +            # Temperature sensor
> > +          - national,lm77  
> 
> I'd suggest to retain alphabetic order.
> 

The "alphabetic" order for "national," is already "disturbed" in this
file - that is why I've put it in the end.

Now, the question - shall I "order" properly all of "national,"
bindings in a single patch (including the new one)?

Or prepare two patches:
- One to make the alphabetic order for already in-tree properties 

and

- Add the "national,lm77" afterwards ?

> Having said that, is there any evidence that this chip is used
> on a system supporting devicetree ?

Yes, it is required for CBASE board (also send to the devicetree mailing
list for review).

> 
> Thanks,
> Guenter
> 
> >               # Nuvoton Temperature Sensor
> >             - nuvoton,w83773g
> >               # NXP ISP1301 USB transceiver  
> 



-- 
Best regards,

Lukasz Majewski

--
Nabla Software Engineering GmbH
HRB 40522 Augsburg
Phone: +49 821 45592596
E-Mail: office@nabladev.com
Managing Director : Stefano Babic

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor
  2026-11-11  8:23   ` Łukasz Majewski
@ 2026-11-11 17:53     ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2026-11-11 17:53 UTC (permalink / raw)
  To: Łukasz Majewski
  Cc: Guenter Roeck, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Shawn Guo, devicetree, linux-kernel

On Wed, Nov 11, 2026 at 09:23:11AM +0100, Łukasz Majewski wrote:
> Hi Guenter,
> 
> > On 11/10/26 07:02, Lukasz Majewski wrote:
> > > Add "national,lm77" as compatible for the National (now TI) LM77
> > > digital I2C temperature sensor.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@nabladev.com>
> > > ---
> > >   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >   1 file changed, 2 insertions(+)

Not really a trivial device as there is a T_CRIT_A signal...

Though I guess LM80 and probably others aren't really either.

> > > 
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml index
> > > a8b2b9deade4..9413ee0626f5 100644 ---
> > > a/Documentation/devicetree/bindings/trivial-devices.yaml +++
> > > b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -387,6
> > > +387,8 @@ properties:
> > >             - national,lm85c
> > >               # I2C ±0.33°C Accurate, 12-Bit + Sign Temperature
> > > Sensor and Thermal Window Comparator
> > >             - national,lm92
> > > +            # Temperature sensor
> > > +          - national,lm77  
> > 
> > I'd suggest to retain alphabetic order.
> > 
> 
> The "alphabetic" order for "national," is already "disturbed" in this
> file - that is why I've put it in the end.
> 
> Now, the question - shall I "order" properly all of "national,"
> bindings in a single patch (including the new one)?
> 
> Or prepare two patches:
> - One to make the alphabetic order for already in-tree properties 
> 
> and
> 
> - Add the "national,lm77" afterwards ?

Just don't make things worse. Put it after national,lm95245 and before 
national,lm80. Then all but the first 2 are in order.

Rob

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-11 17:53 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-10 15:02 [PATCH] dt-bindings: trivial-devices: Add National lm77 temperature sensor Lukasz Majewski
2026-11-10 15:15 ` Guenter Roeck
2026-11-10 18:31   ` Conor Dooley
2026-11-11  8:23   ` Łukasz Majewski
2026-11-11 17:53     ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®