[PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Pavel Popov]

VMware and Hyper-V expose passthrough devices to guest VMs without an
explicit host bridge device. Consequently, host_bridge_whitelist()
cannot automatically identify the underlying host bridge structure,
causing Peer-to-Peer DMA (P2PDMA) requests to be rejected unless the
device IDs are explicitly listed in pci_p2pdma_whitelist[]. To enable
P2PDMA on Intel hosts, this series extends cpu_supports_p2pdma(), which
so far covers AMD Zen and newer, with an explicit list of Intel Xeon
server generations.

Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by carried
over; the Xeon list and the check are unchanged.

Changes in v4:
- Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
  (Logan Gunthorpe, Leon Romanovsky)
- Keep the #ifdef around the asm/ includes, as these headers exist
  only on x86 (Bjorn Helgaas)

Changes in v3:
- Drop the hypervisor check and move the Xeon list into
  cpu_supports_p2pdma(), next to the AMD check, as suggested by Logan
  Gunthorpe and Leon Romanovsky [1]
- Fold the VMware and Hyper-V patches into one, as the check no longer
  depends on the hypervisor

Changes in v2:
- Replace the Skylake-and-newer threshold with an explicit list of Intel
  Xeon server generations, from Skylake-SP to Diamond Rapids (Logan
  Gunthorpe)
- Move the CONFIG_X86 #ifdef out of hypervisor_supports_p2pdma()
  (Logan Gunthorpe)
- Rebased on current mainline

[1] https://lore.kernel.org/r/20261016153147.GC219304@unreal

v3: https://lore.kernel.org/r/20261020151305.65218-1-pavel.e.popov@intel.com
v2: https://lore.kernel.org/r/20261016223402.19991-1-pavel.e.popov@intel.com
v1: https://lore.kernel.org/r/20261009154034.82321-1-pavel.e.popov@intel.com

Pavel Popov (2):
  PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
  PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

 drivers/pci/p2pdma.c | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)


base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
-- 
2.53.0

[PATCH v4 1/2] PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()

[Pavel Popov]

cpu_supports_p2pdma() has an #ifdef CONFIG_X86 block inside the
function body. Put the whole function under #ifdef CONFIG_X86 instead,
with a stub returning false for !CONFIG_X86.

No functional change.

Suggested-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Pavel Popov <pavel.e.popov@intel.com>
---
 drivers/pci/p2pdma.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 9334eb314663..6b4f0843b404 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -519,18 +519,23 @@ static void seq_buf_print_bus_devfn(struct seq_buf *buf, struct pci_dev *pdev)
 	seq_buf_printf(buf, "%s;", pci_name(pdev));
 }
 
+#ifdef CONFIG_X86
 static bool cpu_supports_p2pdma(void)
 {
-#ifdef CONFIG_X86
 	struct cpuinfo_x86 *c = &cpu_data(0);
 
 	/* Any AMD CPU whose family ID is Zen or newer supports p2pdma */
 	if (c->x86_vendor == X86_VENDOR_AMD && c->x86 >= 0x17)
 		return true;
-#endif
 
 	return false;
 }
+#else /* !CONFIG_X86 */
+static bool cpu_supports_p2pdma(void)
+{
+	return false;
+}
+#endif /* CONFIG_X86 */
 
 static const struct pci_p2pdma_whitelist_entry {
 	unsigned short vendor;
-- 
2.53.0

[PATCH v4 2/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Pavel Popov]

Peer-to-Peer DMA (P2PDMA) between two devices requires either a shared
upstream bridge or a host bridge matching pci_p2pdma_whitelist[]. In
VMware guests, passthrough devices appear directly on virtual root
buses without host bridge devices. In Hyper-V guests, each passthrough
device appears in a PCI domain of its own without a host bridge
device. Consequently, P2PDMA checks evaluate endpoint Device IDs
against the host bridge whitelist, causing P2PDMA requests to fail
regardless of host support.

This affects discrete devices such as GPUs, NICs and NVMe drives.

Add an explicit list of the Intel Xeon server generations from
Skylake-SP to Diamond Rapids to cpu_supports_p2pdma(). These are the
CPUs whose host bridges are in pci_p2pdma_whitelist[] without
restrictions. AMD Zen and newer are already covered by
cpu_supports_p2pdma(), so only Intel entries are needed.

Tested with the Intel Level Zero P2P benchmark (ze_peer) on Arc Pro B60
cards in a Linux guest on VMware ESXi 9.0 (Emerald Rapids host).

Signed-off-by: Pavel Popov <pavel.e.popov@intel.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
---
 drivers/pci/p2pdma.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/pci/p2pdma.c b/drivers/pci/p2pdma.c
index 6b4f0843b404..cb9084fb0990 100644
--- a/drivers/pci/p2pdma.c
+++ b/drivers/pci/p2pdma.c
@@ -21,6 +21,11 @@
 #include <linux/seq_buf.h>
 #include <linux/xarray.h>
 
+#ifdef CONFIG_X86
+#include <asm/cpu_device_id.h>
+#include <asm/intel-family.h>
+#endif
+
 struct pci_p2pdma {
 	struct gen_pool *pool;
 	bool p2pmem_published;
@@ -520,6 +525,21 @@ static void seq_buf_print_bus_devfn(struct seq_buf *buf, struct pci_dev *pdev)
 }
 
 #ifdef CONFIG_X86
+/* Intel Xeon CPUs whose host bridges support p2pdma */
+static const struct x86_cpu_id p2pdma_intel_cpu_ids[] = {
+	X86_MATCH_VFM(INTEL_SKYLAKE_X, NULL),
+	X86_MATCH_VFM(INTEL_ICELAKE_X, NULL),
+	X86_MATCH_VFM(INTEL_ICELAKE_D, NULL),
+	X86_MATCH_VFM(INTEL_SAPPHIRERAPIDS_X, NULL),
+	X86_MATCH_VFM(INTEL_EMERALDRAPIDS_X, NULL),
+	X86_MATCH_VFM(INTEL_GRANITERAPIDS_X, NULL),
+	X86_MATCH_VFM(INTEL_GRANITERAPIDS_D, NULL),
+	X86_MATCH_VFM(INTEL_ATOM_CRESTMONT_X, NULL),
+	X86_MATCH_VFM(INTEL_ATOM_DARKMONT_X, NULL),
+	X86_MATCH_VFM(INTEL_DIAMONDRAPIDS_X, NULL),
+	{}
+};
+
 static bool cpu_supports_p2pdma(void)
 {
 	struct cpuinfo_x86 *c = &cpu_data(0);
@@ -528,6 +548,10 @@ static bool cpu_supports_p2pdma(void)
 	if (c->x86_vendor == X86_VENDOR_AMD && c->x86 >= 0x17)
 		return true;
 
+	/* Listed Intel Xeon CPUs support p2pdma */
+	if (x86_match_cpu(p2pdma_intel_cpu_ids))
+		return true;
+
 	return false;
 }
 #else /* !CONFIG_X86 */
-- 
2.53.0

Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Leon Romanovsky]

On Tue, Oct 20, 2026 at 10:37:34AM -0700, Pavel Popov wrote:
> VMware and Hyper-V expose passthrough devices to guest VMs without an
> explicit host bridge device. Consequently, host_bridge_whitelist()
> cannot automatically identify the underlying host bridge structure,
> causing Peer-to-Peer DMA (P2PDMA) requests to be rejected unless the
> device IDs are explicitly listed in pci_p2pdma_whitelist[]. To enable
> P2PDMA on Intel hosts, this series extends cpu_supports_p2pdma(), which
> so far covers AMD Zen and newer, with an explicit list of Intel Xeon
> server generations.
> 
> Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by carried
> over; the Xeon list and the check are unchanged.
> 
> Changes in v4:
> - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
>   (Logan Gunthorpe, Leon Romanovsky)
> - Keep the #ifdef around the asm/ includes, as these headers exist
>   only on x86 (Bjorn Helgaas)

I'm confident that this is wrong usage of asm headers.

Thanks

RE: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Popov, Pavel E]

Leon,

The #ifdef CONFIG_X86 in cpu_supports_p2pdma() came with the AMD check.

Would it work for you if I move the includes into that single #ifdef
block, next to the CPU check? Some multi-arch code does the same:

  https://git.kernel.org/torvalds/c/c7be64355fcc (drivers/acpi/mipi-disco-img.c)
  https://git.kernel.org/torvalds/c/7f3cfb7943d2 (drivers/cpufreq/cpufreq_ondemand.h)

Thanks,
Pavel

> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Tuesday, October 20, 2026 11:40 AM
> To: Popov, Pavel E <pavel.e.popov@intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> <logang@deltatee.com>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> list@broadcom.com; virtualization@lists.linux.dev; linux-
> hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> server CPUs
> 
> On Tue, Oct 20, 2026 at 10:37:34AM -0700, Pavel Popov wrote:
> > VMware and Hyper-V expose passthrough devices to guest VMs without an
> > explicit host bridge device. Consequently, host_bridge_whitelist()
> > cannot automatically identify the underlying host bridge structure,
> > causing Peer-to-Peer DMA (P2PDMA) requests to be rejected unless the
> > device IDs are explicitly listed in pci_p2pdma_whitelist[]. To enable
> > P2PDMA on Intel hosts, this series extends cpu_supports_p2pdma(),
> > which so far covers AMD Zen and newer, with an explicit list of Intel
> > Xeon server generations.
> >
> > Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> > Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by
> > carried over; the Xeon list and the check are unchanged.
> >
> > Changes in v4:
> > - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> >   (Logan Gunthorpe, Leon Romanovsky)
> > - Keep the #ifdef around the asm/ includes, as these headers exist
> >   only on x86 (Bjorn Helgaas)
> 
> I'm confident that this is wrong usage of asm headers.
> 
> Thanks

Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Leon Romanovsky]

On Tue, Oct 20, 2026 at 07:37:32PM +0000, Popov, Pavel E wrote:
> Leon,
> 
> The #ifdef CONFIG_X86 in cpu_supports_p2pdma() came with the AMD check.

This is due to poking at `struct cpuinfo_x86`, which is not ideal but
understandable.

> 
> Would it work for you if I move the includes into that single #ifdef
> block, next to the CPU check? Some multi-arch code does the same:
> 
>   https://git.kernel.org/torvalds/c/c7be64355fcc (drivers/acpi/mipi-disco-img.c)
>   https://git.kernel.org/torvalds/c/7f3cfb7943d2 (drivers/cpufreq/cpufreq_ondemand.h)

Once the header files are properly exposed, clean up these other areas as well.

Thanks

> 
> Thanks,
> Pavel
> 
> > -----Original Message-----
> > From: Leon Romanovsky <leon@kernel.org>
> > Sent: Tuesday, October 20, 2026 11:40 AM
> > To: Popov, Pavel E <pavel.e.popov@intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> > <logang@deltatee.com>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> > <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> > Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> > <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> > Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> > list@broadcom.com; virtualization@lists.linux.dev; linux-
> > hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> > server CPUs
> > 
> > On Tue, Oct 20, 2026 at 10:37:34AM -0700, Pavel Popov wrote:
> > > VMware and Hyper-V expose passthrough devices to guest VMs without an
> > > explicit host bridge device. Consequently, host_bridge_whitelist()
> > > cannot automatically identify the underlying host bridge structure,
> > > causing Peer-to-Peer DMA (P2PDMA) requests to be rejected unless the
> > > device IDs are explicitly listed in pci_p2pdma_whitelist[]. To enable
> > > P2PDMA on Intel hosts, this series extends cpu_supports_p2pdma(),
> > > which so far covers AMD Zen and newer, with an explicit list of Intel
> > > Xeon server generations.
> > >
> > > Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> > > Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by
> > > carried over; the Xeon list and the check are unchanged.
> > >
> > > Changes in v4:
> > > - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> > >   (Logan Gunthorpe, Leon Romanovsky)
> > > - Keep the #ifdef around the asm/ includes, as these headers exist
> > >   only on x86 (Bjorn Helgaas)
> > 
> > I'm confident that this is wrong usage of asm headers.
> > 
> > Thanks

RE: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Popov, Pavel E]

> Once the header files are properly exposed, clean up these other areas
> as well.

Agreed, that would be a separate change, for the x86 maintainers to
decide.

Thanks

> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Wednesday, October 21, 2026 12:35 AM
> To: Popov, Pavel E <pavel.e.popov@intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> <logang@deltatee.com>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> list@broadcom.com; virtualization@lists.linux.dev; linux-
> hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> server CPUs
> 
> On Tue, Oct 20, 2026 at 07:37:32PM +0000, Popov, Pavel E wrote:
> > Leon,
> >
> > The #ifdef CONFIG_X86 in cpu_supports_p2pdma() came with the AMD
> check.
> 
> This is due to poking at `struct cpuinfo_x86`, which is not ideal but
> understandable.
> 
> >
> > Would it work for you if I move the includes into that single #ifdef
> > block, next to the CPU check? Some multi-arch code does the same:
> >
> >   https://git.kernel.org/torvalds/c/c7be64355fcc (drivers/acpi/mipi-disco-
> img.c)
> >   https://git.kernel.org/torvalds/c/7f3cfb7943d2
> > (drivers/cpufreq/cpufreq_ondemand.h)
> 
> Once the header files are properly exposed, clean up these other areas as well.
> 
> Thanks
> 
> >
> > Thanks,
> > Pavel
> >
> > > -----Original Message-----
> > > From: Leon Romanovsky <leon@kernel.org>
> > > Sent: Tuesday, October 20, 2026 11:40 AM
> > > To: Popov, Pavel E <pavel.e.popov@intel.com>
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> > > <logang@deltatee.com>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> > > <jim.chow@broadcom.com>; Radu Rugina
> <radu.rugina@broadcom.com>;
> > > Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> > > <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> > > Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> > > list@broadcom.com; virtualization@lists.linux.dev; linux-
> > > hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > > kernel@vger.kernel.org
> > > Subject: Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> > > server CPUs
> > >
> > > On Tue, Oct 20, 2026 at 10:37:34AM -0700, Pavel Popov wrote:
> > > > VMware and Hyper-V expose passthrough devices to guest VMs without
> > > > an explicit host bridge device. Consequently,
> > > > host_bridge_whitelist() cannot automatically identify the
> > > > underlying host bridge structure, causing Peer-to-Peer DMA
> > > > (P2PDMA) requests to be rejected unless the device IDs are
> > > > explicitly listed in pci_p2pdma_whitelist[]. To enable P2PDMA on
> > > > Intel hosts, this series extends cpu_supports_p2pdma(), which so
> > > > far covers AMD Zen and newer, with an explicit list of Intel Xeon server
> generations.
> > > >
> > > > Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> > > > Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by
> > > > carried over; the Xeon list and the check are unchanged.
> > > >
> > > > Changes in v4:
> > > > - Add 1/2, moving the CONFIG_X86 #ifdef out of
> cpu_supports_p2pdma()
> > > >   (Logan Gunthorpe, Leon Romanovsky)
> > > > - Keep the #ifdef around the asm/ includes, as these headers exist
> > > >   only on x86 (Bjorn Helgaas)
> > >
> > > I'm confident that this is wrong usage of asm headers.
> > >
> > > Thanks

RE: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Popov, Pavel E]

Hi Bjorn,

Gentle ping on this series. Is this OK for v7.5?

Thanks,
Pavel

> -----Original Message-----
> From: Popov, Pavel E <pavel.e.popov@intel.com>
> Sent: Tuesday, October 20, 2026 10:38 AM
> To: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> <logang@deltatee.com>
> Cc: Popov, Pavel E <pavel.e.popov@intel.com>; Leon Romanovsky
> <leon@kernel.org>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> list@broadcom.com; virtualization@lists.linux.dev; linux-
> hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server
> CPUs
> 
> VMware and Hyper-V expose passthrough devices to guest VMs without an
> explicit host bridge device. Consequently, host_bridge_whitelist() cannot
> automatically identify the underlying host bridge structure, causing Peer-to-
> Peer DMA (P2PDMA) requests to be rejected unless the device IDs are
> explicitly listed in pci_p2pdma_whitelist[]. To enable P2PDMA on Intel hosts,
> this series extends cpu_supports_p2pdma(), which so far covers AMD Zen and
> newer, with an explicit list of Intel Xeon server generations.
> 
> Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by carried over;
> the Xeon list and the check are unchanged.
> 
> Changes in v4:
> - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
>   (Logan Gunthorpe, Leon Romanovsky)
> - Keep the #ifdef around the asm/ includes, as these headers exist
>   only on x86 (Bjorn Helgaas)
> 
> Changes in v3:
> - Drop the hypervisor check and move the Xeon list into
>   cpu_supports_p2pdma(), next to the AMD check, as suggested by Logan
>   Gunthorpe and Leon Romanovsky [1]
> - Fold the VMware and Hyper-V patches into one, as the check no longer
>   depends on the hypervisor
> 
> Changes in v2:
> - Replace the Skylake-and-newer threshold with an explicit list of Intel
>   Xeon server generations, from Skylake-SP to Diamond Rapids (Logan
>   Gunthorpe)
> - Move the CONFIG_X86 #ifdef out of hypervisor_supports_p2pdma()
>   (Logan Gunthorpe)
> - Rebased on current mainline
> 
> [1] https://lore.kernel.org/r/20261016153147.GC219304@unreal
> 
> v3: https://lore.kernel.org/r/20261020151305.65218-1-
> pavel.e.popov@intel.com
> v2: https://lore.kernel.org/r/20261016223402.19991-1-
> pavel.e.popov@intel.com
> v1: https://lore.kernel.org/r/20261009154034.82321-1-
> pavel.e.popov@intel.com
> 
> Pavel Popov (2):
>   PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
>   PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs
> 
>  drivers/pci/p2pdma.c | 33 +++++++++++++++++++++++++++++++--
>  1 file changed, 31 insertions(+), 2 deletions(-)
> 
> 
> base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
> --
> 2.53.0

Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Leon Romanovsky]

On Wed, Nov 11, 2026 at 03:48:07AM +0000, Popov, Pavel E wrote:
> Hi Bjorn,
> 
> Gentle ping on this series. Is this OK for v7.5?

I would say no. An Intel employee was asked to clean up an Intel-created
mess while upstreaming an Intel-specific patch.

Peer-to-peer is a general concept, and the code should reflect that. It is
reasonable to expect you to join the effort and help clean it up.

Thanks

> 
> Thanks,
> Pavel
> 
> > -----Original Message-----
> > From: Popov, Pavel E <pavel.e.popov@intel.com>
> > Sent: Tuesday, October 20, 2026 10:38 AM
> > To: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> > <logang@deltatee.com>
> > Cc: Popov, Pavel E <pavel.e.popov@intel.com>; Leon Romanovsky
> > <leon@kernel.org>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> > <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> > Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> > <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> > Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> > list@broadcom.com; virtualization@lists.linux.dev; linux-
> > hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server
> > CPUs
> > 
> > VMware and Hyper-V expose passthrough devices to guest VMs without an
> > explicit host bridge device. Consequently, host_bridge_whitelist() cannot
> > automatically identify the underlying host bridge structure, causing Peer-to-
> > Peer DMA (P2PDMA) requests to be rejected unless the device IDs are
> > explicitly listed in pci_p2pdma_whitelist[]. To enable P2PDMA on Intel hosts,
> > this series extends cpu_supports_p2pdma(), which so far covers AMD Zen and
> > newer, with an explicit list of Intel Xeon server generations.
> > 
> > Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> > Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by carried over;
> > the Xeon list and the check are unchanged.
> > 
> > Changes in v4:
> > - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> >   (Logan Gunthorpe, Leon Romanovsky)
> > - Keep the #ifdef around the asm/ includes, as these headers exist
> >   only on x86 (Bjorn Helgaas)
> > 
> > Changes in v3:
> > - Drop the hypervisor check and move the Xeon list into
> >   cpu_supports_p2pdma(), next to the AMD check, as suggested by Logan
> >   Gunthorpe and Leon Romanovsky [1]
> > - Fold the VMware and Hyper-V patches into one, as the check no longer
> >   depends on the hypervisor
> > 
> > Changes in v2:
> > - Replace the Skylake-and-newer threshold with an explicit list of Intel
> >   Xeon server generations, from Skylake-SP to Diamond Rapids (Logan
> >   Gunthorpe)
> > - Move the CONFIG_X86 #ifdef out of hypervisor_supports_p2pdma()
> >   (Logan Gunthorpe)
> > - Rebased on current mainline
> > 
> > [1] https://lore.kernel.org/r/20261016153147.GC219304@unreal
> > 
> > v3: https://lore.kernel.org/r/20261020151305.65218-1-
> > pavel.e.popov@intel.com
> > v2: https://lore.kernel.org/r/20261016223402.19991-1-
> > pavel.e.popov@intel.com
> > v1: https://lore.kernel.org/r/20261009154034.82321-1-
> > pavel.e.popov@intel.com
> > 
> > Pavel Popov (2):
> >   PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> >   PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs
> > 
> >  drivers/pci/p2pdma.c | 33 +++++++++++++++++++++++++++++++--
> >  1 file changed, 31 insertions(+), 2 deletions(-)
> > 
> > 
> > base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
> > --
> > 2.53.0
> 

RE: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Popov, Pavel E]

On Wed, Nov 11, 2026 at 10:10:57AM +0200, Leon Romanovsky wrote:
> Peer-to-peer is a general concept, and the code should reflect that. It is
> reasonable to expect you to join the effort and help clean it up.

I'm in. My proposal is to do it after this series, since this one
unblocks P2PDMA in guests and the cleanup is out of PCI scope: even
the minimal fix for p2pdma.c alone means changes under arch/x86, so it
would no longer be a P2PDMA patch but an x86 header series with its
own maintainers and review. That x86 header series is also the right
place to drop the same guard from six other files, and I'm ready to
do it:

  drivers/acpi/mipi-disco-img.c
  drivers/cpufreq/cpufreq_ondemand.h
  drivers/gpu/drm/i915/intel_cpu_info.c
  drivers/char/tpm/tpm.h
  drivers/crypto/ccp/ccp-dev.c
  include/linux/platform_data/x86/soc.h

Bjorn, is v4 OK for v7.5 as is? The x86 header series will follow on
top.

Thanks,
Pavel

> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Wednesday, November 11, 2026 1:11 AM
> To: Popov, Pavel E <pavel.e.popov@intel.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> <logang@deltatee.com>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> list@broadcom.com; virtualization@lists.linux.dev; linux-
> hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> server CPUs
> 
> On Wed, Nov 11, 2026 at 03:48:07AM +0000, Popov, Pavel E wrote:
> > Hi Bjorn,
> >
> > Gentle ping on this series. Is this OK for v7.5?
> 
> I would say no. An Intel employee was asked to clean up an Intel-created mess
> while upstreaming an Intel-specific patch.
> 
> Peer-to-peer is a general concept, and the code should reflect that. It is
> reasonable to expect you to join the effort and help clean it up.
> 
> Thanks
> 
> >
> > Thanks,
> > Pavel
> >
> > > -----Original Message-----
> > > From: Popov, Pavel E <pavel.e.popov@intel.com>
> > > Sent: Tuesday, October 20, 2026 10:38 AM
> > > To: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> > > <logang@deltatee.com>
> > > Cc: Popov, Pavel E <pavel.e.popov@intel.com>; Leon Romanovsky
> > > <leon@kernel.org>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> > > <jim.chow@broadcom.com>; Radu Rugina
> <radu.rugina@broadcom.com>;
> > > Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> > > <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> > > Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> > > list@broadcom.com; virtualization@lists.linux.dev; linux-
> > > hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > > kernel@vger.kernel.org
> > > Subject: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> > > server CPUs
> > >
> > > VMware and Hyper-V expose passthrough devices to guest VMs without
> > > an explicit host bridge device. Consequently,
> > > host_bridge_whitelist() cannot automatically identify the underlying
> > > host bridge structure, causing Peer-to- Peer DMA (P2PDMA) requests
> > > to be rejected unless the device IDs are explicitly listed in
> > > pci_p2pdma_whitelist[]. To enable P2PDMA on Intel hosts, this series
> > > extends cpu_supports_p2pdma(), which so far covers AMD Zen and
> newer, with an explicit list of Intel Xeon server generations.
> > >
> > > Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> > > Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by
> > > carried over; the Xeon list and the check are unchanged.
> > >
> > > Changes in v4:
> > > - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> > >   (Logan Gunthorpe, Leon Romanovsky)
> > > - Keep the #ifdef around the asm/ includes, as these headers exist
> > >   only on x86 (Bjorn Helgaas)
> > >
> > > Changes in v3:
> > > - Drop the hypervisor check and move the Xeon list into
> > >   cpu_supports_p2pdma(), next to the AMD check, as suggested by Logan
> > >   Gunthorpe and Leon Romanovsky [1]
> > > - Fold the VMware and Hyper-V patches into one, as the check no longer
> > >   depends on the hypervisor
> > >
> > > Changes in v2:
> > > - Replace the Skylake-and-newer threshold with an explicit list of Intel
> > >   Xeon server generations, from Skylake-SP to Diamond Rapids (Logan
> > >   Gunthorpe)
> > > - Move the CONFIG_X86 #ifdef out of hypervisor_supports_p2pdma()
> > >   (Logan Gunthorpe)
> > > - Rebased on current mainline
> > >
> > > [1] https://lore.kernel.org/r/20261016153147.GC219304@unreal
> > >
> > > v3: https://lore.kernel.org/r/20261020151305.65218-1-
> > > pavel.e.popov@intel.com
> > > v2: https://lore.kernel.org/r/20261016223402.19991-1-
> > > pavel.e.popov@intel.com
> > > v1: https://lore.kernel.org/r/20261009154034.82321-1-
> > > pavel.e.popov@intel.com
> > >
> > > Pavel Popov (2):
> > >   PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> > >   PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs
> > >
> > >  drivers/pci/p2pdma.c | 33 +++++++++++++++++++++++++++++++--
> > >  1 file changed, 31 insertions(+), 2 deletions(-)
> > >
> > >
> > > base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
> > > --
> > > 2.53.0
> >

Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs

[Leon Romanovsky]

On Wed, Nov 11, 2026 at 03:37:13PM +0000, Popov, Pavel E wrote:
> On Wed, Nov 11, 2026 at 10:10:57AM +0200, Leon Romanovsky wrote:
> > Peer-to-peer is a general concept, and the code should reflect that. It is
> > reasonable to expect you to join the effort and help clean it up.
> 
> I'm in. My proposal is to do it after this series, since this one
> unblocks P2PDMA in guests and the cleanup is out of PCI scope: even
> the minimal fix for p2pdma.c alone means changes under arch/x86, so it
> would no longer be a P2PDMA patch but an x86 header series with its
> own maintainers and review. That x86 header series is also the right
> place to drop the same guard from six other files, and I'm ready to
> do it:

If you are ready, why hasn't it been done until now?

The claims of urgency are hard to take seriously: `SKYLAKE_X` was added to
`arch/x86/include/asm/intel-family.h` in 2016, and now, ten years later,
you are asking us to "do it urgently." I strongly suspect that if I don't
bring up P2P at LPC, we won't see this patch for another ten years.

Even now, despite being asked to clean this up before the merge
window, you still haven't done so. Trust is built by following
through, not by making promises.

> 
>   drivers/acpi/mipi-disco-img.c
>   drivers/cpufreq/cpufreq_ondemand.h
>   drivers/gpu/drm/i915/intel_cpu_info.c
>   drivers/char/tpm/tpm.h
>   drivers/crypto/ccp/ccp-dev.c
>   include/linux/platform_data/x86/soc.h
> 
> Bjorn, is v4 OK for v7.5 as is? The x86 header series will follow on
> top.

I disagree. You can't build this on top, as it would need to go through
different trees and would likely cause merge conflicts. The cleanup series
would have to touch the same lines in the PCI subsystem that you are
changing now.

The only sane approach is to do the cleanup first and then build the p2p
changes on top of it.

Thanks

> 
> Thanks,
> Pavel
> 
> > -----Original Message-----
> > From: Leon Romanovsky <leon@kernel.org>
> > Sent: Wednesday, November 11, 2026 1:11 AM
> > To: Popov, Pavel E <pavel.e.popov@intel.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> > <logang@deltatee.com>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> > <jim.chow@broadcom.com>; Radu Rugina <radu.rugina@broadcom.com>;
> > Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> > <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> > Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> > list@broadcom.com; virtualization@lists.linux.dev; linux-
> > hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > kernel@vger.kernel.org
> > Subject: Re: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> > server CPUs
> > 
> > On Wed, Nov 11, 2026 at 03:48:07AM +0000, Popov, Pavel E wrote:
> > > Hi Bjorn,
> > >
> > > Gentle ping on this series. Is this OK for v7.5?
> > 
> > I would say no. An Intel employee was asked to clean up an Intel-created mess
> > while upstreaming an Intel-specific patch.
> > 
> > Peer-to-peer is a general concept, and the code should reflect that. It is
> > reasonable to expect you to join the effort and help clean it up.
> > 
> > Thanks
> > 
> > >
> > > Thanks,
> > > Pavel
> > >
> > > > -----Original Message-----
> > > > From: Popov, Pavel E <pavel.e.popov@intel.com>
> > > > Sent: Tuesday, October 20, 2026 10:38 AM
> > > > To: Bjorn Helgaas <bhelgaas@google.com>; Logan Gunthorpe
> > > > <logang@deltatee.com>
> > > > Cc: Popov, Pavel E <pavel.e.popov@intel.com>; Leon Romanovsky
> > > > <leon@kernel.org>; Lukas Wunner <lukas@wunner.de>; Jim Chow
> > > > <jim.chow@broadcom.com>; Radu Rugina
> > <radu.rugina@broadcom.com>;
> > > > Alexey Makhalov <alexey.makhalov@broadcom.com>; Wei Liu
> > > > <wei.liu@kernel.org>; Michael Kelley <mhklinux@outlook.com>; Nathan
> > > > Ciobanu <nathan.d.ciobanu@linux.intel.com>; bcm-kernel-feedback-
> > > > list@broadcom.com; virtualization@lists.linux.dev; linux-
> > > > hyperv@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> > > > kernel@vger.kernel.org
> > > > Subject: [PATCH v4 0/2] PCI/P2PDMA: Allow P2PDMA on Intel Xeon
> > > > server CPUs
> > > >
> > > > VMware and Hyper-V expose passthrough devices to guest VMs without
> > > > an explicit host bridge device. Consequently,
> > > > host_bridge_whitelist() cannot automatically identify the underlying
> > > > host bridge structure, causing Peer-to- Peer DMA (P2PDMA) requests
> > > > to be rejected unless the device IDs are explicitly listed in
> > > > pci_p2pdma_whitelist[]. To enable P2PDMA on Intel hosts, this series
> > > > extends cpu_supports_p2pdma(), which so far covers AMD Zen and
> > newer, with an explicit list of Intel Xeon server generations.
> > > >
> > > > Patch 1 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma().
> > > > Patch 2 is the v3 patch rebased on it, with Logan's Reviewed-by
> > > > carried over; the Xeon list and the check are unchanged.
> > > >
> > > > Changes in v4:
> > > > - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> > > >   (Logan Gunthorpe, Leon Romanovsky)
> > > > - Keep the #ifdef around the asm/ includes, as these headers exist
> > > >   only on x86 (Bjorn Helgaas)
> > > >
> > > > Changes in v3:
> > > > - Drop the hypervisor check and move the Xeon list into
> > > >   cpu_supports_p2pdma(), next to the AMD check, as suggested by Logan
> > > >   Gunthorpe and Leon Romanovsky [1]
> > > > - Fold the VMware and Hyper-V patches into one, as the check no longer
> > > >   depends on the hypervisor
> > > >
> > > > Changes in v2:
> > > > - Replace the Skylake-and-newer threshold with an explicit list of Intel
> > > >   Xeon server generations, from Skylake-SP to Diamond Rapids (Logan
> > > >   Gunthorpe)
> > > > - Move the CONFIG_X86 #ifdef out of hypervisor_supports_p2pdma()
> > > >   (Logan Gunthorpe)
> > > > - Rebased on current mainline
> > > >
> > > > [1] https://lore.kernel.org/r/20261016153147.GC219304@unreal
> > > >
> > > > v3: https://lore.kernel.org/r/20261020151305.65218-1-
> > > > pavel.e.popov@intel.com
> > > > v2: https://lore.kernel.org/r/20261016223402.19991-1-
> > > > pavel.e.popov@intel.com
> > > > v1: https://lore.kernel.org/r/20261009154034.82321-1-
> > > > pavel.e.popov@intel.com
> > > >
> > > > Pavel Popov (2):
> > > >   PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> > > >   PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs
> > > >
> > > >  drivers/pci/p2pdma.c | 33 +++++++++++++++++++++++++++++++--
> > > >  1 file changed, 31 insertions(+), 2 deletions(-)
> > > >
> > > >
> > > > base-commit: c03c1a14507dfaf8b856c2608f9ac216021fc222
> > > > --
> > > > 2.53.0
> > >
>