* [PATCH] iio: pressure: dps310: don't wait for new temperature in trigger handler
@ 2026-11-11 19:51 Rupesh Majhi
0 siblings, 0 replies; only message in thread
From: Rupesh Majhi @ 2026-11-11 19:51 UTC (permalink / raw)
To: Andy Shevchenko, David Lechner, Eddie James, Jonathan Cameron,
Nuno Sá,
Rupesh Majhi
Cc: Jonathan Cameron, linux-iio, linux-kernel, Sashiko
Each scan waits for a new temperature result before reading pressure.
With pressure sampled faster than temperature, scans then come at the
temperature rate: an 8 Hz trigger with temperature at its default 1 Hz
gives one scan a second.
Read pressure first and take the latest temperature, as a direct
pressure read already does. Wait for temperature only when pressure is
not in the scan.
Fixes: 9b7cad9ce2ed ("iio: pressure: dps310: add triggered buffer support")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://sashiko.dev/#/patchset/20261110154254.39092-1-zoone.rupert%40gmail.com
Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
---
drivers/iio/pressure/dps310.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c
index 85df58ac1809..c4d779f8bbc6 100644
--- a/drivers/iio/pressure/dps310.c
+++ b/drivers/iio/pressure/dps310.c
@@ -910,10 +910,18 @@ static int dps310_fill_channels(struct dps310_data *data,
unsigned int i;
int rc;
- /* Compensation needs a temperature, so it is sampled either way */
- rc = dps310_read_temp_raw_locked(data);
- if (rc)
- return rc;
+ if (test_bit(DPS310_SCAN_PRESSURE, scan_mask)) {
+ rc = dps310_read_pres_raw_locked(data);
+ if (rc)
+ return rc;
+
+ /* Waiting here would hold scans to the temperature rate */
+ dps310_refresh_temp_locked(data);
+ } else {
+ rc = dps310_read_temp_raw_locked(data);
+ if (rc)
+ return rc;
+ }
i = 0;
if (test_bit(DPS310_SCAN_TEMP, scan_mask)) {
@@ -924,10 +932,6 @@ static int dps310_fill_channels(struct dps310_data *data,
}
if (test_bit(DPS310_SCAN_PRESSURE, scan_mask)) {
- rc = dps310_read_pres_raw_locked(data);
- if (rc)
- return rc;
-
/* Pascals, see the channel definition */
rc = dps310_calculate_pressure(data, &channels[i++]);
if (rc)
base-commit: 79c8dffd84e9784ec05bea68dbe5e71f7ec9941a
--
2.43.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-11 19:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 19:51 [PATCH] iio: pressure: dps310: don't wait for new temperature in trigger handler Rupesh Majhi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®