* [PATCH] staging: media: atomisp: Remove unneeded return statements in irq.c
@ 2026-11-12 1:10 Hezekiah Mogere Joseph Mayaka
0 siblings, 0 replies; only message in thread
From: Hezekiah Mogere Joseph Mayaka @ 2026-11-12 1:10 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: Sakari Ailus, Andy Shevchenko, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel, Hezekiah Mogere Joseph Mayaka
Remove the bare return statements at the end of void functions, along
with the blank lines before them. They have no effect and checkpatch.pl
warns about them:
WARNING: void function return statements are not generally useful
Signed-off-by: Hezekiah Mogere Joseph Mayaka <hmjm081106@gmail.com>
---
.../media/atomisp/pci/hive_isp_css_common/host/irq.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
index 61dea386361a..6ca8fcd61b36 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c
@@ -60,7 +60,6 @@ void irq_clear_all(
irq_reg_store(ID,
_HRT_IRQ_CONTROLLER_CLEAR_REG_IDX, mask);
- return;
}
/*
@@ -104,8 +103,6 @@ void irq_enable_channel(
_HRT_IRQ_CONTROLLER_MASK_REG_IDX, mask);
irq_wait_for_write_complete(ID);
-
- return;
}
void irq_enable_pulse(
@@ -120,7 +117,6 @@ void irq_enable_pulse(
/* output is given as edge, not pulse */
irq_reg_store(ID,
_HRT_IRQ_CONTROLLER_EDGE_NOT_PULSE_REG_IDX, edge_out);
- return;
}
void irq_disable_channel(
@@ -150,8 +146,6 @@ void irq_disable_channel(
_HRT_IRQ_CONTROLLER_CLEAR_REG_IDX, me);
irq_wait_for_write_complete(ID);
-
- return;
}
enum hrt_isp_css_irq_status irq_get_channel_id(
@@ -212,7 +206,6 @@ void irq_raise(
(unsigned int)addr, 1);
gp_device_reg_store(GP_DEVICE0_ID,
(unsigned int)addr, 0);
- return;
}
bool any_virq_signal(void)
@@ -251,7 +244,6 @@ void cnd_virq_enable_channel(
irq_disable_channel(IRQ0_ID, IRQ_NESTING_ID[ID]);
}
}
- return;
}
void virq_clear_all(void)
@@ -260,8 +252,6 @@ void virq_clear_all(void)
for (irq_id = (irq_ID_t)0; irq_id < N_IRQ_ID; irq_id++)
irq_clear_all(irq_id);
-
- return;
}
enum hrt_isp_css_irq_status
@@ -302,8 +292,6 @@ void virq_clear_info(struct virq_info *irq_info)
for (ID = (irq_ID_t)0 ; ID < N_IRQ_ID; ID++)
irq_info->irq_status_reg[ID] = 0;
-
- return;
}
enum hrt_isp_css_irq_status virq_get_channel_id(
--
2.56.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-12 1:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-12 1:10 [PATCH] staging: media: atomisp: Remove unneeded return statements in irq.c Hezekiah Mogere Joseph Mayaka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®