Re: [PATCH] pinctrl: amd: Steer GPIO interrupt to low power/efficiency cores

[kernel test robot <lkp@intel.com>]

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on 7475ea8b58616b33c04afb976cf0fbaad9dd63fb]

url:    https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/pinctrl-amd-Steer-GPIO-interrupt-to-low-power-efficiency-cores/20261111-100708
base:   7475ea8b58616b33c04afb976cf0fbaad9dd63fb
patch link:    https://lore.kernel.org/r/20261111-superm1-pinctrl-power-improvement-v1-1-4bbe6cdbd2e8%40amd.com
patch subject: [PATCH] pinctrl: amd: Steer GPIO interrupt to low power/efficiency cores
config: um-randconfig-1000-20261112 (https://download.01.org/0day-ci/archive/20261112/202611120840.VN9Z8N3s-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261112/202611120840.VN9Z8N3s-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611120840.VN9Z8N3s-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/pinctrl/pinctrl-amd.c:20:
   In file included from include/linux/io.h:12:
   In file included from arch/um/include/asm/io.h:24:
   include/asm-generic/io.h:1209:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
    1209 |         return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
         |                                                   ~~~~~~~~~~ ^
>> drivers/pinctrl/pinctrl-amd.c:1285:47: error: array has incomplete element type 'const enum x86_topology_cpu_type'
    1285 |         static const enum x86_topology_cpu_type types[] = {
         |                                                      ^
   drivers/pinctrl/pinctrl-amd.c:1285:20: note: forward declaration of 'enum x86_topology_cpu_type'
    1285 |         static const enum x86_topology_cpu_type types[] = {
         |                           ^
>> drivers/pinctrl/pinctrl-amd.c:1286:3: error: use of undeclared identifier 'TOPO_CPU_TYPE_LOW_POWER'
    1286 |                 TOPO_CPU_TYPE_LOW_POWER,
         |                 ^
>> drivers/pinctrl/pinctrl-amd.c:1287:3: error: use of undeclared identifier 'TOPO_CPU_TYPE_EFFICIENCY'
    1287 |                 TOPO_CPU_TYPE_EFFICIENCY,
         |                 ^
>> drivers/pinctrl/pinctrl-amd.c:1297:8: error: call to undeclared function 'cpu_data'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1297 |                         if (cpu_data(cpu).topo.cpu_type == types[i])
         |                             ^
>> drivers/pinctrl/pinctrl-amd.c:1297:21: error: member reference base type 'int' is not a structure or union
    1297 |                         if (cpu_data(cpu).topo.cpu_type == types[i])
         |                             ~~~~~~~~~~~~~^~~~~
   1 warning and 5 errors generated.


vim +1285 drivers/pinctrl/pinctrl-amd.c

  1276	
  1277	#ifdef CONFIG_X86_64
  1278	/*
  1279	 * On hybrid systems prefer to service the GPIO interrupt on low power cores,
  1280	 * then on efficiency (dense) cores to save power.  Userspace can still
  1281	 * override the placement.  Do nothing if neither core type exists.
  1282	 */
  1283	static void amd_gpio_set_irq_affinity(struct amd_gpio *gpio_dev)
  1284	{
> 1285		static const enum x86_topology_cpu_type types[] = {
> 1286			TOPO_CPU_TYPE_LOW_POWER,
> 1287			TOPO_CPU_TYPE_EFFICIENCY,
  1288		};
  1289		cpumask_var_t mask;
  1290		int cpu, i;
  1291	
  1292		if (!zalloc_cpumask_var(&mask, GFP_KERNEL))
  1293			return;
  1294	
  1295		for (i = 0; i < ARRAY_SIZE(types); i++) {
  1296			for_each_possible_cpu(cpu) {
> 1297				if (cpu_data(cpu).topo.cpu_type == types[i])
  1298					cpumask_set_cpu(cpu, mask);
  1299			}
  1300			if (!cpumask_empty(mask)) {
  1301				irq_set_affinity(gpio_dev->irq, mask);
  1302				break;
  1303			}
  1304		}
  1305	
  1306		free_cpumask_var(mask);
  1307	}
  1308	#else
  1309	static void amd_gpio_set_irq_affinity(struct amd_gpio *gpio_dev) {}
  1310	#endif
  1311	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki