mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency
@ 2026-11-12 13:32 Arnd Bergmann
  2026-11-12 14:06 ` Philipp Zabel
  2026-11-12 14:25 ` Philipp Zabel
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2026-11-12 13:32 UTC (permalink / raw)
  To: Philipp Zabel, Biju Das
  Cc: Arnd Bergmann, Brian Masney, Tommaso Merciai, Xuyang Dong,
	Drew Fustini, Junhui Liu, Guodong Xu, Joakim Zhang,
	Anirudh Srinivasan, Sven Peter, Benoît Monin, Robert Marko,
	linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The dependency on CONFIG_POWER_SEQUENCING is ignored when
ARCH_RZG2L is enabled, and this can lead to a build failure
when power sequencing is in a loadable module but the
reset driver is built-in:

drivers/reset/reset-rzg2l-usbphy-ctrl.o: in function `rzg2l_usbphy_ctrl_suspend':
reset-rzg2l-usbphy-ctrl.c:(.text+0x21c): undefined reference to `pwrseq_disable'

Change the dependency to always depend on the power sequencing
interface.

Fixes: 5ca65d048910 ("reset: rzg2l-usbphy-ctrl: Add RZ/G3L support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/reset/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index c63e26f0ac47..acebf03d3da7 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -279,7 +279,8 @@ config RESET_RASPBERRYPI
 
 config RESET_RZG2L_USBPHY_CTRL
 	tristate "Renesas RZ/G2L USBPHY control driver"
-	depends on ARCH_RZG2L || (COMPILE_TEST && POWER_SEQUENCING)
+	depends on ARCH_RZG2L || COMPILE_TEST
+	depends on POWER_SEQUENCING
 	select MFD_SYSCON
 	help
 	  Support for USBPHY Control found on RZ/G2L family. It mainly
-- 
2.53.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency
  2026-11-12 13:32 [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency Arnd Bergmann
@ 2026-11-12 14:06 ` Philipp Zabel
  2026-11-12 14:25 ` Philipp Zabel
  1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2026-11-12 14:06 UTC (permalink / raw)
  To: Arnd Bergmann, Biju Das
  Cc: Arnd Bergmann, Brian Masney, Tommaso Merciai, Xuyang Dong,
	Drew Fustini, Junhui Liu, Guodong Xu, Joakim Zhang,
	Anirudh Srinivasan, Sven Peter, Benoît Monin, Robert Marko,
	linux-kernel

On Do, 2026-11-12 at 14:32 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The dependency on CONFIG_POWER_SEQUENCING is ignored when
> ARCH_RZG2L is enabled, and this can lead to a build failure
> when power sequencing is in a loadable module but the
> reset driver is built-in:
> 
> drivers/reset/reset-rzg2l-usbphy-ctrl.o: in function `rzg2l_usbphy_ctrl_suspend':
> reset-rzg2l-usbphy-ctrl.c:(.text+0x21c): undefined reference to `pwrseq_disable'
> 
> Change the dependency to always depend on the power sequencing
> interface.
> 
> Fixes: 5ca65d048910 ("reset: rzg2l-usbphy-ctrl: Add RZ/G3L support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency
  2026-11-12 13:32 [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency Arnd Bergmann
  2026-11-12 14:06 ` Philipp Zabel
@ 2026-11-12 14:25 ` Philipp Zabel
  1 sibling, 0 replies; 3+ messages in thread
From: Philipp Zabel @ 2026-11-12 14:25 UTC (permalink / raw)
  To: Arnd Bergmann, Biju Das
  Cc: Arnd Bergmann, Brian Masney, Tommaso Merciai, Xuyang Dong,
	Drew Fustini, Junhui Liu, Guodong Xu, Joakim Zhang,
	Anirudh Srinivasan, Sven Peter, Benoît Monin, Robert Marko,
	linux-kernel

On Do, 2026-11-12 at 14:32 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The dependency on CONFIG_POWER_SEQUENCING is ignored when
> ARCH_RZG2L is enabled, and this can lead to a build failure
> when power sequencing is in a loadable module but the
> reset driver is built-in:
> 
> [...]

Applied to reset/next, thanks!

[1/1] reset: rzg2l-usbphy-ctrl: add power sequencing dependency
      https://git.kernel.org/pub/scm/linux/kernel/git/pza/linux.git/commit/?id=eac3b292a26e

regards
Philipp

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-12 14:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-12 13:32 [PATCH] reset: rzg2l-usbphy-ctrl: add power sequencing dependency Arnd Bergmann
2026-11-12 14:06 ` Philipp Zabel
2026-11-12 14:25 ` Philipp Zabel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®