From: Chris Down <chris@chrisdown.name>
To: Petr Mladek <pmladek@suse.com>
Cc: John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Marcos Paulo de Souza <mpdesouza@suse.com>,
Naveen Kumar Chaudhary <naveen.osdev@gmail.com>,
printk@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 07/17] printk: Check that index is not defined when a console is preferred via devname
Date: Thu, 12 Nov 2026 15:04:41 -0800 [thread overview]
Message-ID: <20261112150441.4fbbb20509665746@chrisdown.name> (raw)
In-Reply-To: <20261111154816.71103-8-pmladek@suse.com>
Hi Petr,
Petr Mladek writes:
>- * 2. Either @name OR @devname are allowed. [*]
>+ * 2. Either @name and valid @idx OR @devname and @idx=-1 are allowed. [*]
The check below now rejects only idx >= 0 for @devname, so this could say
"negative @idx" instead of "@idx=-1" to match it.
With that (fine to do when applying):
Reviewed-by: Chris Down <chris@chrisdown.name>
Chris
next prev parent reply other threads:[~2026-11-12 23:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 15:47 [PATCH v7 00/17] printk: Clean up preferred console handling Petr Mladek
2026-11-11 15:48 ` [PATCH v7 01/17] printk: Rename struct console_cmdline to preferred_console Petr Mladek
2026-11-11 15:48 ` [PATCH v7 02/17] printk: Rename preferred_console to preferred_dev_console Petr Mladek
2026-11-11 15:48 ` [PATCH v7 03/17] printk: Cleanup _braille_(un)register_console() wrappers Petr Mladek
2026-11-11 15:48 ` [PATCH v7 04/17] printk: Separate code for adding/updating preferred console metadata Petr Mladek
2026-11-12 23:04 ` Chris Down
2026-11-11 15:48 ` [PATCH v7 05/17] printk: Do not accept an empty name or devname as a preferred console Petr Mladek
2026-11-12 23:04 ` Chris Down
2026-11-11 15:48 ` [PATCH v7 06/17] printk: Prefer the console either via name or devname exclusively Petr Mladek
2026-11-12 23:04 ` Chris Down
2026-11-11 15:48 ` [PATCH v7 07/17] printk: Check that index is not defined when a console is preferred via devname Petr Mladek
2026-11-12 23:04 ` Chris Down [this message]
2026-11-11 15:48 ` [PATCH v7 08/17] printk: Ensure consistent name and devname when updating preferred console Petr Mladek
2026-11-12 23:04 ` Chris Down
2026-11-11 15:48 ` [PATCH v7 09/17] printk: Do not quietly ignore adding entry for a preferred console when there is no space Petr Mladek
2026-11-11 15:48 ` [PATCH v7 10/17] printk: Allow to debug misuse of add_or_update_preferred_console() Petr Mladek
2026-11-11 15:48 ` [PATCH v7 11/17] console/braille: Lock console->setup() call during the registration Petr Mladek
2026-11-11 15:48 ` [PATCH v7 12/17] printk: Separate code for enabling console Petr Mladek
2026-11-11 15:48 ` [PATCH v7 13/17] printk: Try to register each console as Braille first Petr Mladek
2026-11-11 15:48 ` [PATCH v7 14/17] printk: Update Braille options when preferred more times Petr Mladek
2026-11-12 23:04 ` Chris Down
2026-11-11 15:48 ` [PATCH v7 15/17] printk: Do not set Braille console as preferred_console Petr Mladek
2026-11-11 15:48 ` [PATCH v7 16/17] printk: Modify try_enable_default_console() to return error/success Petr Mladek
2026-11-11 15:48 ` [PATCH v7 17/17] printk: Try enable preferred consoles only when there are any Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261112150441.4fbbb20509665746@chrisdown.name \
--to=chris@chrisdown.name \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=naveen.osdev@gmail.com \
--cc=pmladek@suse.com \
--cc=printk@lists.linux.dev \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®