Re: [PATCH] serial: sc16is7xx: Fix clock leak on invalid clock frequency

[Hugo Villeneuve <hugo@hugovil.com>]

Hi,

On Thu, 12 Nov 2026 10:13:34 +0800
Xiangwu Lai <laixiangwu@cmss.chinamobile.com> wrote:

> Hi Greg,
> 
> sorry for the missing context.  The patch I was pinging is:
> 
>   serial: sc16is7xx: Fix clock leak on invalid clock frequency
>   https://lore.kernel.org/all/20261030085508.1882-1-laixiangwu@cmss.chinamobile.com/
> 
> sc16is7xx_probe() enables the clock with clk_prepare_enable() early
> in the probe path.  If the clock frequency cannot be determined
> (neither from the clock itself, nor from the "clock-frequency"
> property or platform data), the driver bails out with -EINVAL
> without disabling the clock again, while the later error paths of
> the probe already jump to the out_clk label.  The patch makes this
> error path jump to out_clk as well, so the clock is disabled like
> on the other error paths.

It is better to simply reply to the original email, to have the full
context, without having to click on a link to see the original message.

> 
> It was submitted on Oct 30.  Is there anything blocking it, or does
> it just need more time?

I'll reply in the original email...

-- 
Hugo Villeneuve