From: Hugo Villeneuve <hugo@hugovil.com>
To: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: Fix clock leak on invalid clock frequency
Date: Fri, 13 Nov 2026 11:58:23 -0500 [thread overview]
Message-ID: <20261113115823.68e12fc677c8e0f5f166e593@hugovil.com> (raw)
In-Reply-To: <20261113103755.2126-1-laixiangwu@cmss.chinamobile.com>
Hi Xiangwu,
On Fri, 13 Nov 2026 18:37:54 +0800
Xiangwu Lai <laixiangwu@cmss.chinamobile.com> wrote:
> Hi Hugo,
>
> thanks for the review!
>
> Agreed, devm_clk_get_optional_enabled() is the cleaner way: the clock
> reference is dropped and the clock disabled automatically on probe
> failure and on remove, so the manual management, the out_clk label
> and the clk_disable_unprepare() in sc16is7xx_remove() all go away,
> and the -EINVAL path keeps its original plain return.
>
> I've reworked the patch accordingly; v2 follows shortly.
>
> Best regards,
> Xiangwu Lai
Great.
But once again, there is no context as you didn't reply to the original
email.
Please always reply to the original email.
--
Hugo Villeneuve
prev parent reply other threads:[~2026-11-13 16:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 8:55 laixiangwu
2026-11-11 9:52 ` Xiangwu Lai
2026-11-11 13:16 ` Greg Kroah-Hartman
2026-11-12 2:13 ` Xiangwu Lai
2026-11-12 21:33 ` Hugo Villeneuve
2026-11-12 21:39 ` Hugo Villeneuve
2026-11-13 10:37 ` Xiangwu Lai
2026-11-13 16:58 ` Hugo Villeneuve [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113115823.68e12fc677c8e0f5f166e593@hugovil.com \
--to=hugo@hugovil.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=laixiangwu@cmss.chinamobile.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®