mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	 Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Christophe Roullier <christophe.roullier@foss.st.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	 linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: clock: Add STM32MP25 SYSCFG clock controller
Date: Fri, 13 Nov 2026 09:22:31 +0100	[thread overview]
Message-ID: <20261113-charming-admirable-pronghorn-bdc26c@quoll> (raw)
In-Reply-To: <20261110-ups_mp25_clk_syscfg-v2-1-624559bb8ec7@foss.st.com>

On Tue, Nov 10, 2026 at 02:10:21PM +0100, Gabriel Fernandez wrote:
> The SYSCFG of the STM32MP23x and STM32MP25x SoCs selects the LTDC pixel
> clock among the LTDC kernel clock, the LVDS PHY pixel clock and the DSI
> PHY byte lane clock.
> 
> Add the binding for this clock controller, described as a
> clock-controller sub-node of the SYSCFG node, along with the header
> defining the identifiers of the provided clocks.
> 
> A sub-node is needed since the inputs of the mux can't be described by
> the "clocks" property of the SYSCFG node: the SYSCFG is a syscon, whose
> first clock is taken as the clock of its registers and enabled around
> each register access.
> 
> The inputs are listed in the "ltdc", "lvds", "dsi" order so that the
> ones missing on a SoC (no LVDS nor DSI on STM32MP231/233 and
> STM32MP251/253) can be omitted at the end of the list. "#clock-cells"
> is 1 so that the other clocks of the SYSCFG can be added later without
> changing the binding.
> 
> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> ---
>  .../bindings/clock/st,stm32mp25-syscfg-clk.yaml    | 61 ++++++++++++++++++++++
>  .../dt-bindings/clock/st,stm32mp25-syscfg-clk.h    | 12 +++++
>  2 files changed, 73 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml b/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml
> new file mode 100644
> index 000000000000..027d14f28b0c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/st,stm32mp25-syscfg-clk.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/st,stm32mp25-syscfg-clk.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32MP2 SYSCFG clock controller
> +
> +maintainers:
> +  - Gabriel Fernandez <gabriel.fernandez@foss.st.com>
> +
> +description: |
> +  The SYSCFG of the STM32MP23x and STM32MP25x SoCs provides clocks, described
> +  by a clock controller sub-node of the SYSCFG node.
> +
> +  The provided clocks are identified by the macros defined in
> +  include/dt-bindings/clock/st,stm32mp25-syscfg-clk.h:
> +    - CK_SYSCFG_PIX_LTDC: LTDC pixel clock, selected in the DISPLAYCLKCR
> +      register among the LTDC kernel clock, used by the RGB parallel output,
> +      the LVDS PHY pixel clock and the DSI PHY byte lane clock.
> +
> +properties:
> +  compatible:
> +    const: st,stm32mp25-syscfg-clk
> +
> +  "#clock-cells":
> +    const: 1

So you have 1 clock, thus drop the header and here you have cells=0.
> +
> +  clocks:
> +    minItems: 1

Why is this flexible? Device either has or has not these inputs.

> +    items:
> +      - description: LTDC kernel clock
> +      - description: LVDS PHY pixel clock
> +      - description: DSI PHY byte lane clock
> +
> +  clock-names:
> +    minItems: 1
> +    items:
> +      - const: ltdc
> +      - const: lvds
> +      - const: dsi
> +
> +required:
> +  - compatible
> +  - "#clock-cells"
> +  - clocks
> +  - clock-names

Best regards,
Krzysztof


  reply	other threads:[~2026-11-13  8:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 13:10 [PATCH v2 0/5] clk: stm32: Add the STM32MP2 SYSCFG LTDC pixel clock mux Gabriel Fernandez
2026-11-10 13:10 ` [PATCH v2 1/5] dt-bindings: clock: Add STM32MP25 SYSCFG clock controller Gabriel Fernandez
2026-11-13  8:22   ` Krzysztof Kozlowski [this message]
2026-11-18 12:17     ` Gabriel FERNANDEZ
2026-11-10 13:10 ` [PATCH v2 2/5] dt-bindings: arm: stm32: Add clock-controller sub-node to STM32MP2 SYSCFG Gabriel Fernandez
2026-11-13  8:24   ` Krzysztof Kozlowski
2026-11-18 12:14     ` Gabriel FERNANDEZ
2026-11-10 13:10 ` [PATCH v2 3/5] clk: stm32: Add STM32MP25 SYSCFG clock driver Gabriel Fernandez
2026-11-12  0:44   ` Brian Masney
2026-11-13  6:36   ` Uwe Kleine-König
2026-11-10 13:10 ` [PATCH v2 4/5] arm64: dts: st: add LTDC pixel clock controller on stm32mp23 Gabriel Fernandez
2026-11-13  8:24   ` Krzysztof Kozlowski
2026-11-10 13:10 ` [PATCH v2 5/5] arm64: dts: st: add LTDC pixel clock controller on stm32mp25 Gabriel Fernandez
2026-11-13  8:25   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113-charming-admirable-pronghorn-bdc26c@quoll \
    --to=krzk@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bmasney+clk@redhat.com \
    --cc=christophe.roullier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gabriel.fernandez@foss.st.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®