mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gabriel FERNANDEZ <gabriel.fernandez@foss.st.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	<linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-stm32@st-md-mailman.stormreply.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: arm: stm32: Add clock-controller sub-node to STM32MP2 SYSCFG
Date: Wed, 18 Nov 2026 13:14:43 +0100	[thread overview]
Message-ID: <2aec79a0-54fc-4593-b4a9-7a2387f2c6c1@foss.st.com> (raw)
In-Reply-To: <20261113-honorable-competent-lynx-b1d5b8@quoll>

Hi Krzysztof,

On 11/13/26 09:24, Krzysztof Kozlowski wrote:
> On Tue, Nov 10, 2026 at 02:10:22PM +0100, Gabriel Fernandez wrote:
>> The SYSCFG of the STM32MP23x and STM32MP25x SoCs is described as the
>> provider of the LTDC pixel clock, but the inputs of this mux (LTDC
>> kernel clock, LVDS PHY pixel clock and DSI PHY byte lane clock) can't
>> be described by the "clocks" property of the SYSCFG node: the SYSCFG is
> Not true, you can.
>
>> a syscon, whose first clock is taken as the clock of its registers and
>> enabled around each register access.
> That's a driver problem, fix drivers.
>
>> Add a clock-controller sub-node to describe the mux with its own clock
>> inputs. It is required on STM32MP23x and STM32MP25x and not allowed on
>> the other SoCs.
>>
>> Deprecate the '#clock-cells' property of the SYSCFG node, which is no
>> longer required. No driver ever registered a clock on the SYSCFG node,
>> so this doesn't change anything for existing devicetrees.
>>
>> Signed-off-by: Gabriel Fernandez <gabriel.fernandez@foss.st.com>
>> ---
>>   .../devicetree/bindings/arm/stm32/st,stm32-syscon.yaml        | 11 ++++++++++-
>>   1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> index a559f8b03b84..13c02844a91f 100644
>> --- a/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> +++ b/Documentation/devicetree/bindings/arm/stm32/st,stm32-syscon.yaml
>> @@ -38,6 +38,10 @@ properties:
>>   
>>     "#clock-cells":
>>       const: 0
>> +    deprecated: true
>> +    description:
>> +      The LTDC pixel clock multiplexer is described by the clock-controller
>> +      sub-node.
>>   
>>     "#address-cells":
>>       const: 1
>> @@ -45,6 +49,10 @@ properties:
>>     "#size-cells":
>>       const: 1
>>   
>> +  clock-controller:
>> +    type: object
>> +    $ref: /schemas/clock/st,stm32mp25-syscfg-clk.yaml#
>> +
>>   patternProperties:
>>     "^phy@2[48]00$":
> As you can easily see, each child needs addressing. This is one more
> argument why this is a fake device split, done only to match your driver
> limitation. Please fix your drivers.
Agreed. Sorry, I sent v3 [1] before answering here.

v3 drops the clock-controller sub-node and its binding: the mux inputs
are described by the clocks/clock-names properties of the SYSCFG node,
which remains the clock provider. It also keeps '#clock-cells' in the
SoC devicetrees, as you requested on patches 4/5 and 5/5.

The drivers are fixed instead: the STM32MP2 SYSCFG driver creates the
SYSCFG regmap and registers it with of_syscon_register_regmap(), so the
syscon core no longer attaches the first clock of the node to it. The
clock driver is an auxiliary driver, whose device is created by the
SYSCFG driver.

[1] 
https://lore.kernel.org/r/20261118-ups_mp25_clk_syscfg-v3-0-935de791a4ce@foss.st.com

Best regards,

Gabriel


> Best regards,
> Krzysztof

  reply	other threads:[~2026-11-18 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 13:10 [PATCH v2 0/5] clk: stm32: Add the STM32MP2 SYSCFG LTDC pixel clock mux Gabriel Fernandez
2026-11-10 13:10 ` [PATCH v2 1/5] dt-bindings: clock: Add STM32MP25 SYSCFG clock controller Gabriel Fernandez
2026-11-13  8:22   ` Krzysztof Kozlowski
2026-11-18 12:17     ` Gabriel FERNANDEZ
2026-11-10 13:10 ` [PATCH v2 2/5] dt-bindings: arm: stm32: Add clock-controller sub-node to STM32MP2 SYSCFG Gabriel Fernandez
2026-11-13  8:24   ` Krzysztof Kozlowski
2026-11-18 12:14     ` Gabriel FERNANDEZ [this message]
2026-11-10 13:10 ` [PATCH v2 3/5] clk: stm32: Add STM32MP25 SYSCFG clock driver Gabriel Fernandez
2026-11-12  0:44   ` Brian Masney
2026-11-13  6:36   ` Uwe Kleine-König
2026-11-10 13:10 ` [PATCH v2 4/5] arm64: dts: st: add LTDC pixel clock controller on stm32mp23 Gabriel Fernandez
2026-11-13  8:24   ` Krzysztof Kozlowski
2026-11-10 13:10 ` [PATCH v2 5/5] arm64: dts: st: add LTDC pixel clock controller on stm32mp25 Gabriel Fernandez
2026-11-13  8:25   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2aec79a0-54fc-4593-b4a9-7a2387f2c6c1@foss.st.com \
    --to=gabriel.fernandez@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=bmasney+clk@redhat.com \
    --cc=christophe.roullier@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®