mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
Cc: David Rhodes <david.rhodes@cirrus.com>,
	 Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	 Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org,  patches@opensource.cirrus.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ASoC: dt-bindings: cs35l45: Adds ABPE properties
Date: Fri, 13 Nov 2026 11:41:39 +0100	[thread overview]
Message-ID: <20261113-handsome-original-shrimp-abfae3@quoll> (raw)
In-Reply-To: <20261109-cs35l45-bpe-v1-1-9d7bc95a90a4@opensource.cirrus.com>

On Mon, Nov 09, 2026 at 11:57:03AM -0600, Ricardo Rivera-Matos wrote:
> Adds devicetree properties to configure the amplifier brownout
> prevention engine (ABPE).
> 
> Signed-off-by: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
> ---
>  .../devicetree/bindings/sound/cirrus,cs35l45.yaml  | 161 +++++++++++++++++++++
>  1 file changed, 161 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> index e674811b22b2..2c118fa57ad1 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l45.yaml
> @@ -16,6 +16,62 @@ description: |
>  
>  allOf:
>    - $ref: dai-common.yaml#

Entire allOf goes to the bottom, before additional/unevaluatedProps

> +  - if:
> +      required:
> +        - cirrus,amplifier-bpe-enable
> +    then:
> +      required:
> +        - cirrus,amplifier-bpe-response-mode
> +        - cirrus,amplifier-bpe-thresholds-microvolt
> +        - cirrus,amplifier-bpe-attack-rates
> +        - cirrus,amplifier-bpe-hold-times-us

...

> +  cirrus,amplifier-bpe-attenuation-levels-db:
> +    description:
> +      Amplifier BPE logarithmic audio output attenuation for levels L3, L2,
> +      L1, L0, in whole dB steps. Half dB hardware settings are not
> +      supported.
> +    minItems: 4
> +    maxItems: 4
> +    items:
> +      minimum: 0
> +      maximum: 15
> +
> +  cirrus,amplifier-bpe-attenuation-levels-microvolt:
> +    description: |

Drop |, other places as well unless you need it.

> +      Amplifier BPE linear voltage audio output attenuation for levels L3,
> +      L2, L1, L0.
> +    minItems: 4
> +    maxItems: 4
> +    items:
> +      minimum: 187500
> +      maximum: 1000000
> +      multipleOf: 31250
> +

Best regards,
Krzysztof


  reply	other threads:[~2026-11-13 10:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 17:57 [PATCH 0/4] ASoC: cs35l45: Adds support for brownout prevention engines Ricardo Rivera-Matos via B4 Relay
2026-11-09 17:57 ` [PATCH 1/4] ASoC: dt-bindings: cs35l45: Adds ABPE properties Ricardo Rivera-Matos via B4 Relay
2026-11-13 10:41   ` Krzysztof Kozlowski [this message]
2026-11-13 16:31     ` Ricardo Rivera-Matos
2026-11-09 17:57 ` [PATCH 2/4] ASoC: cs35l45: Adds support for ABPE feature Ricardo Rivera-Matos via B4 Relay
2026-11-09 17:57 ` [PATCH 3/4] ASoC: dt-bindings: cs35l45: Adds Boost BPE properties Ricardo Rivera-Matos via B4 Relay
2026-11-09 17:57 ` [PATCH 4/4] ASoC: cs35l45: Adds Boost BPE configuration Ricardo Rivera-Matos via B4 Relay
2026-11-11 16:14 ` [PATCH 0/4] ASoC: cs35l45: Adds support for brownout prevention engines Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113-handsome-original-shrimp-abfae3@quoll \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david.rhodes@cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=robh@kernel.org \
    --cc=rriveram@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®