[PATCH 0/2] arm64: dts: qcom: Add MSM8996 SAW3 compatible

[PATCH 0/2] arm64: dts: qcom: Add MSM8996 SAW3 compatible

[Rob Herring (Arm)]

'syscon' nodes are required to have specific compatibles, but the 
MSM8996 SAW3 nodes are lacking one. This series adds one.

The binding should be applied with the dts changes to avoid new 
warnings.

Rob

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Rob Herring (Arm) (2):
      dt-bindings: mfd: syscon: Add MSM8996 SAW3 registers
      arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 arch/arm64/boot/dts/qcom/msm8996.dtsi             | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
---
base-commit: 6d582d78fad9d828e575ca0cdcff8ea47a77220b
change-id: 20261112-dtbs-qcom-5f2350f0cbec

Best regards,
--  
Rob Herring (Arm) <robh@kernel.org>

[PATCH 1/2] dt-bindings: mfd: syscon: Add MSM8996 SAW3 registers

[Rob Herring (Arm)]

Add a compatible for the MSM8996 SAW3 register bank referenced
through qcom,saw-reg properties. The name is based on the label in .dts
files.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index dae706ca7642..132a3374d14f 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -110,6 +110,7 @@ properties:
               - qcom,apq8064-mmss-sfpb
               - qcom,apq8064-sps-sic
               - qcom,msm8960-sps-sic
+              - qcom,msm8996-saw3
               - rockchip,px30-qos
               - rockchip,rk3036-qos
               - rockchip,rk3066-qos

-- 
2.53.0

Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add MSM8996 SAW3 registers

[Krzysztof Kozlowski]

On Thu, Nov 12, 2026 at 02:26:39PM -0600, Rob Herring (Arm) wrote:
> Add a compatible for the MSM8996 SAW3 register bank referenced
> through qcom,saw-reg properties. The name is based on the label in .dts
> files.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 2/2] arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

[Rob Herring (Arm)]

'syscon' nodes are required to have specific compatibles. Add
"qcom,msm8996-saw3" compatible to the MSM8996 SAW3 syscon block.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 1267c56d586b..4e8eb82420e2 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -3793,7 +3793,7 @@ frame@98c0000 {
 		};
 
 		saw3: syscon@9a10000 {
-			compatible = "syscon";
+			compatible = "qcom,msm8996-saw3", "syscon";
 			reg = <0x09a10000 0x1000>;
 		};
 

-- 
2.53.0

Re: [PATCH 2/2] arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

[Krzysztof Kozlowski]

On Thu, Nov 12, 2026 at 02:26:40PM -0600, Rob Herring (Arm) wrote:
> 'syscon' nodes are required to have specific compatibles. Add
> "qcom,msm8996-saw3" compatible to the MSM8996 SAW3 syscon block.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: Add MSM8996 SAW3 syscon compatible

[Dmitry Baryshkov]

On Thu, Nov 12, 2026 at 02:26:40PM -0600, Rob Herring (Arm) wrote:
> 'syscon' nodes are required to have specific compatibles. Add
> "qcom,msm8996-saw3" compatible to the MSM8996 SAW3 syscon block.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index 1267c56d586b..4e8eb82420e2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -3793,7 +3793,7 @@ frame@98c0000 {
>  		};
>  
>  		saw3: syscon@9a10000 {
> -			compatible = "syscon";
> +			compatible = "qcom,msm8996-saw3", "syscon";

Can we please follow the rest of the SAW devices? Rob, would you please
change it to qcom,msm8996-saw3-cbf or qcom,msm8996-saw3-v1.0-cbf? There
are other SAW blocks on MSM8996 platforms (which are being controlled by
the firmware on the devices we support upstream, phones with older
firmware might need to name and control them).

>  			reg = <0x09a10000 0x1000>;
>  		};
>  
> 
> -- 
> 2.53.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH 0/2] arm64: dts: qcom: Add MSM8996 SAW3 compatible

[Konrad Dybcio]

On 11/12/26 9:26 PM, Rob Herring (Arm) wrote:
> 'syscon' nodes are required to have specific compatibles, but the 
> MSM8996 SAW3 nodes are lacking one. This series adds one.
> 
> The binding should be applied with the dts changes to avoid new 
> warnings.
> 
> Rob

I know this has been a thorn in our side for a long long time.

I believe +Dmitry had recently come up with some patches to describe
it "properly" - are they any different from this series, Dmitry?

Konrad

Re: [PATCH 0/2] arm64: dts: qcom: Add MSM8996 SAW3 compatible

[Krzysztof Kozlowski]

On Fri, Nov 13, 2026 at 08:52:08AM +0100, Konrad Dybcio wrote:
> On 11/12/26 9:26 PM, Rob Herring (Arm) wrote:
> > 'syscon' nodes are required to have specific compatibles, but the 
> > MSM8996 SAW3 nodes are lacking one. This series adds one.
> > 
> > The binding should be applied with the dts changes to avoid new 
> > warnings.
> > 
> > Rob
> 
> I know this has been a thorn in our side for a long long time.
> 
> I believe +Dmitry had recently come up with some patches to describe
> it "properly" - are they any different from this series, Dmitry?

Let's get existing warnings fixed finally...

Best regards,
Krzysztof

Re: [PATCH 0/2] arm64: dts: qcom: Add MSM8996 SAW3 compatible

[Dmitry Baryshkov]

On Fri, Nov 13, 2026 at 08:52:08AM +0100, Konrad Dybcio wrote:
> On 11/12/26 9:26 PM, Rob Herring (Arm) wrote:
> > 'syscon' nodes are required to have specific compatibles, but the 
> > MSM8996 SAW3 nodes are lacking one. This series adds one.
> > 
> > The binding should be applied with the dts changes to avoid new 
> > warnings.
> > 
> > Rob
> 
> I know this has been a thorn in our side for a long long time.
> 
> I believe +Dmitry had recently come up with some patches to describe
> it "properly" - are they any different from this series, Dmitry?

No, on MSM8996 the CBF SAW3 block doesn't need extra programming, only
the voltage change sequence, which is already implemented. Historically
I tried to control the SAW/SPM directly, reinit it and set the AVS, but
it seems it was a mistake. Pending patches (sorry) from my side don't
touch the SAW, the CPR3 uses the APCC regulator as is.

> 
> Konrad

-- 
With best wishes
Dmitry