mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	 Thomas Gleixner <tglx@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,  "H. Peter Anvin" <hpa@zytor.com>,
	Qiuxu Zhuo <qzhuo@nvidia.com>,  Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Rik van Riel <riel@surriel.com>,
	Breno Leitao <leitao@debian.org>,
	 kernel-team@meta.com, stable@vger.kernel.org
Subject: [PATCH v3 0/2] x86/mce: Rate-limit messages from corrected error floods
Date: Fri, 13 Nov 2026 04:49:13 -0800	[thread overview]
Message-ID: <20261113-mci_ratelimit-v3-0-ada38c5a6c88@debian.org> (raw)

A machine check bank that reports corrected errors at a high rate
makes the MCE code print two messages without any bound: "Machine
check events logged" for every error mce_log() queues, and "CMCI storm
detected" / "CMCI storm subsided" every time the bank enters or leaves
storm mode.

One host printed about 100 million "Machine check events logged" lines
an hour. On another, the storm notices were 82% of everything it wrote
to the kernel log.

Patch 1, from Rik, restores the two-per-minute limit that "Machine
check events logged" had before it moved into mce_log(). It is a fix
and is tagged for stable.

Patch 2 puts both storm notices behind one ratelimit, with the default
interval and burst.

Only the messages are limited. The errors are still logged and storm
handling is unchanged.

Both patches were posted separately before. Borislav asked to merge
them into one series [1].

[1] https://lore.kernel.org/r/20261112182125.GDavYDpdJpmpU2Piyu@fat_crate.local

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Changes in v3:
- Add Rik's "x86/mce: Restore rate limit on MCE logged message" as
  patch 1 (Borislav). It carries the Reviewed-by tags from its
  posting; only its first changelog sentence changed (typo, commit
  reference style).
- Link to Rik's posting: https://patch.msgid.link/20261108143751.3af49e48@fangorn
- Link to v2: https://patch.msgid.link/20261112-mci_ratelimit-v2-1-a9e67055526b@debian.org

Changes in v2:
- rebased on linux-next
- Link to v1: https://patch.msgid.link/20260827-mci_ratelimit-v1-1-ac43df769b36@debian.org

---
Breno Leitao (1):
      x86/mce: Rate-limit the CMCI storm transition notices

Rik van Riel (1):
      x86/mce: Restore rate limit on MCE logged message

 arch/x86/kernel/cpu/mce/core.c      |  6 +++++-
 arch/x86/kernel/cpu/mce/threshold.c | 16 ++++++++++++++--
 2 files changed, 19 insertions(+), 3 deletions(-)
---
base-commit: aaa2f954c21b205a0bcd0961e5b2be4e82e58455
change-id: 20260827-mci_ratelimit-064421e2d8cd

Best regards,
--  
Breno Leitao <leitao@debian.org>


             reply	other threads:[~2026-11-13 13:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 12:49 Breno Leitao [this message]
2026-11-13 12:49 ` [PATCH v3 1/2] x86/mce: Restore rate limit on MCE logged message Breno Leitao
2026-11-13 21:15   ` Sohil Mehta
2026-11-13 12:49 ` [PATCH v3 2/2] x86/mce: Rate-limit the CMCI storm transition notices Breno Leitao
2026-11-13 15:38   ` Qiuxu (Leo) Zhuo
2026-11-13 21:20   ` Sohil Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113-mci_ratelimit-v3-0-ada38c5a6c88@debian.org \
    --to=leitao@debian.org \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kernel-team@meta.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=qiuxu.zhuo@intel.com \
    --cc=qzhuo@nvidia.com \
    --cc=riel@surriel.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®