Re: [PATCH v3 1/2] x86/mce: Restore rate limit on MCE logged message

[Sohil Mehta <sohil.mehta@intel.com>]

On 11/13/2026 4:49 AM, Breno Leitao wrote:
> From: Rik van Riel <riel@surriel.com>
> 
> Commit ea324444ece9f ("x86/mce: Restore MCA polling interval halving")
> moved the "Machine check events logged" print from mce_notify_irq()
> into mce_log() and dropped its two-per-minute rate limit as a side
> effect.
> 
> A particularly unhappy system can spew out around 100 million
> of those "Machine check events logged" messages every hour,
> without that rate limit. A large fleet may have several unhappy
> systems, leaving the netcons infrastructure somewhat flustered.
> 
> Reinstate the rate limit we had before.
> 

Nit: How about avoiding the 'we' and saying:

  Reinstate the two-per-minute rate limit.

> Fixes: ea324444ece9f ("x86/mce: Restore MCA polling interval halving")
> Cc: stable@vger.kernel.org
> Signed-off-by: Rik van Riel <riel@surriel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Qiuxu Zhuo <qzhuo@nvidia.com>
> Reviewed-by: Breno Leitao <leitao@debian.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---

Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>

>  arch/x86/kernel/cpu/mce/core.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
> index 50b1614968be6a..06f858faf2b1cd 100644
> --- a/arch/x86/kernel/cpu/mce/core.c
> +++ b/arch/x86/kernel/cpu/mce/core.c
> @@ -150,8 +150,12 @@ EXPORT_PER_CPU_SYMBOL_GPL(injectm);
>  
>  void mce_log(struct mce_hw_err *err)
>  {
> +	/* Not more than two messages every minute */
> +	static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
> +
>  	if (mce_gen_pool_add(err)) {
> -		pr_info(HW_ERR "Machine check events logged\n");
> +		if (__ratelimit(&ratelimit))
> +			pr_info(HW_ERR "Machine check events logged\n");
>  		irq_work_queue(&mce_irq_work);
>  	}
>  }
>