mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rupesh Majhi <zoone.rupert@gmail.com>
Cc: "Andy Shevchenko" <andy@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Eddie James" <eajames@linux.ibm.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Paulius Zaleckas" <paulius.zaleckas@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: pressure: infineon,dps310: Add interrupts
Date: Fri, 13 Nov 2026 02:17:10 +0000	[thread overview]
Message-ID: <20261113021710.7211ade3@jic23-hlaptop> (raw)
In-Reply-To: <20261110154254.39092-2-zoone.rupert@gmail.com>

On Tue, 10 Nov 2026 17:42:53 +0200
Rupesh Majhi <zoone.rupert@gmail.com> wrote:

> DPS310 signals new results and a full FIFO on its SDO pin. In I2C mode
> the same pin sets the address LSB, and interrupt polarity must be the
> opposite of how SDO is strapped.

Some hardware engineer is presumably proud they made that work!

I'm not sure why we never had the SPI part of this binding but
given it's not there and it gets more complicated wrt to this
that can be addressed if anyone ever adds SPI.

Anyhow, to me this looks fine.

Jonathan


> 
> Signed-off-by: Rupesh Majhi <zoone.rupert@gmail.com>
> ---
> Cc: Paulius Zaleckas <paulius.zaleckas@gmail.com>
> 
>  .../bindings/iio/pressure/infineon,dps310.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml b/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> index 416117dfd927..cded6e0af147 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/infineon,dps310.yaml
> @@ -23,6 +23,12 @@ properties:
>    reg:
>      maxItems: 1
>  
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      New result or full FIFO, on SDO pin. SDO also selects I2C address, so
> +      interrupt is active high at 0x76 (SDO low) and active low at 0x77.
> +
>    "#io-channel-cells":
>      const: 0
>  
> @@ -42,6 +48,8 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
>      i2c {
>          #address-cells = <1>;
>          #size-cells = <0>;
> @@ -49,6 +57,8 @@ examples:
>          dps: pressure-sensor@76 {
>              compatible = "infineon,dps310";
>              reg = <0x76>;
> +            interrupt-parent = <&gpio0>;
> +            interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
>              #io-channel-cells = <0>;
>              vdd-supply = <&vref1>;
>              vddio-supply = <&vref2>;


  reply	other threads:[~2026-11-13  2:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:42 [PATCH 0/2] iio: pressure: dps310: data-ready trigger Rupesh Majhi
2026-11-10 15:42 ` [PATCH 1/2] dt-bindings: iio: pressure: infineon,dps310: Add interrupts Rupesh Majhi
2026-11-13  2:17   ` Jonathan Cameron [this message]
2026-11-10 15:42 ` [PATCH 2/2] iio: pressure: dps310: add a data-ready trigger Rupesh Majhi
2026-11-10 16:48   ` Andy Shevchenko
     [not found]   ` <sashiko-outbox-208073@kernel.org>
2026-11-11 20:00     ` Rupesh Majhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113021710.7211ade3@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=eajames@linux.ibm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=paulius.zaleckas@gmail.com \
    --cc=robh@kernel.org \
    --cc=zoone.rupert@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®