From: Borislav Petkov <bp@alien8.de>
To: Yuanhe Shu <xiangzao@linux.alibaba.com>
Cc: dave.hansen@linux.intel.com, jarkko@kernel.org, tglx@kernel.org,
mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-sgx@vger.kernel.org,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
challvy.tee@gmail.com
Subject: Re: [PATCH v2] x86/crash: Disable SGX in the kdump kernel
Date: Fri, 13 Nov 2026 15:41:04 -0800 [thread overview]
Message-ID: <20261113234104.GDavegEC6UiLEfcfo9@fat_crate.local> (raw)
In-Reply-To: <20261113082036.52175-1-xiangzao@linux.alibaba.com>
On Fri, Nov 13, 2026 at 04:20:36PM +0800, Yuanhe Shu wrote:
> Sorry, I misunderstood your point - language and my reading
> comprehension got in the way.
>
> Based on the v1 review and your feedback, my proposed approach is a
> small kdump_disable_features() in the x86 kdump code that checks
> is_kdump_kernel() and clears the cap, called from setup_arch() after
> parse_early_param(). This keeps the disable in x86 kdump code without
> a parameter hook. Does that work for you?
You should do what Dave told you:
https://lore.kernel.org/all/f20043bc-87a1-4ce3-89aa-49fa1f2ff092@intel.com
and no more.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2026-11-13 23:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:50 Yuanhe Shu
2026-11-13 4:15 ` Borislav Petkov
2026-11-13 5:57 ` Yuanhe Shu
2026-11-13 6:18 ` Borislav Petkov
2026-11-13 8:20 ` Yuanhe Shu
2026-11-13 23:41 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113234104.GDavegEC6UiLEfcfo9@fat_crate.local \
--to=bp@alien8.de \
--cc=challvy.tee@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jarkko@kernel.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=xiangzao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®