From: Hongliang Yang <hongliang.yang@cixtech.com>
To: linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Cc: Hongliang Yang <hongliang.yang@cixtech.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Gary Yang <Gary.Yang@cixtech.com>,
Fugang Duan <fugang.duan@cixtech.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
Subject: Re: [PATCH v8 1/2] dt-bindings: usb: Add CIX Sky1 USBSSP controller
Date: Sun, 15 Nov 2026 10:40:40 +0800 [thread overview]
Message-ID: <20261115024040.4125133-1-hongliang.yang@cixtech.com> (raw)
In-Reply-To: <sashiko-outbox-210199@kernel.org>
Two points.
> [Medium] dt-bindings: usb: cix,sky1-usbssp: overlapping reg windows in
> RCSU block
The example size is wrong, thank you. The window of one instance ends after
STRAP_STATUS0 at 0x091c0400, so it is 0xf0 bytes. With 0x100 the example
reaches 0x091c0413 and includes STRAP_STATUS4 at 0x091c0410, which is the
status register of the other instance. v9 fixes the example; the arm64 dts
is not part of this series and gets the same fix when it is posted.
The -EBUSY does not happen. cdnsp_sky1_probe() maps the range with
devm_ioremap(), not devm_platform_ioremap_resource(), because the windows
overlap, and that is why the overlap is written down in the schema.
Two 4-byte entries, "strap" and "status", as in cix,sky1-pcie-host.yaml,
would remove the overlap, and the driver would not need the offset of the
status register inside the window either. That is the shape question the DT
review already asked, though: v8 keeps the single range that v7 introduced
in answer to it, and I asked Krzysztof which of the two he wants before
posting another version (1794391238.309976-1-hongliang.yang@cixtech.com).
If he prefers two entries, v9 will be that.
> [Medium] dt-bindings: usb: cix,sky1-usbssp: redundant disable
> properties
cix,ssp-disable is not redundant. It clears CFG_3XPORT_SSP_SUPPORT, BIT(31)
of the 3xPort mode register in the host register set. maximum-speed is read
only by the gadget paths, through usb_get_maximum_speed() in cdns3-gadget.c
and cdnsp-gadget.c; nothing in the host path reads it. For a port that runs
in host mode there is no other way to keep it at Gen1.
cix,u3-port-disable is not redundant either: it writes the integration value
0xa0031e07 to the 3xPort mode register in both register sets, and
maximum-speed can neither express nor restore those port mode bits. You are
right that the device-side register is also updated by cdnsp_run() from the
child's speed, so a dual-role port could ask for SuperSpeed Plus on an
integration without SuperSpeed lanes. Every board we ship that sets the
property uses it on a host-only port (dr_mode = "host"), where the gadget is
never started, so the two writers do not meet there. v9 states that
constraint in the property description.
Best regards,
Hongliang Yang
next prev parent reply other threads:[~2026-11-15 2:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 2:21 [PATCH v8 0/2] Add CIX Sky1 USBSSP controller support Hongliang Yang
2026-11-12 2:21 ` [PATCH v8 1/2] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
[not found] ` <sashiko-outbox-210199@kernel.org>
2026-11-15 2:40 ` Hongliang Yang [this message]
2026-11-16 10:13 ` Krzysztof Kozlowski
2026-11-12 2:21 ` [PATCH v8 2/2] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
[not found] ` <sashiko-outbox-210229@kernel.org>
2026-11-13 3:31 ` Hongliang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115024040.4125133-1-hongliang.yang@cixtech.com \
--to=hongliang.yang@cixtech.com \
--cc=Gary.Yang@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®