From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hongliang Yang <hongliang.yang@cixtech.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Gary Yang <Gary.Yang@cixtech.com>,
Fugang Duan <fugang.duan@cixtech.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH v8 1/2] dt-bindings: usb: Add CIX Sky1 USBSSP controller
Date: Mon, 16 Nov 2026 11:13:21 +0100 [thread overview]
Message-ID: <20261116-hypersonic-purring-shoebill-5bbfa9@quoll> (raw)
In-Reply-To: <20261112022141.4136099-2-hongliang.yang@cixtech.com>
On Thu, Nov 12, 2026 at 10:21:40AM +0800, Hongliang Yang wrote:
> +required:
> + - compatible
> + - reg
> + - ranges
> + - "#address-cells"
> + - "#size-cells"
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> + - cix,usb-syscon
> +
> +patternProperties:
> + "^usb@[0-9a-f]+$":
> + $ref: cdns,usb3.yaml#
Please move patternProperties before "required:" block.
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/cix,sky1.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/reset/cix,sky1-s5-system-control.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + usb@91c0314 {
> + compatible = "cix,sky1-usbssp";
> + reg = <0x00 0x91c0314 0x00 0x100>;
> + ranges;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + clocks = <&scmi_clk CLK_TREE_USB3A_H0_CLK_SOF>,
> + <&scmi_clk CLK_TREE_USB3A_0_AXI_GATE>,
> + <&scmi_clk CLK_TREE_USB3A_H0_CLK_LPM>,
> + <&scmi_clk CLK_TREE_USB3A_0_APB_GATE>;
> + clock-names = "sof", "axi", "lpm", "apb";
> + resets = <&src SKY1_USBC_SS2_PRST_N>,
> + <&src SKY1_USBC_SS2_RST_N>;
> + reset-names = "apb", "core";
> + cix,usb-syscon = <&src 0x424 8>;
> +
> + usb@91d0000 {
> + compatible = "cdns,usb3";
> + reg = <0x00 0x91d0000 0x00 0x4000>,
> + <0x00 0x91d8000 0x00 0x8000>,
> + <0x00 0x91d4000 0x00 0x4000>;
> + reg-names = "otg", "xhci", "dev";
> + dr_mode = "otg";
> +
> + interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "host", "peripheral", "otg", "wakeup";
> + maximum-speed = "super-speed-plus";
> +
> + phys = <&usb3_phy4>, <&usb2_phy4>;
> + phy-names = "cdns3,usb3-phy", "cdns3,usb2-phy";
> + };
> + };
> +
> + usb2_phy4: usb-phy {
> + compatible = "usb-nop-xceiv";
> + #phy-cells = <0>;
> + };
And drop usb-phy
With these two:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-16 10:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 2:21 [PATCH v8 0/2] Add CIX Sky1 USBSSP controller support Hongliang Yang
2026-11-12 2:21 ` [PATCH v8 1/2] dt-bindings: usb: Add CIX Sky1 USBSSP controller Hongliang Yang
[not found] ` <sashiko-outbox-210199@kernel.org>
2026-11-15 2:40 ` Hongliang Yang
2026-11-16 10:13 ` Krzysztof Kozlowski [this message]
2026-11-12 2:21 ` [PATCH v8 2/2] usb: cdns3: Add CIX Sky1 glue driver Hongliang Yang
[not found] ` <sashiko-outbox-210229@kernel.org>
2026-11-13 3:31 ` Hongliang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116-hypersonic-purring-shoebill-5bbfa9@quoll \
--to=krzk@kernel.org \
--cc=Gary.Yang@cixtech.com \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=gregkh@linuxfoundation.org \
--cc=hongliang.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®