mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] HID: sony: fix RB3 Pro full report poke timer on 32-bit
@ 2026-11-15  3:05 Sanjay Govind
  0 siblings, 0 replies; only message in thread
From: Sanjay Govind @ 2026-11-15  3:05 UTC (permalink / raw)
  To: Jiri Kosina, Benjamin Tissoires
  Cc: Rosalie Wanders, Brenton Simpson, linux-input, linux-kernel,
	Sanjay Govind

Rock Band 3 Pro instruments need a feature request before they send full
reports, and rb3_pro_instrument_raw_event() rate limits that request
with time_after(jiffies, sc->rb3_pro_poke_jiffies). sony_probe()
initialises rb3_pro_poke_jiffies to 0 so that the first navigation
report triggers the request.

jiffies starts at INITIAL_JIFFIES, which on 32-bit kernels is
-300 * HZ. time_after(jiffies, 0) is therefore false until jiffies
wraps five minutes after boot, so an instrument connected during that
time stays in navigation-only mode until then. 64-bit kernels are not
affected, as INITIAL_JIFFIES is positive there.

Initialise rb3_pro_poke_jiffies to the current jiffies instead, so the
request is sent as soon as navigation reports arrive after probe,
regardless of the jiffies value.

Fixes: 7245b0017d12 ("HID: sony: add support for more instruments")
Signed-off-by: Sanjay Govind <sanjay.govind9@gmail.com>
---

Notes:
    Reported by the Sashiko AI review bot as a pre-existing issue while
    reviewing "HID: sony: fix sleeping in atomic context in RB3 Pro raw
    event handler". Built with W=1 on x86_64. The 32-bit early boot case
    was found by reading include/linux/jiffies.h and was not reproduced.
    
    The fix and changelog were written with the help of an AI coding
    assistant (Claude Opus 5.5).

 drivers/hid/hid-sony.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 50f5ad6bbeb4..8f19d3cc73b1 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2392,7 +2392,7 @@ static int sony_probe(struct hid_device *hdev, const struct hid_device_id *id)
 	}
 
 	if (sc->quirks & RB3_PRO_INSTRUMENT)
-		sc->rb3_pro_poke_jiffies = 0;
+		sc->rb3_pro_poke_jiffies = jiffies;
 
 	if (sc->quirks & (GHL_GUITAR_PS3WIIU | GHL_GUITAR_PS4)) {
 		if (!hid_is_usb(hdev)) {
-- 
2.56.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-15  3:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15  3:05 [PATCH] HID: sony: fix RB3 Pro full report poke timer on 32-bit Sanjay Govind

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®