[PATCH] iio: accel: msa311: use devm_mutex_init()

[PATCH] iio: accel: msa311: use devm_mutex_init()

[Niloy Meharchandani]

Initialize msa311->lock via devm_mutex_init() instead of mutex_init()
in msa311_probe() and propagate any initialization error. Include
<linux/mutex.h> explicitly.

Since msa311 already manages all remaining resources with devm_* helpers
and defines no remove() callback, using devm_mutex_init() ensures proper
mutex cleanup on probe failure or device removal when CONFIG_DEBUG_MUTEXES
is enabled.

No functional change intended. Compile-tested only.

Signed-off-by: Niloy Meharchandani <niloymeharchandani@gmail.com>
---
 drivers/iio/accel/msa311.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/accel/msa311.c b/drivers/iio/accel/msa311.c
index caf9b1b6397f..0e1af4761b7d 100644
--- a/drivers/iio/accel/msa311.c
+++ b/drivers/iio/accel/msa311.c
@@ -29,6 +29,7 @@
 
 #include <linux/i2c.h>
 #include <linux/module.h>
+#include <linux/mutex.h>
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
 #include <linux/regmap.h>
@@ -1156,7 +1157,9 @@ static int msa311_probe(struct i2c_client *i2c)
 	if (err)
 		return err;
 
-	mutex_init(&msa311->lock);
+	err = devm_mutex_init(dev, &msa311->lock);
+	if (err)
+		return err;
 
 	err = devm_regulator_get_enable(dev, "vdd");
 	if (err)
-- 
2.53.0

Re: [PATCH] iio: accel: msa311: use devm_mutex_init()

[Arnav Kapoor]

On Sat, Nov 14, 2026 at 06:01:29PM -0800, Niloy Meharchandani wrote:
> Initialize msa311->lock via devm_mutex_init() instead of mutex_init()
> in msa311_probe() and propagate any initialization error. Include
> <linux/mutex.h> explicitly.

Reviewed-by: Arnav Kapoor <kapoorarnav43@gmail.com>