mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] PM: hibernate: Fix partial snapshot reads
@ 2026-11-15 17:29 Avi Weiss
  0 siblings, 0 replies; only message in thread
From: Avi Weiss @ 2026-11-15 17:29 UTC (permalink / raw)
  To: rafael; +Cc: pavel, lenb, linux-pm, linux-kernel, Avi Weiss

After a partial read, snapshot_read() passes the remaining page
length to simple_read_from_buffer(). The helper interprets this
length as the total buffer size and subtracts the offset again,
causing premature EOF while image data remains unread.

Pass PAGE_SIZE so the helper accounts for the offset only once.

Fixes: d3c1b24c50e8 ("PM / Hibernate: Snapshot cleanup")
Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
---
 kernel/power/user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/power/user.c b/kernel/power/user.c
index 6e4f40e49319..d5e2b8d0b55b 100644
--- a/kernel/power/user.c
+++ b/kernel/power/user.c
@@ -154,7 +154,7 @@ static ssize_t snapshot_read(struct file *filp, char __user *buf,
 		if (res <= 0)
 			goto Unlock;
 	} else {
-		res = PAGE_SIZE - pg_offp;
+		res = PAGE_SIZE;
 	}
 
 	res = simple_read_from_buffer(buf, count, &pg_offp,

base-commit: 97d73c8251226cf27cc6656b4c542869bb8c69fa
-- 
2.43.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2026-11-15 17:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15 17:29 [PATCH] PM: hibernate: Fix partial snapshot reads Avi Weiss

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®